From: Phil Blundell <pb@pbcl.net>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] gnu-efi: Make setjmp.S portable to ARM
Date: Mon, 07 Sep 2015 15:15:13 +0100 [thread overview]
Message-ID: <1441635313.22688.40.camel@pbcl.net> (raw)
In-Reply-To: <CAJTo0LYt6Qd0OGqZgGKAtxpKuq9Cr2SUr42=vNa67+zPsUebYg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 813 bytes --]
On Mon, 2015-09-07 at 15:08 +0100, Burton, Ross wrote:
>
>
> On 7 September 2015 at 03:19, <wenzong.fan@windriver.com> wrote:
>
> + > Note on targets where the @ character is the start of a
> comment
> + > (eg ARM) then another character is used instead. For
> example the
> + > ARM port uses the % character.
>
>
>
> Is the documentation badly written or does this now broke the build on
> x86?
Surely the ARM assembly code would never have worked on x86 anyway.
It's a bit of a mystery how the original code ever worked for anyone on
ARM, given that binutils has behaved this way for nearly 20 years, but
this patch does seem like an improvement.
I agree that the commit message leaves a little bit to be desired
though.
p.
[-- Attachment #2: Type: text/html, Size: 1337 bytes --]
next prev parent reply other threads:[~2015-09-07 14:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-07 2:19 [PATCH] gnu-efi: Make setjmp.S portable to ARM wenzong.fan
2015-09-07 14:08 ` Burton, Ross
2015-09-07 14:15 ` Phil Blundell [this message]
2015-09-07 14:18 ` Burton, Ross
2015-09-08 1:24 ` wenzong fan
2015-09-08 11:58 ` Gary Thomas
2015-09-08 11:59 ` Burton, Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441635313.22688.40.camel@pbcl.net \
--to=pb@pbcl.net \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.