All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gary Thomas <gary@mlbassoc.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] gnu-efi: Make setjmp.S portable to ARM
Date: Tue, 8 Sep 2015 05:58:37 -0600	[thread overview]
Message-ID: <55EECD6D.3010602@mlbassoc.com> (raw)
In-Reply-To: <55EE38C7.30300@windriver.com>

On 2015-09-07 19:24, wenzong fan wrote:
> On 09/07/2015 10:08 PM, Burton, Ross wrote:
>>
>> On 7 September 2015 at 03:19, <wenzong.fan@windriver.com
>> <mailto:wenzong.fan@windriver.com>> wrote:
>>
>>     +  > Note on targets where the @ character is the start of a comment
>>     +  > (eg ARM) then another character is used instead. For example the
>>     +  > ARM port uses the % character.
>>
>>
>> Is the documentation badly written or does this now broke the build on x86?
>
> The lib/arm/setjmp.S is introduced by gnu-efi 3.0.3, there's not such assembler file in 3.0.2.
>
> It only fails while building qemuarm target.

Since this file is [obviously] only built on ARM targets,
perhaps the patch should only be applied there?  e.g. use
   SRC_URI_arm = "file://gnu-efi-Make-setjmp.S-portable-to-ARM.patch"
instead of adding it to SRC_URI

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------


  reply	other threads:[~2015-09-08 11:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-07  2:19 [PATCH] gnu-efi: Make setjmp.S portable to ARM wenzong.fan
2015-09-07 14:08 ` Burton, Ross
2015-09-07 14:15   ` Phil Blundell
2015-09-07 14:18     ` Burton, Ross
2015-09-08  1:24   ` wenzong fan
2015-09-08 11:58     ` Gary Thomas [this message]
2015-09-08 11:59       ` Burton, Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55EECD6D.3010602@mlbassoc.com \
    --to=gary@mlbassoc.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.