* [PATCH] bitbake-worker: Ensure pipe closure doesn't crash before killpg()
@ 2015-09-09 21:44 Richard Purdie
0 siblings, 0 replies; only message in thread
From: Richard Purdie @ 2015-09-09 21:44 UTC (permalink / raw)
To: bitbake-devel
If the pipe is closed, we want to ensure that we kill any child processes
by triggering the sigterm handler before we exit. This code does that,
hopefully avoiding the remaining process left behind issues on the autobuilder.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
diff --git a/bitbake/bin/bitbake-worker b/bitbake/bin/bitbake-worker
index 0551d02..9a6b467 100755
--- a/bitbake/bin/bitbake-worker
+++ b/bitbake/bin/bitbake-worker
@@ -87,7 +87,11 @@ def worker_child_fire(event, d):
global worker_pipe
data = "<event>" + pickle.dumps(event) + "</event>"
- worker_pipe.write(data)
+ try:
+ worker_pipe.write(data)
+ except IOError:
+ sigterm_handler(None, None)
+ raise
bb.event.worker_fire = worker_fire
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-09-09 21:44 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-09 21:44 [PATCH] bitbake-worker: Ensure pipe closure doesn't crash before killpg() Richard Purdie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.