From: Michael Ellerman <mpe@ellerman.id.au>
To: Scott Wood <scottwood@freescale.com>
Cc: christophe leroy <christophe.leroy@c-s.fr>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Joakim Tjernlund <joakim.tjernlund@transmode.se>
Subject: Re: [PATCH] powerpc/book3s32: Only select PPC_HAVE_PMU on e600
Date: Thu, 10 Sep 2015 10:47:36 +1000 [thread overview]
Message-ID: <1441846056.31931.1.camel@ellerman.id.au> (raw)
In-Reply-To: <1441837481.2623.6.camel@freescale.com>
On Wed, 2015-09-09 at 17:24 -0500, Scott Wood wrote:
> On Fri, 2015-09-04 at 20:00 +0200, christophe leroy wrote:
> > Le 04/09/2015 18:43, Scott Wood a écrit :
> > > On Thu, Sep 03, 2015 at 11:27:03AM +0200, Christophe Leroy wrote:
> > > > On PPC832x, perf record/report reports martian addresses
> > > >
> > > > 2.62% perf_reseau4 libpthread-2.18.so [.] __libc_send
> > > > 2.56% perf_reseau4 [kernel.kallsyms] [k] __ip_make_skb
> > > > 1.62% perf_reseau4 [kernel.kallsyms] [k]
> > > > __ip_append_data.isra.39
> > > > 1.55% perf_reseau4 [kernel.kallsyms] [k] ip_finish_output
> > > > 1.33% perf_reseau4 [unknown] [k] 0x7ffffd94
> > > > 1.33% perf_reseau4 [unknown] [k] 0x7ffffd95
> > > > 1.28% perf_reseau4 [unknown] [k] 0x7ffffd97
> > > > 1.26% perf_reseau4 [unknown] [k] 0x7ffffda3
> > > > 1.24% perf_reseau4 [unknown] [k] 0x7ffffd98
> > > > 1.22% perf_reseau4 [unknown] [k] 0x7ffffd92
> > > > 1.22% perf_reseau4 [unknown] [k] 0x7ffffd9b
> > > > [.....]
> > > >
> > > > This is due to function perf_instruction_pointer() reading SPR SIAR
> > > > which doesn't exist on e300 core. The perf_instruction_pointer() is
> > > > redefined in arch/powerpc/perf/core-book3s.c when CONFIG_PPC_PERF_CTRS
> > > > is selected.
> > > >
> > > > This patch moves the selection of CONFIG_PPC_HAVE_PMU in 86xx section
> > > > so that CONFIG_PPC_PERF_CTRS won't be selected for other 6xx powerpc
> > > >
> > > > Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
> > > So, what happens when a kernel is built that supports both 83xx and 86xx?
> > Right, so should we define a processor feature for it ?
>
> There aren't many CPU feature flags left (without changing the mechanism to
> make more available), and runtime patching shouldn't be necessary. Instead,
> use the existing oprofile_type field.
Yep, +1. Only add new cpu feature flags if you really need them please.
> BTW, I don't know why we have pmc_type in addition to that -- the hardware
> only needs to be described once, regardless of how many subsystems care about
> it.
Right, I think that's all just accreted over the years, and predates perf. We
could probably consolidate some of it.
cheers
prev parent reply other threads:[~2015-09-10 0:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-03 9:27 [PATCH] powerpc/book3s32: Only select PPC_HAVE_PMU on e600 Christophe Leroy
2015-09-03 9:47 ` Michael Ellerman
2015-09-04 16:43 ` Scott Wood
2015-09-04 18:00 ` christophe leroy
2015-09-04 18:31 ` Segher Boessenkool
2015-09-04 19:51 ` Segher Boessenkool
2015-09-09 22:24 ` Scott Wood
2015-09-10 0:47 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441846056.31931.1.camel@ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=joakim.tjernlund@transmode.se \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.