From: Christophe Leroy <christophe.leroy@c-s.fr>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
scottwood@freescale.com
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Joakim Tjernlund <joakim.tjernlund@transmode.se>
Subject: [PATCH] powerpc/book3s32: Only select PPC_HAVE_PMU on e600
Date: Thu, 3 Sep 2015 11:27:03 +0200 (CEST) [thread overview]
Message-ID: <20150903092704.2F4881A241D@localhost.localdomain> (raw)
On PPC832x, perf record/report reports martian addresses
2.62% perf_reseau4 libpthread-2.18.so [.] __libc_send
2.56% perf_reseau4 [kernel.kallsyms] [k] __ip_make_skb
1.62% perf_reseau4 [kernel.kallsyms] [k] __ip_append_data.isra.39
1.55% perf_reseau4 [kernel.kallsyms] [k] ip_finish_output
1.33% perf_reseau4 [unknown] [k] 0x7ffffd94
1.33% perf_reseau4 [unknown] [k] 0x7ffffd95
1.28% perf_reseau4 [unknown] [k] 0x7ffffd97
1.26% perf_reseau4 [unknown] [k] 0x7ffffda3
1.24% perf_reseau4 [unknown] [k] 0x7ffffd98
1.22% perf_reseau4 [unknown] [k] 0x7ffffd92
1.22% perf_reseau4 [unknown] [k] 0x7ffffd9b
[.....]
This is due to function perf_instruction_pointer() reading SPR SIAR
which doesn't exist on e300 core. The perf_instruction_pointer() is
redefined in arch/powerpc/perf/core-book3s.c when CONFIG_PPC_PERF_CTRS
is selected.
This patch moves the selection of CONFIG_PPC_HAVE_PMU in 86xx section
so that CONFIG_PPC_PERF_CTRS won't be selected for other 6xx powerpc
Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
---
arch/powerpc/platforms/86xx/Kconfig | 1 +
arch/powerpc/platforms/Kconfig.cputype | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/86xx/Kconfig b/arch/powerpc/platforms/86xx/Kconfig
index 1afd1e4..bb24d2a 100644
--- a/arch/powerpc/platforms/86xx/Kconfig
+++ b/arch/powerpc/platforms/86xx/Kconfig
@@ -5,6 +5,7 @@ menuconfig PPC_86xx
select FSL_SOC
select ALTIVEC
select ARCH_WANT_OPTIONAL_GPIOLIB
+ select PPC_HAVE_PMU_SUPPORT
help
The Freescale E600 SoCs have 74xx cores.
diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype
index d642cf9..aa63b12 100644
--- a/arch/powerpc/platforms/Kconfig.cputype
+++ b/arch/powerpc/platforms/Kconfig.cputype
@@ -143,7 +143,6 @@ config PPC_BOOK3E
config 6xx
def_bool y
depends on PPC32 && PPC_BOOK3S
- select PPC_HAVE_PMU_SUPPORT
config TUNE_CELL
bool "Optimize for Cell Broadband Engine"
--
2.1.0
next reply other threads:[~2015-09-03 9:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-03 9:27 Christophe Leroy [this message]
2015-09-03 9:47 ` [PATCH] powerpc/book3s32: Only select PPC_HAVE_PMU on e600 Michael Ellerman
2015-09-04 16:43 ` Scott Wood
2015-09-04 18:00 ` christophe leroy
2015-09-04 18:31 ` Segher Boessenkool
2015-09-04 19:51 ` Segher Boessenkool
2015-09-09 22:24 ` Scott Wood
2015-09-10 0:47 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150903092704.2F4881A241D@localhost.localdomain \
--to=christophe.leroy@c-s.fr \
--cc=benh@kernel.crashing.org \
--cc=joakim.tjernlund@transmode.se \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.