From: Joe Perches <joe@perches.com>
To: Shraddha Barke <shraddha.6596@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jes Sorensen <Jes.Sorensen@redhat.com>,
Julia Lawall <julia.lawall@lip6.fr>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] Staging: rtl8723au: Bool tests don't need comparisons
Date: Fri, 11 Sep 2015 23:27:34 -0700 [thread overview]
Message-ID: <1442039254.2769.2.camel@perches.com> (raw)
In-Reply-To: <1442037000-2953-1-git-send-email-shraddha.6596@gmail.com>
On Sat, 2015-09-12 at 11:19 +0530, Shraddha Barke wrote:
> This patch removes comparisons to true/false values on bool variables.
> Fixed using Coccinelle
Please do the "== false" and "!= false" cases at the same time
or in another patch.
> diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c b/drivers/staging/rtl8723au/core/rtw_ap.c
[]
> @@ -409,7 +409,7 @@ void add_RATid23a(struct rtw_adapter *padapter, struct sta_info *psta, u8 rssi_l
>
> arg |= BIT(7);/* support entry 2~31 */
>
> - if (shortGIrate == true)
> + if (shortGIrate)
> arg |= BIT(5);
>
> tx_ra_bitmap |= ((raid<<28)&0xf0000000);
prev parent reply other threads:[~2015-09-12 6:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-12 5:49 [PATCH 1/4] Staging: rtl8723au: Bool tests don't need comparisons Shraddha Barke
2015-09-12 5:49 ` [PATCH 2/4] Staging: rtl8188eu: " Shraddha Barke
2015-09-12 5:49 ` [PATCH 3/4] Staging: rtl8712: " Shraddha Barke
2015-09-12 5:50 ` [PATCH 4/4] Staging: vt6656: " Shraddha Barke
2015-09-12 6:10 ` Julia Lawall
2015-09-12 6:27 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442039254.2769.2.camel@perches.com \
--to=joe@perches.com \
--cc=Jes.Sorensen@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=shraddha.6596@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.