* [PATCH v2 1/2] fsl: Add binding for RCPM @ 2015-09-15 8:55 ` Dongsheng Wang 0 siblings, 0 replies; 39+ messages in thread From: Dongsheng Wang @ 2015-09-15 8:55 UTC (permalink / raw) To: scottwood Cc: devicetree, linuxppc-dev, robh+dt, linux-arm-kernel, alison.wang, jason.jin, Wang Dongsheng, Chenhui Zhao, Tang Yuantian From: Wang Dongsheng <dongsheng.wang@freescale.com> RCPM is the Run Control and Power Management module performs all device-level tasks associated with device run control and power management. Add this for freescale powerpc platform and layerscape platform. Signed-off-by: Chenhui Zhao <chenhui.zhao@freescale.com> Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com> Signed-off-by: Wang Dongsheng <dongsheng.wang@freescale.com> --- *v2* - Remove P4080 example. - Modify rcpm-wakeup property description. diff --git a/Documentation/devicetree/bindings/soc/fsl/rcpm.txt b/Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file mode 100644 index 0000000..ea24d76 --- /dev/null +++ b/Documentation/devicetree/bindings/soc/fsl/rcpm.txt @@ -0,0 +1,60 @@ +* Run Control and Power Management +------------------------------------------- +The RCPM performs all device-level tasks associated with device run control +and power management. + +Required properites: + - reg : Offset and length of the register set of RCPM block. + - compatible : Sould contain a chip-specific RCPM block compatible string + and (if applicable) may contain a chassis-version RCPM compatible string. + Chip-specific strings are of the form "fsl,<chip>-rcpm", such as: + * "fsl,p2041-rcpm" + * "fsl,p3041-rcpm" + * "fsl,p4080-rcpm" + * "fsl,p5020-rcpm" + * "fsl,p5040-rcpm" + * "fsl,t4240-rcpm" + * "fsl,b4420-rcpm" + * "fsl,b4860-rcpm" + + Chassis-version strings are of the form "fsl,qoriq-rcpm-<version>", + such as: + * "fsl,qoriq-rcpm-1.0": for chassis 1.0 rcpm + * "fsl,qoriq-rcpm-2.0": for chassis 2.0 rcpm + * "fsl,qoriq-rcpm-2.1": for chassis 2.1 rcpm + +All references to "1.0" and "2.0" refer to the QorIQ chassis version to +which the chip complies. +Chassis Version Example Chips +--------------- ------------------------------- +1.0 p4080, p5020, p5040, p2041, p3041 +2.0 t4240, b4860, b4420 +2.1 t1040, ls1021 + +Example: +The RCPM node for T4240: + rcpm: global-utilities@e2000 { + compatible = "fsl,t4240-rcpm", "fsl,qoriq-rcpm-2.0"; + reg = <0xe2000 0x1000>; + }; + +* Freescale RCPM Wakeup Source Device Tree Bindings +------------------------------------------- +Required rcpm-wakeup property should be added to a device node if the device +can be used as a wakeup source. + + - rcpm-wakeup: The value of the property consists of 3 cells. The first cell + is a pointer to the rcpm node, the second cell is the bit mask that + should be set in IPPDEXPCR0, and the last cell is for IPPDEXPCR1. + Note: If the platform has no IPPDEXPCR1 register, put a zero here. + +Example: + lpuart0: serial@2950000 { + compatible = "fsl,ls1021a-lpuart"; + reg = <0x0 0x2950000 0x0 0x1000>; + interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&sysclk>; + clock-names = "ipg"; + rcpm-wakeup = <&rcpm 0x0 0x40000000>; + status = "disabled"; + }; -- 2.1.0.27.g96db324 ^ permalink raw reply related [flat|nested] 39+ messages in thread
* [PATCH v2 1/2] fsl: Add binding for RCPM @ 2015-09-15 8:55 ` Dongsheng Wang 0 siblings, 0 replies; 39+ messages in thread From: Dongsheng Wang @ 2015-09-15 8:55 UTC (permalink / raw) To: scottwood Cc: devicetree, Chenhui Zhao, alison.wang, Wang Dongsheng, Tang Yuantian, robh+dt, jason.jin, linuxppc-dev, linux-arm-kernel From: Wang Dongsheng <dongsheng.wang@freescale.com> RCPM is the Run Control and Power Management module performs all device-level tasks associated with device run control and power management. Add this for freescale powerpc platform and layerscape platform. Signed-off-by: Chenhui Zhao <chenhui.zhao@freescale.com> Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com> Signed-off-by: Wang Dongsheng <dongsheng.wang@freescale.com> --- *v2* - Remove P4080 example. - Modify rcpm-wakeup property description. diff --git a/Documentation/devicetree/bindings/soc/fsl/rcpm.txt b/Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file mode 100644 index 0000000..ea24d76 --- /dev/null +++ b/Documentation/devicetree/bindings/soc/fsl/rcpm.txt @@ -0,0 +1,60 @@ +* Run Control and Power Management +------------------------------------------- +The RCPM performs all device-level tasks associated with device run control +and power management. + +Required properites: + - reg : Offset and length of the register set of RCPM block. + - compatible : Sould contain a chip-specific RCPM block compatible string + and (if applicable) may contain a chassis-version RCPM compatible string. + Chip-specific strings are of the form "fsl,<chip>-rcpm", such as: + * "fsl,p2041-rcpm" + * "fsl,p3041-rcpm" + * "fsl,p4080-rcpm" + * "fsl,p5020-rcpm" + * "fsl,p5040-rcpm" + * "fsl,t4240-rcpm" + * "fsl,b4420-rcpm" + * "fsl,b4860-rcpm" + + Chassis-version strings are of the form "fsl,qoriq-rcpm-<version>", + such as: + * "fsl,qoriq-rcpm-1.0": for chassis 1.0 rcpm + * "fsl,qoriq-rcpm-2.0": for chassis 2.0 rcpm + * "fsl,qoriq-rcpm-2.1": for chassis 2.1 rcpm + +All references to "1.0" and "2.0" refer to the QorIQ chassis version to +which the chip complies. +Chassis Version Example Chips +--------------- ------------------------------- +1.0 p4080, p5020, p5040, p2041, p3041 +2.0 t4240, b4860, b4420 +2.1 t1040, ls1021 + +Example: +The RCPM node for T4240: + rcpm: global-utilities@e2000 { + compatible = "fsl,t4240-rcpm", "fsl,qoriq-rcpm-2.0"; + reg = <0xe2000 0x1000>; + }; + +* Freescale RCPM Wakeup Source Device Tree Bindings +------------------------------------------- +Required rcpm-wakeup property should be added to a device node if the device +can be used as a wakeup source. + + - rcpm-wakeup: The value of the property consists of 3 cells. The first cell + is a pointer to the rcpm node, the second cell is the bit mask that + should be set in IPPDEXPCR0, and the last cell is for IPPDEXPCR1. + Note: If the platform has no IPPDEXPCR1 register, put a zero here. + +Example: + lpuart0: serial@2950000 { + compatible = "fsl,ls1021a-lpuart"; + reg = <0x0 0x2950000 0x0 0x1000>; + interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&sysclk>; + clock-names = "ipg"; + rcpm-wakeup = <&rcpm 0x0 0x40000000>; + status = "disabled"; + }; -- 2.1.0.27.g96db324 ^ permalink raw reply related [flat|nested] 39+ messages in thread
* [PATCH v2 1/2] fsl: Add binding for RCPM @ 2015-09-15 8:55 ` Dongsheng Wang 0 siblings, 0 replies; 39+ messages in thread From: Dongsheng Wang @ 2015-09-15 8:55 UTC (permalink / raw) To: linux-arm-kernel From: Wang Dongsheng <dongsheng.wang@freescale.com> RCPM is the Run Control and Power Management module performs all device-level tasks associated with device run control and power management. Add this for freescale powerpc platform and layerscape platform. Signed-off-by: Chenhui Zhao <chenhui.zhao@freescale.com> Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com> Signed-off-by: Wang Dongsheng <dongsheng.wang@freescale.com> --- *v2* - Remove P4080 example. - Modify rcpm-wakeup property description. diff --git a/Documentation/devicetree/bindings/soc/fsl/rcpm.txt b/Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file mode 100644 index 0000000..ea24d76 --- /dev/null +++ b/Documentation/devicetree/bindings/soc/fsl/rcpm.txt @@ -0,0 +1,60 @@ +* Run Control and Power Management +------------------------------------------- +The RCPM performs all device-level tasks associated with device run control +and power management. + +Required properites: + - reg : Offset and length of the register set of RCPM block. + - compatible : Sould contain a chip-specific RCPM block compatible string + and (if applicable) may contain a chassis-version RCPM compatible string. + Chip-specific strings are of the form "fsl,<chip>-rcpm", such as: + * "fsl,p2041-rcpm" + * "fsl,p3041-rcpm" + * "fsl,p4080-rcpm" + * "fsl,p5020-rcpm" + * "fsl,p5040-rcpm" + * "fsl,t4240-rcpm" + * "fsl,b4420-rcpm" + * "fsl,b4860-rcpm" + + Chassis-version strings are of the form "fsl,qoriq-rcpm-<version>", + such as: + * "fsl,qoriq-rcpm-1.0": for chassis 1.0 rcpm + * "fsl,qoriq-rcpm-2.0": for chassis 2.0 rcpm + * "fsl,qoriq-rcpm-2.1": for chassis 2.1 rcpm + +All references to "1.0" and "2.0" refer to the QorIQ chassis version to +which the chip complies. +Chassis Version Example Chips +--------------- ------------------------------- +1.0 p4080, p5020, p5040, p2041, p3041 +2.0 t4240, b4860, b4420 +2.1 t1040, ls1021 + +Example: +The RCPM node for T4240: + rcpm: global-utilities at e2000 { + compatible = "fsl,t4240-rcpm", "fsl,qoriq-rcpm-2.0"; + reg = <0xe2000 0x1000>; + }; + +* Freescale RCPM Wakeup Source Device Tree Bindings +------------------------------------------- +Required rcpm-wakeup property should be added to a device node if the device +can be used as a wakeup source. + + - rcpm-wakeup: The value of the property consists of 3 cells. The first cell + is a pointer to the rcpm node, the second cell is the bit mask that + should be set in IPPDEXPCR0, and the last cell is for IPPDEXPCR1. + Note: If the platform has no IPPDEXPCR1 register, put a zero here. + +Example: + lpuart0: serial at 2950000 { + compatible = "fsl,ls1021a-lpuart"; + reg = <0x0 0x2950000 0x0 0x1000>; + interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&sysclk>; + clock-names = "ipg"; + rcpm-wakeup = <&rcpm 0x0 0x40000000>; + status = "disabled"; + }; -- 2.1.0.27.g96db324 ^ permalink raw reply related [flat|nested] 39+ messages in thread
* [PATCH v2 2/2] arm/layerscape: add RCPM device tree support for ls1021a. 2015-09-15 8:55 ` Dongsheng Wang (?) @ 2015-09-15 8:55 ` Dongsheng Wang -1 siblings, 0 replies; 39+ messages in thread From: Dongsheng Wang @ 2015-09-15 8:55 UTC (permalink / raw) To: scottwood Cc: devicetree, linuxppc-dev, robh+dt, linux-arm-kernel, alison.wang, jason.jin, Wang Dongsheng From: Wang Dongsheng <dongsheng.wang@freescale.com> Signed-off-by: Wang Dongsheng <dongsheng.wang@freescale.com> --- *v2*: No changes. diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi index 973a496..deb1271 100644 --- a/arch/arm/boot/dts/ls1021a.dtsi +++ b/arch/arm/boot/dts/ls1021a.dtsi @@ -139,6 +139,7 @@ sdhci,auto-cmd12; big-endian; bus-width = <4>; + rcpm-wakeup = <&rcpm 0x00000080 0x0>; status = "disabled"; }; @@ -186,6 +187,11 @@ }; }; + rcpm: rcpm@1ee2000 { + compatible = "fsl,ls1021a-rcpm", "fsl,qoriq-rcpm-2.1"; + reg = <0x0 0x1ee2000 0x0 0x10000>; + }; + dspi0: dspi@2100000 { compatible = "fsl,ls1021a-v1.0-dspi"; #address-cells = <1>; @@ -287,6 +293,7 @@ interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>; clocks = <&sysclk>; clock-names = "ipg"; + rcpm-wakeup = <&rcpm 0x0 0x40000000>; status = "disabled"; }; -- 2.1.0.27.g96db324 ^ permalink raw reply related [flat|nested] 39+ messages in thread
* [PATCH v2 2/2] arm/layerscape: add RCPM device tree support for ls1021a. @ 2015-09-15 8:55 ` Dongsheng Wang 0 siblings, 0 replies; 39+ messages in thread From: Dongsheng Wang @ 2015-09-15 8:55 UTC (permalink / raw) To: scottwood Cc: devicetree, alison.wang, Wang Dongsheng, robh+dt, jason.jin, linuxppc-dev, linux-arm-kernel From: Wang Dongsheng <dongsheng.wang@freescale.com> Signed-off-by: Wang Dongsheng <dongsheng.wang@freescale.com> --- *v2*: No changes. diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi index 973a496..deb1271 100644 --- a/arch/arm/boot/dts/ls1021a.dtsi +++ b/arch/arm/boot/dts/ls1021a.dtsi @@ -139,6 +139,7 @@ sdhci,auto-cmd12; big-endian; bus-width = <4>; + rcpm-wakeup = <&rcpm 0x00000080 0x0>; status = "disabled"; }; @@ -186,6 +187,11 @@ }; }; + rcpm: rcpm@1ee2000 { + compatible = "fsl,ls1021a-rcpm", "fsl,qoriq-rcpm-2.1"; + reg = <0x0 0x1ee2000 0x0 0x10000>; + }; + dspi0: dspi@2100000 { compatible = "fsl,ls1021a-v1.0-dspi"; #address-cells = <1>; @@ -287,6 +293,7 @@ interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>; clocks = <&sysclk>; clock-names = "ipg"; + rcpm-wakeup = <&rcpm 0x0 0x40000000>; status = "disabled"; }; -- 2.1.0.27.g96db324 ^ permalink raw reply related [flat|nested] 39+ messages in thread
* [PATCH v2 2/2] arm/layerscape: add RCPM device tree support for ls1021a. @ 2015-09-15 8:55 ` Dongsheng Wang 0 siblings, 0 replies; 39+ messages in thread From: Dongsheng Wang @ 2015-09-15 8:55 UTC (permalink / raw) To: linux-arm-kernel From: Wang Dongsheng <dongsheng.wang@freescale.com> Signed-off-by: Wang Dongsheng <dongsheng.wang@freescale.com> --- *v2*: No changes. diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi index 973a496..deb1271 100644 --- a/arch/arm/boot/dts/ls1021a.dtsi +++ b/arch/arm/boot/dts/ls1021a.dtsi @@ -139,6 +139,7 @@ sdhci,auto-cmd12; big-endian; bus-width = <4>; + rcpm-wakeup = <&rcpm 0x00000080 0x0>; status = "disabled"; }; @@ -186,6 +187,11 @@ }; }; + rcpm: rcpm at 1ee2000 { + compatible = "fsl,ls1021a-rcpm", "fsl,qoriq-rcpm-2.1"; + reg = <0x0 0x1ee2000 0x0 0x10000>; + }; + dspi0: dspi at 2100000 { compatible = "fsl,ls1021a-v1.0-dspi"; #address-cells = <1>; @@ -287,6 +293,7 @@ interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>; clocks = <&sysclk>; clock-names = "ipg"; + rcpm-wakeup = <&rcpm 0x0 0x40000000>; status = "disabled"; }; -- 2.1.0.27.g96db324 ^ permalink raw reply related [flat|nested] 39+ messages in thread
* Re: [PATCH v2 1/2] fsl: Add binding for RCPM 2015-09-15 8:55 ` Dongsheng Wang (?) @ 2015-09-15 23:56 ` Scott Wood -1 siblings, 0 replies; 39+ messages in thread From: Scott Wood @ 2015-09-15 23:56 UTC (permalink / raw) To: Dongsheng Wang Cc: devicetree, linuxppc-dev, robh+dt, linux-arm-kernel, alison.wang, jason.jin, Chenhui Zhao, Tang Yuantian On Tue, 2015-09-15 at 16:55 +0800, Dongsheng Wang wrote: > +* Freescale RCPM Wakeup Source Device Tree Bindings > +------------------------------------------- > +Required rcpm-wakeup property should be added to a device node if the > device > +can be used as a wakeup source. > + > + - rcpm-wakeup: The value of the property consists of 3 cells. The first > cell > + is a pointer to the rcpm node, the second cell is the bit mask that > + should be set in IPPDEXPCR0, and the last cell is for IPPDEXPCR1. > + Note: If the platform has no IPPDEXPCR1 register, put a zero here. What if a future platform has more than two of these registers? -Scott ^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [PATCH v2 1/2] fsl: Add binding for RCPM @ 2015-09-15 23:56 ` Scott Wood 0 siblings, 0 replies; 39+ messages in thread From: Scott Wood @ 2015-09-15 23:56 UTC (permalink / raw) To: Dongsheng Wang Cc: devicetree, Chenhui Zhao, alison.wang, Tang Yuantian, robh+dt, jason.jin, linuxppc-dev, linux-arm-kernel On Tue, 2015-09-15 at 16:55 +0800, Dongsheng Wang wrote: > +* Freescale RCPM Wakeup Source Device Tree Bindings > +------------------------------------------- > +Required rcpm-wakeup property should be added to a device node if the > device > +can be used as a wakeup source. > + > + - rcpm-wakeup: The value of the property consists of 3 cells. The first > cell > + is a pointer to the rcpm node, the second cell is the bit mask that > + should be set in IPPDEXPCR0, and the last cell is for IPPDEXPCR1. > + Note: If the platform has no IPPDEXPCR1 register, put a zero here. What if a future platform has more than two of these registers? -Scott ^ permalink raw reply [flat|nested] 39+ messages in thread
* [PATCH v2 1/2] fsl: Add binding for RCPM @ 2015-09-15 23:56 ` Scott Wood 0 siblings, 0 replies; 39+ messages in thread From: Scott Wood @ 2015-09-15 23:56 UTC (permalink / raw) To: linux-arm-kernel On Tue, 2015-09-15 at 16:55 +0800, Dongsheng Wang wrote: > +* Freescale RCPM Wakeup Source Device Tree Bindings > +------------------------------------------- > +Required rcpm-wakeup property should be added to a device node if the > device > +can be used as a wakeup source. > + > + - rcpm-wakeup: The value of the property consists of 3 cells. The first > cell > + is a pointer to the rcpm node, the second cell is the bit mask that > + should be set in IPPDEXPCR0, and the last cell is for IPPDEXPCR1. > + Note: If the platform has no IPPDEXPCR1 register, put a zero here. What if a future platform has more than two of these registers? -Scott ^ permalink raw reply [flat|nested] 39+ messages in thread
* RE: [PATCH v2 1/2] fsl: Add binding for RCPM 2015-09-15 23:56 ` Scott Wood (?) @ 2015-09-16 2:15 ` Wang Dongsheng -1 siblings, 0 replies; 39+ messages in thread From: Wang Dongsheng @ 2015-09-16 2:15 UTC (permalink / raw) To: Scott Wood Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, Huan Wang, Jin Jason, Zhao C.H., Yuantian Tang SGkgU2NvdHQsDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogV29vZCBT Y290dC1CMDc0MjENCj4gU2VudDogV2VkbmVzZGF5LCBTZXB0ZW1iZXIgMTYsIDIwMTUgNzo1NyBB TQ0KPiBUbzogV2FuZyBEb25nc2hlbmctQjQwNTM0DQo+IENjOiBkZXZpY2V0cmVlQHZnZXIua2Vy bmVsLm9yZzsgbGludXhwcGMtZGV2QGxpc3RzLm96bGFicy5vcmc7DQo+IHJvYmgrZHRAa2VybmVs Lm9yZzsgbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnOyBXYW5nIEh1YW4tQjE4 OTY1OyBKaW4NCj4gWmhlbmd4aW9uZy1SNjQxODg7IFpoYW8gQ2hlbmh1aS1CMzUzMzY7IFRhbmcg WXVhbnRpYW4tQjI5OTgzDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjIgMS8yXSBmc2w6IEFkZCBi aW5kaW5nIGZvciBSQ1BNDQo+IA0KPiBPbiBUdWUsIDIwMTUtMDktMTUgYXQgMTY6NTUgKzA4MDAs IERvbmdzaGVuZyBXYW5nIHdyb3RlOg0KPiA+ICsqIEZyZWVzY2FsZSBSQ1BNIFdha2V1cCBTb3Vy Y2UgRGV2aWNlIFRyZWUgQmluZGluZ3MNCj4gPiArLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLQ0KPiA+ICtSZXF1aXJlZCByY3BtLXdha2V1cCBwcm9wZXJ0eSBzaG91 bGQgYmUgYWRkZWQgdG8gYSBkZXZpY2Ugbm9kZSBpZiB0aGUNCj4gPiBkZXZpY2UNCj4gPiArY2Fu IGJlIHVzZWQgYXMgYSB3YWtldXAgc291cmNlLg0KPiA+ICsNCj4gPiArICAtIHJjcG0td2FrZXVw OiBUaGUgdmFsdWUgb2YgdGhlIHByb3BlcnR5IGNvbnNpc3RzIG9mIDMgY2VsbHMuIFRoZSBmaXJz dA0KPiA+IGNlbGwNCj4gPiArICAgICBpcyBhIHBvaW50ZXIgdG8gdGhlIHJjcG0gbm9kZSwgdGhl IHNlY29uZCBjZWxsIGlzIHRoZSBiaXQgbWFzayB0aGF0DQo+ID4gKyAgICAgc2hvdWxkIGJlIHNl dCBpbiBJUFBERVhQQ1IwLCBhbmQgdGhlIGxhc3QgY2VsbCBpcyBmb3IgSVBQREVYUENSMS4NCj4g PiArICAgICBOb3RlOiBJZiB0aGUgcGxhdGZvcm0gaGFzIG5vIElQUERFWFBDUjEgcmVnaXN0ZXIs IHB1dCBhIHplcm8gaGVyZS4NCj4gDQo+IFdoYXQgaWYgYSBmdXR1cmUgcGxhdGZvcm0gaGFzIG1v cmUgdGhhbiB0d28gb2YgdGhlc2UgcmVnaXN0ZXJzPw0KDQpUaG9zZSByZWdpc3RlcnMgYXJlIG9u bHkgdXNlZCBmb3Igd2FrZXVwIGRldmljZSwgd2UgaGF2ZSBhIGxvdCBvZiBhdmFpbGFibGUgYml0 DQpmb3IgZmVhdHVyZS4gRm9yIGV4YW1wbGUsIEluIExTMTAyMWEgcGxhdGZvcm0gb25seSA3Yml0 cyBoYXMgdXNlZCBpbiB0aGUgcmVnaXN0ZXJzLA0KYW5kIDU3Yml0cyBpcyByZXNlcnZlZC4NCg0K UmVnYXJkcywNCi1Eb25nc2hlbmcNCg== ^ permalink raw reply [flat|nested] 39+ messages in thread
* RE: [PATCH v2 1/2] fsl: Add binding for RCPM @ 2015-09-16 2:15 ` Wang Dongsheng 0 siblings, 0 replies; 39+ messages in thread From: Wang Dongsheng @ 2015-09-16 2:15 UTC (permalink / raw) To: Scott Wood Cc: devicetree@vger.kernel.org, Zhao C.H., Huan Wang, Yuantian Tang, robh+dt@kernel.org, Jin Jason, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Hi Scott, > -----Original Message----- > From: Wood Scott-B07421 > Sent: Wednesday, September 16, 2015 7:57 AM > To: Wang Dongsheng-B40534 > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > robh+dt@kernel.org; linux-arm-kernel@lists.infradead.org; Wang Huan-B18965; Jin > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983 > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > On Tue, 2015-09-15 at 16:55 +0800, Dongsheng Wang wrote: > > +* Freescale RCPM Wakeup Source Device Tree Bindings > > +------------------------------------------- > > +Required rcpm-wakeup property should be added to a device node if the > > device > > +can be used as a wakeup source. > > + > > + - rcpm-wakeup: The value of the property consists of 3 cells. The first > > cell > > + is a pointer to the rcpm node, the second cell is the bit mask that > > + should be set in IPPDEXPCR0, and the last cell is for IPPDEXPCR1. > > + Note: If the platform has no IPPDEXPCR1 register, put a zero here. > > What if a future platform has more than two of these registers? Those registers are only used for wakeup device, we have a lot of available bit for feature. For example, In LS1021a platform only 7bits has used in the registers, and 57bits is reserved. Regards, -Dongsheng _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev ^ permalink raw reply [flat|nested] 39+ messages in thread
* [PATCH v2 1/2] fsl: Add binding for RCPM @ 2015-09-16 2:15 ` Wang Dongsheng 0 siblings, 0 replies; 39+ messages in thread From: Wang Dongsheng @ 2015-09-16 2:15 UTC (permalink / raw) To: linux-arm-kernel Hi Scott, > -----Original Message----- > From: Wood Scott-B07421 > Sent: Wednesday, September 16, 2015 7:57 AM > To: Wang Dongsheng-B40534 > Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; > robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang Huan-B18965; Jin > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983 > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > On Tue, 2015-09-15 at 16:55 +0800, Dongsheng Wang wrote: > > +* Freescale RCPM Wakeup Source Device Tree Bindings > > +------------------------------------------- > > +Required rcpm-wakeup property should be added to a device node if the > > device > > +can be used as a wakeup source. > > + > > + - rcpm-wakeup: The value of the property consists of 3 cells. The first > > cell > > + is a pointer to the rcpm node, the second cell is the bit mask that > > + should be set in IPPDEXPCR0, and the last cell is for IPPDEXPCR1. > > + Note: If the platform has no IPPDEXPCR1 register, put a zero here. > > What if a future platform has more than two of these registers? Those registers are only used for wakeup device, we have a lot of available bit for feature. For example, In LS1021a platform only 7bits has used in the registers, and 57bits is reserved. Regards, -Dongsheng ^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [PATCH v2 1/2] fsl: Add binding for RCPM 2015-09-16 2:15 ` Wang Dongsheng (?) @ 2015-09-16 2:19 ` Scott Wood -1 siblings, 0 replies; 39+ messages in thread From: Scott Wood @ 2015-09-16 2:19 UTC (permalink / raw) To: Wang Dongsheng-B40534 Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, Wang Huan-B18965, Jin Zhengxiong-R64188, Zhao Chenhui-B35336, Tang Yuantian-B29983 On Tue, 2015-09-15 at 21:15 -0500, Wang Dongsheng-B40534 wrote: > Hi Scott, > > > -----Original Message----- > > From: Wood Scott-B07421 > > Sent: Wednesday, September 16, 2015 7:57 AM > > To: Wang Dongsheng-B40534 > > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > > robh+dt@kernel.org; linux-arm-kernel@lists.infradead.org; Wang Huan- > > B18965; Jin > > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983 > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > On Tue, 2015-09-15 at 16:55 +0800, Dongsheng Wang wrote: > > > +* Freescale RCPM Wakeup Source Device Tree Bindings > > > +------------------------------------------- > > > +Required rcpm-wakeup property should be added to a device node if the > > > device > > > +can be used as a wakeup source. > > > + > > > + - rcpm-wakeup: The value of the property consists of 3 cells. The > > > first > > > cell > > > + is a pointer to the rcpm node, the second cell is the bit mask > > > that > > > + should be set in IPPDEXPCR0, and the last cell is for IPPDEXPCR1. > > > + Note: If the platform has no IPPDEXPCR1 register, put a zero here. > > > > What if a future platform has more than two of these registers? > > Those registers are only used for wakeup device, we have a lot of available > bit > for feature. For example, In LS1021a platform only 7bits has used in the > registers, > and 57bits is reserved. Still, it'd be better to for the rcpm node to advertise the number of cells it expects. -Scott ^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [PATCH v2 1/2] fsl: Add binding for RCPM @ 2015-09-16 2:19 ` Scott Wood 0 siblings, 0 replies; 39+ messages in thread From: Scott Wood @ 2015-09-16 2:19 UTC (permalink / raw) To: Wang Dongsheng-B40534 Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Wang Huan-B18965, Jin Zhengxiong-R64188, Zhao Chenhui-B35336, Tang Yuantian-B29983 On Tue, 2015-09-15 at 21:15 -0500, Wang Dongsheng-B40534 wrote: > Hi Scott, > > > -----Original Message----- > > From: Wood Scott-B07421 > > Sent: Wednesday, September 16, 2015 7:57 AM > > To: Wang Dongsheng-B40534 > > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org; > > robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org; linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org; Wang Huan- > > B18965; Jin > > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983 > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > On Tue, 2015-09-15 at 16:55 +0800, Dongsheng Wang wrote: > > > +* Freescale RCPM Wakeup Source Device Tree Bindings > > > +------------------------------------------- > > > +Required rcpm-wakeup property should be added to a device node if the > > > device > > > +can be used as a wakeup source. > > > + > > > + - rcpm-wakeup: The value of the property consists of 3 cells. The > > > first > > > cell > > > + is a pointer to the rcpm node, the second cell is the bit mask > > > that > > > + should be set in IPPDEXPCR0, and the last cell is for IPPDEXPCR1. > > > + Note: If the platform has no IPPDEXPCR1 register, put a zero here. > > > > What if a future platform has more than two of these registers? > > Those registers are only used for wakeup device, we have a lot of available > bit > for feature. For example, In LS1021a platform only 7bits has used in the > registers, > and 57bits is reserved. Still, it'd be better to for the rcpm node to advertise the number of cells it expects. -Scott -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 39+ messages in thread
* [PATCH v2 1/2] fsl: Add binding for RCPM @ 2015-09-16 2:19 ` Scott Wood 0 siblings, 0 replies; 39+ messages in thread From: Scott Wood @ 2015-09-16 2:19 UTC (permalink / raw) To: linux-arm-kernel On Tue, 2015-09-15 at 21:15 -0500, Wang Dongsheng-B40534 wrote: > Hi Scott, > > > -----Original Message----- > > From: Wood Scott-B07421 > > Sent: Wednesday, September 16, 2015 7:57 AM > > To: Wang Dongsheng-B40534 > > Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; > > robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang Huan- > > B18965; Jin > > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983 > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > On Tue, 2015-09-15 at 16:55 +0800, Dongsheng Wang wrote: > > > +* Freescale RCPM Wakeup Source Device Tree Bindings > > > +------------------------------------------- > > > +Required rcpm-wakeup property should be added to a device node if the > > > device > > > +can be used as a wakeup source. > > > + > > > + - rcpm-wakeup: The value of the property consists of 3 cells. The > > > first > > > cell > > > + is a pointer to the rcpm node, the second cell is the bit mask > > > that > > > + should be set in IPPDEXPCR0, and the last cell is for IPPDEXPCR1. > > > + Note: If the platform has no IPPDEXPCR1 register, put a zero here. > > > > What if a future platform has more than two of these registers? > > Those registers are only used for wakeup device, we have a lot of available > bit > for feature. For example, In LS1021a platform only 7bits has used in the > registers, > and 57bits is reserved. Still, it'd be better to for the rcpm node to advertise the number of cells it expects. -Scott ^ permalink raw reply [flat|nested] 39+ messages in thread
* RE: [PATCH v2 1/2] fsl: Add binding for RCPM 2015-09-16 2:19 ` Scott Wood (?) @ 2015-09-16 2:30 ` Wang Dongsheng -1 siblings, 0 replies; 39+ messages in thread From: Wang Dongsheng @ 2015-09-16 2:30 UTC (permalink / raw) To: Scott Wood Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, Huan Wang, Jin Jason, Zhao C.H., Yuantian Tang SGkgU2NvdHQsDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogV29vZCBT Y290dC1CMDc0MjENCj4gU2VudDogV2VkbmVzZGF5LCBTZXB0ZW1iZXIgMTYsIDIwMTUgMTA6MTkg QU0NCj4gVG86IFdhbmcgRG9uZ3NoZW5nLUI0MDUzNA0KPiBDYzogZGV2aWNldHJlZUB2Z2VyLmtl cm5lbC5vcmc7IGxpbnV4cHBjLWRldkBsaXN0cy5vemxhYnMub3JnOw0KPiByb2JoK2R0QGtlcm5l bC5vcmc7IGxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZzsgV2FuZyBIdWFuLUIx ODk2NTsgSmluDQo+IFpoZW5neGlvbmctUjY0MTg4OyBaaGFvIENoZW5odWktQjM1MzM2OyBUYW5n IFl1YW50aWFuLUIyOTk4Mw0KPiBTdWJqZWN0OiBSZTogW1BBVENIIHYyIDEvMl0gZnNsOiBBZGQg YmluZGluZyBmb3IgUkNQTQ0KPiANCj4gT24gVHVlLCAyMDE1LTA5LTE1IGF0IDIxOjE1IC0wNTAw LCBXYW5nIERvbmdzaGVuZy1CNDA1MzQgd3JvdGU6DQo+ID4gSGkgU2NvdHQsDQo+ID4NCj4gPiA+ IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4gPiBGcm9tOiBXb29kIFNjb3R0LUIwNzQy MQ0KPiA+ID4gU2VudDogV2VkbmVzZGF5LCBTZXB0ZW1iZXIgMTYsIDIwMTUgNzo1NyBBTQ0KPiA+ ID4gVG86IFdhbmcgRG9uZ3NoZW5nLUI0MDUzNA0KPiA+ID4gQ2M6IGRldmljZXRyZWVAdmdlci5r ZXJuZWwub3JnOyBsaW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9yZzsNCj4gPiA+IHJvYmgrZHRA a2VybmVsLm9yZzsgbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnOyBXYW5nIEh1 YW4tDQo+ID4gPiBCMTg5NjU7IEppbg0KPiA+ID4gWmhlbmd4aW9uZy1SNjQxODg7IFpoYW8gQ2hl bmh1aS1CMzUzMzY7IFRhbmcgWXVhbnRpYW4tQjI5OTgzDQo+ID4gPiBTdWJqZWN0OiBSZTogW1BB VENIIHYyIDEvMl0gZnNsOiBBZGQgYmluZGluZyBmb3IgUkNQTQ0KPiA+ID4NCj4gPiA+IE9uIFR1 ZSwgMjAxNS0wOS0xNSBhdCAxNjo1NSArMDgwMCwgRG9uZ3NoZW5nIFdhbmcgd3JvdGU6DQo+ID4g PiA+ICsqIEZyZWVzY2FsZSBSQ1BNIFdha2V1cCBTb3VyY2UgRGV2aWNlIFRyZWUgQmluZGluZ3MN Cj4gPiA+ID4gKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0NCj4g PiA+ID4gK1JlcXVpcmVkIHJjcG0td2FrZXVwIHByb3BlcnR5IHNob3VsZCBiZSBhZGRlZCB0byBh IGRldmljZSBub2RlIGlmDQo+ID4gPiA+ICt0aGUNCj4gPiA+ID4gZGV2aWNlDQo+ID4gPiA+ICtj YW4gYmUgdXNlZCBhcyBhIHdha2V1cCBzb3VyY2UuDQo+ID4gPiA+ICsNCj4gPiA+ID4gKyAgLSBy Y3BtLXdha2V1cDogVGhlIHZhbHVlIG9mIHRoZSBwcm9wZXJ0eSBjb25zaXN0cyBvZiAzIGNlbGxz Lg0KPiA+ID4gPiArIFRoZQ0KPiA+ID4gPiBmaXJzdA0KPiA+ID4gPiBjZWxsDQo+ID4gPiA+ICsg ICAgIGlzIGEgcG9pbnRlciB0byB0aGUgcmNwbSBub2RlLCB0aGUgc2Vjb25kIGNlbGwgaXMgdGhl IGJpdA0KPiA+ID4gPiArIG1hc2sNCj4gPiA+ID4gdGhhdA0KPiA+ID4gPiArICAgICBzaG91bGQg YmUgc2V0IGluIElQUERFWFBDUjAsIGFuZCB0aGUgbGFzdCBjZWxsIGlzIGZvciBJUFBERVhQQ1Ix Lg0KPiA+ID4gPiArICAgICBOb3RlOiBJZiB0aGUgcGxhdGZvcm0gaGFzIG5vIElQUERFWFBDUjEg cmVnaXN0ZXIsIHB1dCBhIHplcm8gaGVyZS4NCj4gPiA+DQo+ID4gPiBXaGF0IGlmIGEgZnV0dXJl IHBsYXRmb3JtIGhhcyBtb3JlIHRoYW4gdHdvIG9mIHRoZXNlIHJlZ2lzdGVycz8NCj4gPg0KPiA+ IFRob3NlIHJlZ2lzdGVycyBhcmUgb25seSB1c2VkIGZvciB3YWtldXAgZGV2aWNlLCB3ZSBoYXZl IGEgbG90IG9mDQo+ID4gYXZhaWxhYmxlIGJpdCBmb3IgZmVhdHVyZS4gRm9yIGV4YW1wbGUsIElu IExTMTAyMWEgcGxhdGZvcm0gb25seSA3Yml0cw0KPiA+IGhhcyB1c2VkIGluIHRoZSByZWdpc3Rl cnMsIGFuZCA1N2JpdHMgaXMgcmVzZXJ2ZWQuDQo+IA0KPiBTdGlsbCwgaXQnZCBiZSBiZXR0ZXIg dG8gZm9yIHRoZSByY3BtIG5vZGUgdG8gYWR2ZXJ0aXNlIHRoZSBudW1iZXIgb2YgY2VsbHMgaXQN Cj4gZXhwZWN0cy4NCg0KRm9yIHRoZSBmb3Jlc2VlYWJsZSBmdXR1cmUgaXQgc2hvdWxkIGJlIGVu b3VnaCB0byB1c2UsIGV2ZW4gaWYgbm90IGVub3VnaCB0byB1c2UgaW4NCnRoZSBmdXR1cmUgYXQg dGhhdCB0aW1lIHdlIGNhbiB1cGRhdGUgdGhlIGJpbmRpbmcuDQoNClJlZ2FyZHMsDQotRG9uZ3No ZW5nDQo= ^ permalink raw reply [flat|nested] 39+ messages in thread
* RE: [PATCH v2 1/2] fsl: Add binding for RCPM @ 2015-09-16 2:30 ` Wang Dongsheng 0 siblings, 0 replies; 39+ messages in thread From: Wang Dongsheng @ 2015-09-16 2:30 UTC (permalink / raw) To: Scott Wood Cc: devicetree@vger.kernel.org, Zhao C.H., Huan Wang, Yuantian Tang, robh+dt@kernel.org, Jin Jason, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Hi Scott, > -----Original Message----- > From: Wood Scott-B07421 > Sent: Wednesday, September 16, 2015 10:19 AM > To: Wang Dongsheng-B40534 > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > robh+dt@kernel.org; linux-arm-kernel@lists.infradead.org; Wang Huan-B18965; Jin > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983 > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > On Tue, 2015-09-15 at 21:15 -0500, Wang Dongsheng-B40534 wrote: > > Hi Scott, > > > > > -----Original Message----- > > > From: Wood Scott-B07421 > > > Sent: Wednesday, September 16, 2015 7:57 AM > > > To: Wang Dongsheng-B40534 > > > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > > > robh+dt@kernel.org; linux-arm-kernel@lists.infradead.org; Wang Huan- > > > B18965; Jin > > > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983 > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > On Tue, 2015-09-15 at 16:55 +0800, Dongsheng Wang wrote: > > > > +* Freescale RCPM Wakeup Source Device Tree Bindings > > > > +------------------------------------------- > > > > +Required rcpm-wakeup property should be added to a device node if > > > > +the > > > > device > > > > +can be used as a wakeup source. > > > > + > > > > + - rcpm-wakeup: The value of the property consists of 3 cells. > > > > + The > > > > first > > > > cell > > > > + is a pointer to the rcpm node, the second cell is the bit > > > > + mask > > > > that > > > > + should be set in IPPDEXPCR0, and the last cell is for IPPDEXPCR1. > > > > + Note: If the platform has no IPPDEXPCR1 register, put a zero here. > > > > > > What if a future platform has more than two of these registers? > > > > Those registers are only used for wakeup device, we have a lot of > > available bit for feature. For example, In LS1021a platform only 7bits > > has used in the registers, and 57bits is reserved. > > Still, it'd be better to for the rcpm node to advertise the number of cells it > expects. For the foreseeable future it should be enough to use, even if not enough to use in the future at that time we can update the binding. Regards, -Dongsheng _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev ^ permalink raw reply [flat|nested] 39+ messages in thread
* [PATCH v2 1/2] fsl: Add binding for RCPM @ 2015-09-16 2:30 ` Wang Dongsheng 0 siblings, 0 replies; 39+ messages in thread From: Wang Dongsheng @ 2015-09-16 2:30 UTC (permalink / raw) To: linux-arm-kernel Hi Scott, > -----Original Message----- > From: Wood Scott-B07421 > Sent: Wednesday, September 16, 2015 10:19 AM > To: Wang Dongsheng-B40534 > Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; > robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang Huan-B18965; Jin > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983 > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > On Tue, 2015-09-15 at 21:15 -0500, Wang Dongsheng-B40534 wrote: > > Hi Scott, > > > > > -----Original Message----- > > > From: Wood Scott-B07421 > > > Sent: Wednesday, September 16, 2015 7:57 AM > > > To: Wang Dongsheng-B40534 > > > Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; > > > robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang Huan- > > > B18965; Jin > > > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983 > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > On Tue, 2015-09-15 at 16:55 +0800, Dongsheng Wang wrote: > > > > +* Freescale RCPM Wakeup Source Device Tree Bindings > > > > +------------------------------------------- > > > > +Required rcpm-wakeup property should be added to a device node if > > > > +the > > > > device > > > > +can be used as a wakeup source. > > > > + > > > > + - rcpm-wakeup: The value of the property consists of 3 cells. > > > > + The > > > > first > > > > cell > > > > + is a pointer to the rcpm node, the second cell is the bit > > > > + mask > > > > that > > > > + should be set in IPPDEXPCR0, and the last cell is for IPPDEXPCR1. > > > > + Note: If the platform has no IPPDEXPCR1 register, put a zero here. > > > > > > What if a future platform has more than two of these registers? > > > > Those registers are only used for wakeup device, we have a lot of > > available bit for feature. For example, In LS1021a platform only 7bits > > has used in the registers, and 57bits is reserved. > > Still, it'd be better to for the rcpm node to advertise the number of cells it > expects. For the foreseeable future it should be enough to use, even if not enough to use in the future at that time we can update the binding. Regards, -Dongsheng ^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [PATCH v2 1/2] fsl: Add binding for RCPM 2015-09-16 2:30 ` Wang Dongsheng (?) @ 2015-09-16 2:31 ` Scott Wood -1 siblings, 0 replies; 39+ messages in thread From: Scott Wood @ 2015-09-16 2:31 UTC (permalink / raw) To: Wang Dongsheng-B40534 Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, Wang Huan-B18965, Jin Zhengxiong-R64188, Zhao Chenhui-B35336, Tang Yuantian-B29983 On Tue, 2015-09-15 at 21:30 -0500, Wang Dongsheng-B40534 wrote: > Hi Scott, > > > -----Original Message----- > > From: Wood Scott-B07421 > > Sent: Wednesday, September 16, 2015 10:19 AM > > To: Wang Dongsheng-B40534 > > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > > robh+dt@kernel.org; linux-arm-kernel@lists.infradead.org; Wang Huan- > > B18965; Jin > > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983 > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > On Tue, 2015-09-15 at 21:15 -0500, Wang Dongsheng-B40534 wrote: > > > Hi Scott, > > > > > > > -----Original Message----- > > > > From: Wood Scott-B07421 > > > > Sent: Wednesday, September 16, 2015 7:57 AM > > > > To: Wang Dongsheng-B40534 > > > > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > > > > robh+dt@kernel.org; linux-arm-kernel@lists.infradead.org; Wang Huan- > > > > B18965; Jin > > > > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983 > > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > > > On Tue, 2015-09-15 at 16:55 +0800, Dongsheng Wang wrote: > > > > > +* Freescale RCPM Wakeup Source Device Tree Bindings > > > > > +------------------------------------------- > > > > > +Required rcpm-wakeup property should be added to a device node if > > > > > +the > > > > > device > > > > > +can be used as a wakeup source. > > > > > + > > > > > + - rcpm-wakeup: The value of the property consists of 3 cells. > > > > > + The > > > > > first > > > > > cell > > > > > + is a pointer to the rcpm node, the second cell is the bit > > > > > + mask > > > > > that > > > > > + should be set in IPPDEXPCR0, and the last cell is for > > > > > IPPDEXPCR1. > > > > > + Note: If the platform has no IPPDEXPCR1 register, put a zero > > > > > here. > > > > > > > > What if a future platform has more than two of these registers? > > > > > > Those registers are only used for wakeup device, we have a lot of > > > available bit for feature. For example, In LS1021a platform only 7bits > > > has used in the registers, and 57bits is reserved. > > > > Still, it'd be better to for the rcpm node to advertise the number of > > cells it > > expects. > > For the foreseeable future it should be enough to use, even if not enough > to use in > the future at that time we can update the binding. That's the whole point. Device tree is stable ABI. Updating it later to not be fixed to two cells would be a lot harder than getting it right from the beginning. Putting the number of cells in the phandle target is a standard device tree idiom. -Scott ^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [PATCH v2 1/2] fsl: Add binding for RCPM @ 2015-09-16 2:31 ` Scott Wood 0 siblings, 0 replies; 39+ messages in thread From: Scott Wood @ 2015-09-16 2:31 UTC (permalink / raw) To: Wang Dongsheng-B40534 Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Wang Huan-B18965, Jin Zhengxiong-R64188, Zhao Chenhui-B35336, Tang Yuantian-B29983 On Tue, 2015-09-15 at 21:30 -0500, Wang Dongsheng-B40534 wrote: > Hi Scott, > > > -----Original Message----- > > From: Wood Scott-B07421 > > Sent: Wednesday, September 16, 2015 10:19 AM > > To: Wang Dongsheng-B40534 > > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org; > > robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org; linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org; Wang Huan- > > B18965; Jin > > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983 > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > On Tue, 2015-09-15 at 21:15 -0500, Wang Dongsheng-B40534 wrote: > > > Hi Scott, > > > > > > > -----Original Message----- > > > > From: Wood Scott-B07421 > > > > Sent: Wednesday, September 16, 2015 7:57 AM > > > > To: Wang Dongsheng-B40534 > > > > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org; > > > > robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org; linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org; Wang Huan- > > > > B18965; Jin > > > > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983 > > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > > > On Tue, 2015-09-15 at 16:55 +0800, Dongsheng Wang wrote: > > > > > +* Freescale RCPM Wakeup Source Device Tree Bindings > > > > > +------------------------------------------- > > > > > +Required rcpm-wakeup property should be added to a device node if > > > > > +the > > > > > device > > > > > +can be used as a wakeup source. > > > > > + > > > > > + - rcpm-wakeup: The value of the property consists of 3 cells. > > > > > + The > > > > > first > > > > > cell > > > > > + is a pointer to the rcpm node, the second cell is the bit > > > > > + mask > > > > > that > > > > > + should be set in IPPDEXPCR0, and the last cell is for > > > > > IPPDEXPCR1. > > > > > + Note: If the platform has no IPPDEXPCR1 register, put a zero > > > > > here. > > > > > > > > What if a future platform has more than two of these registers? > > > > > > Those registers are only used for wakeup device, we have a lot of > > > available bit for feature. For example, In LS1021a platform only 7bits > > > has used in the registers, and 57bits is reserved. > > > > Still, it'd be better to for the rcpm node to advertise the number of > > cells it > > expects. > > For the foreseeable future it should be enough to use, even if not enough > to use in > the future at that time we can update the binding. That's the whole point. Device tree is stable ABI. Updating it later to not be fixed to two cells would be a lot harder than getting it right from the beginning. Putting the number of cells in the phandle target is a standard device tree idiom. -Scott -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 39+ messages in thread
* [PATCH v2 1/2] fsl: Add binding for RCPM @ 2015-09-16 2:31 ` Scott Wood 0 siblings, 0 replies; 39+ messages in thread From: Scott Wood @ 2015-09-16 2:31 UTC (permalink / raw) To: linux-arm-kernel On Tue, 2015-09-15 at 21:30 -0500, Wang Dongsheng-B40534 wrote: > Hi Scott, > > > -----Original Message----- > > From: Wood Scott-B07421 > > Sent: Wednesday, September 16, 2015 10:19 AM > > To: Wang Dongsheng-B40534 > > Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; > > robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang Huan- > > B18965; Jin > > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983 > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > On Tue, 2015-09-15 at 21:15 -0500, Wang Dongsheng-B40534 wrote: > > > Hi Scott, > > > > > > > -----Original Message----- > > > > From: Wood Scott-B07421 > > > > Sent: Wednesday, September 16, 2015 7:57 AM > > > > To: Wang Dongsheng-B40534 > > > > Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; > > > > robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang Huan- > > > > B18965; Jin > > > > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983 > > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > > > On Tue, 2015-09-15 at 16:55 +0800, Dongsheng Wang wrote: > > > > > +* Freescale RCPM Wakeup Source Device Tree Bindings > > > > > +------------------------------------------- > > > > > +Required rcpm-wakeup property should be added to a device node if > > > > > +the > > > > > device > > > > > +can be used as a wakeup source. > > > > > + > > > > > + - rcpm-wakeup: The value of the property consists of 3 cells. > > > > > + The > > > > > first > > > > > cell > > > > > + is a pointer to the rcpm node, the second cell is the bit > > > > > + mask > > > > > that > > > > > + should be set in IPPDEXPCR0, and the last cell is for > > > > > IPPDEXPCR1. > > > > > + Note: If the platform has no IPPDEXPCR1 register, put a zero > > > > > here. > > > > > > > > What if a future platform has more than two of these registers? > > > > > > Those registers are only used for wakeup device, we have a lot of > > > available bit for feature. For example, In LS1021a platform only 7bits > > > has used in the registers, and 57bits is reserved. > > > > Still, it'd be better to for the rcpm node to advertise the number of > > cells it > > expects. > > For the foreseeable future it should be enough to use, even if not enough > to use in > the future at that time we can update the binding. That's the whole point. Device tree is stable ABI. Updating it later to not be fixed to two cells would be a lot harder than getting it right from the beginning. Putting the number of cells in the phandle target is a standard device tree idiom. -Scott ^ permalink raw reply [flat|nested] 39+ messages in thread
* RE: [PATCH v2 1/2] fsl: Add binding for RCPM 2015-09-16 2:31 ` Scott Wood (?) @ 2015-09-16 2:35 ` Yuantian Tang -1 siblings, 0 replies; 39+ messages in thread From: Yuantian Tang @ 2015-09-16 2:35 UTC (permalink / raw) To: Scott Wood, Wang Dongsheng Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, Huan Wang, Jin Jason, Zhao C.H. DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogV29vZCBTY290dC1CMDc0 MjENCj4gU2VudDogV2VkbmVzZGF5LCBTZXB0ZW1iZXIgMTYsIDIwMTUgMTA6MzIgQU0NCj4gVG86 IFdhbmcgRG9uZ3NoZW5nLUI0MDUzNCA8RG9uZ3NoZW5nLldhbmdAZnJlZXNjYWxlLmNvbT4NCj4g Q2M6IGRldmljZXRyZWVAdmdlci5rZXJuZWwub3JnOyBsaW51eHBwYy1kZXZAbGlzdHMub3psYWJz Lm9yZzsNCj4gcm9iaCtkdEBrZXJuZWwub3JnOyBsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJh ZGVhZC5vcmc7IFdhbmcgSHVhbi0NCj4gQjE4OTY1IDxhbGlzb24ud2FuZ0BmcmVlc2NhbGUuY29t PjsgSmluIFpoZW5neGlvbmctUjY0MTg4DQo+IDxKYXNvbi5KaW5AZnJlZXNjYWxlLmNvbT47IFpo YW8gQ2hlbmh1aS1CMzUzMzYNCj4gPGNoZW5odWkuemhhb0BmcmVlc2NhbGUuY29tPjsgVGFuZyBZ dWFudGlhbi1CMjk5ODMNCj4gPFl1YW50aWFuLlRhbmdAZnJlZXNjYWxlLmNvbT4NCj4gU3ViamVj dDogUmU6IFtQQVRDSCB2MiAxLzJdIGZzbDogQWRkIGJpbmRpbmcgZm9yIFJDUE0NCj4gDQo+IE9u IFR1ZSwgMjAxNS0wOS0xNSBhdCAyMTozMCAtMDUwMCwgV2FuZyBEb25nc2hlbmctQjQwNTM0IHdy b3RlOg0KPiA+IEhpIFNjb3R0LA0KPiA+DQo+ID4gPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0t LQ0KPiA+ID4gRnJvbTogV29vZCBTY290dC1CMDc0MjENCj4gPiA+IFNlbnQ6IFdlZG5lc2RheSwg U2VwdGVtYmVyIDE2LCAyMDE1IDEwOjE5IEFNDQo+ID4gPiBUbzogV2FuZyBEb25nc2hlbmctQjQw NTM0DQo+ID4gPiBDYzogZGV2aWNldHJlZUB2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4cHBjLWRldkBs aXN0cy5vemxhYnMub3JnOw0KPiA+ID4gcm9iaCtkdEBrZXJuZWwub3JnOyBsaW51eC1hcm0ta2Vy bmVsQGxpc3RzLmluZnJhZGVhZC5vcmc7IFdhbmcgSHVhbi0NCj4gPiA+IEIxODk2NTsgSmluDQo+ ID4gPiBaaGVuZ3hpb25nLVI2NDE4ODsgWmhhbyBDaGVuaHVpLUIzNTMzNjsgVGFuZyBZdWFudGlh bi1CMjk5ODMNCj4gPiA+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjIgMS8yXSBmc2w6IEFkZCBiaW5k aW5nIGZvciBSQ1BNDQo+ID4gPg0KPiA+ID4gT24gVHVlLCAyMDE1LTA5LTE1IGF0IDIxOjE1IC0w NTAwLCBXYW5nIERvbmdzaGVuZy1CNDA1MzQgd3JvdGU6DQo+ID4gPiA+IEhpIFNjb3R0LA0KPiA+ ID4gPg0KPiA+ID4gPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4gPiA+ID4gRnJv bTogV29vZCBTY290dC1CMDc0MjENCj4gPiA+ID4gPiBTZW50OiBXZWRuZXNkYXksIFNlcHRlbWJl ciAxNiwgMjAxNSA3OjU3IEFNDQo+ID4gPiA+ID4gVG86IFdhbmcgRG9uZ3NoZW5nLUI0MDUzNA0K PiA+ID4gPiA+IENjOiBkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZzsgbGludXhwcGMtZGV2QGxp c3RzLm96bGFicy5vcmc7DQo+ID4gPiA+ID4gcm9iaCtkdEBrZXJuZWwub3JnOyBsaW51eC1hcm0t a2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmc7IFdhbmcNCj4gPiA+ID4gPiByb2JoK0h1YW4tDQo+ ID4gPiA+ID4gQjE4OTY1OyBKaW4NCj4gPiA+ID4gPiBaaGVuZ3hpb25nLVI2NDE4ODsgWmhhbyBD aGVuaHVpLUIzNTMzNjsgVGFuZyBZdWFudGlhbi1CMjk5ODMNCj4gPiA+ID4gPiBTdWJqZWN0OiBS ZTogW1BBVENIIHYyIDEvMl0gZnNsOiBBZGQgYmluZGluZyBmb3IgUkNQTQ0KPiA+ID4gPiA+DQo+ ID4gPiA+ID4gT24gVHVlLCAyMDE1LTA5LTE1IGF0IDE2OjU1ICswODAwLCBEb25nc2hlbmcgV2Fu ZyB3cm90ZToNCj4gPiA+ID4gPiA+ICsqIEZyZWVzY2FsZSBSQ1BNIFdha2V1cCBTb3VyY2UgRGV2 aWNlIFRyZWUgQmluZGluZ3MNCj4gPiA+ID4gPiA+ICstLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tDQo+ID4gPiA+ID4gPiArUmVxdWlyZWQgcmNwbS13YWtldXAgcHJv cGVydHkgc2hvdWxkIGJlIGFkZGVkIHRvIGEgZGV2aWNlDQo+ID4gPiA+ID4gPiArbm9kZSBpZiB0 aGUNCj4gPiA+ID4gPiA+IGRldmljZQ0KPiA+ID4gPiA+ID4gK2NhbiBiZSB1c2VkIGFzIGEgd2Fr ZXVwIHNvdXJjZS4NCj4gPiA+ID4gPiA+ICsNCj4gPiA+ID4gPiA+ICsgIC0gcmNwbS13YWtldXA6 IFRoZSB2YWx1ZSBvZiB0aGUgcHJvcGVydHkgY29uc2lzdHMgb2YgMyBjZWxscy4NCj4gPiA+ID4g PiA+ICsgVGhlDQo+ID4gPiA+ID4gPiBmaXJzdA0KPiA+ID4gPiA+ID4gY2VsbA0KPiA+ID4gPiA+ ID4gKyAgICAgaXMgYSBwb2ludGVyIHRvIHRoZSByY3BtIG5vZGUsIHRoZSBzZWNvbmQgY2VsbCBp cyB0aGUNCj4gPiA+ID4gPiA+ICsgYml0IG1hc2sNCj4gPiA+ID4gPiA+IHRoYXQNCj4gPiA+ID4g PiA+ICsgICAgIHNob3VsZCBiZSBzZXQgaW4gSVBQREVYUENSMCwgYW5kIHRoZSBsYXN0IGNlbGwg aXMgZm9yDQo+ID4gPiA+ID4gPiBJUFBERVhQQ1IxLg0KPiA+ID4gPiA+ID4gKyAgICAgTm90ZTog SWYgdGhlIHBsYXRmb3JtIGhhcyBubyBJUFBERVhQQ1IxIHJlZ2lzdGVyLCBwdXQgYQ0KPiA+ID4g PiA+ID4gKyB6ZXJvDQo+ID4gPiA+ID4gPiBoZXJlLg0KPiA+ID4gPiA+DQo+ID4gPiA+ID4gV2hh dCBpZiBhIGZ1dHVyZSBwbGF0Zm9ybSBoYXMgbW9yZSB0aGFuIHR3byBvZiB0aGVzZSByZWdpc3Rl cnM/DQo+ID4gPiA+DQo+ID4gPiA+IFRob3NlIHJlZ2lzdGVycyBhcmUgb25seSB1c2VkIGZvciB3 YWtldXAgZGV2aWNlLCB3ZSBoYXZlIGEgbG90IG9mDQo+ID4gPiA+IGF2YWlsYWJsZSBiaXQgZm9y IGZlYXR1cmUuIEZvciBleGFtcGxlLCBJbiBMUzEwMjFhIHBsYXRmb3JtIG9ubHkNCj4gPiA+ID4g N2JpdHMgaGFzIHVzZWQgaW4gdGhlIHJlZ2lzdGVycywgYW5kIDU3Yml0cyBpcyByZXNlcnZlZC4N Cj4gPiA+DQo+ID4gPiBTdGlsbCwgaXQnZCBiZSBiZXR0ZXIgdG8gZm9yIHRoZSByY3BtIG5vZGUg dG8gYWR2ZXJ0aXNlIHRoZSBudW1iZXINCj4gPiA+IG9mIGNlbGxzIGl0IGV4cGVjdHMuDQo+ID4N Cj4gPiBGb3IgdGhlIGZvcmVzZWVhYmxlIGZ1dHVyZSBpdCBzaG91bGQgYmUgZW5vdWdoIHRvIHVz ZSwgZXZlbiBpZiBub3QNCj4gPiBlbm91Z2ggdG8gdXNlIGluIHRoZSBmdXR1cmUgYXQgdGhhdCB0 aW1lIHdlIGNhbiB1cGRhdGUgdGhlIGJpbmRpbmcuDQo+IA0KPiBUaGF0J3MgdGhlIHdob2xlIHBv aW50LiAgRGV2aWNlIHRyZWUgaXMgc3RhYmxlIEFCSS4gIFVwZGF0aW5nIGl0IGxhdGVyIHRvIG5v dCBiZQ0KPiBmaXhlZCB0byB0d28gY2VsbHMgd291bGQgYmUgYSBsb3QgaGFyZGVyIHRoYW4gZ2V0 dGluZyBpdCByaWdodCBmcm9tIHRoZQ0KPiBiZWdpbm5pbmcuICBQdXR0aW5nIHRoZSBudW1iZXIg b2YgY2VsbHMgaW4gdGhlIHBoYW5kbGUgdGFyZ2V0IGlzIGEgc3RhbmRhcmQNCj4gZGV2aWNlIHRy ZWUgaWRpb20uDQo+IA0KSSBhZ3JlZSB3aXRoIHlvdS4gQnV0IHdoYXQncyB0aGUgcG9pbnQgYSBT T0MgaGFzIG1vcmUgdGhhbiA2NCB3YWtldXAgc291cmNlPw0KDQpSZWdhcmRzLA0KWXVhbnRpYW4N Cg0KPiAtU2NvdHQNCg0K ^ permalink raw reply [flat|nested] 39+ messages in thread
* RE: [PATCH v2 1/2] fsl: Add binding for RCPM @ 2015-09-16 2:35 ` Yuantian Tang 0 siblings, 0 replies; 39+ messages in thread From: Yuantian Tang @ 2015-09-16 2:35 UTC (permalink / raw) To: Scott Wood, Wang Dongsheng Cc: devicetree@vger.kernel.org, Zhao C.H., Huan Wang, robh+dt@kernel.org, Jin Jason, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org > -----Original Message----- > From: Wood Scott-B07421 > Sent: Wednesday, September 16, 2015 10:32 AM > To: Wang Dongsheng-B40534 <Dongsheng.Wang@freescale.com> > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > robh+dt@kernel.org; linux-arm-kernel@lists.infradead.org; Wang Huan- > B18965 <alison.wang@freescale.com>; Jin Zhengxiong-R64188 > <Jason.Jin@freescale.com>; Zhao Chenhui-B35336 > <chenhui.zhao@freescale.com>; Tang Yuantian-B29983 > <Yuantian.Tang@freescale.com> > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > On Tue, 2015-09-15 at 21:30 -0500, Wang Dongsheng-B40534 wrote: > > Hi Scott, > > > > > -----Original Message----- > > > From: Wood Scott-B07421 > > > Sent: Wednesday, September 16, 2015 10:19 AM > > > To: Wang Dongsheng-B40534 > > > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > > > robh+dt@kernel.org; linux-arm-kernel@lists.infradead.org; Wang Huan- > > > B18965; Jin > > > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983 > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > On Tue, 2015-09-15 at 21:15 -0500, Wang Dongsheng-B40534 wrote: > > > > Hi Scott, > > > > > > > > > -----Original Message----- > > > > > From: Wood Scott-B07421 > > > > > Sent: Wednesday, September 16, 2015 7:57 AM > > > > > To: Wang Dongsheng-B40534 > > > > > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > > > > > robh+dt@kernel.org; linux-arm-kernel@lists.infradead.org; Wang > > > > > robh+Huan- > > > > > B18965; Jin > > > > > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983 > > > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > > > > > On Tue, 2015-09-15 at 16:55 +0800, Dongsheng Wang wrote: > > > > > > +* Freescale RCPM Wakeup Source Device Tree Bindings > > > > > > +------------------------------------------- > > > > > > +Required rcpm-wakeup property should be added to a device > > > > > > +node if the > > > > > > device > > > > > > +can be used as a wakeup source. > > > > > > + > > > > > > + - rcpm-wakeup: The value of the property consists of 3 cells. > > > > > > + The > > > > > > first > > > > > > cell > > > > > > + is a pointer to the rcpm node, the second cell is the > > > > > > + bit mask > > > > > > that > > > > > > + should be set in IPPDEXPCR0, and the last cell is for > > > > > > IPPDEXPCR1. > > > > > > + Note: If the platform has no IPPDEXPCR1 register, put a > > > > > > + zero > > > > > > here. > > > > > > > > > > What if a future platform has more than two of these registers? > > > > > > > > Those registers are only used for wakeup device, we have a lot of > > > > available bit for feature. For example, In LS1021a platform only > > > > 7bits has used in the registers, and 57bits is reserved. > > > > > > Still, it'd be better to for the rcpm node to advertise the number > > > of cells it expects. > > > > For the foreseeable future it should be enough to use, even if not > > enough to use in the future at that time we can update the binding. > > That's the whole point. Device tree is stable ABI. Updating it later to not be > fixed to two cells would be a lot harder than getting it right from the > beginning. Putting the number of cells in the phandle target is a standard > device tree idiom. > I agree with you. But what's the point a SOC has more than 64 wakeup source? Regards, Yuantian > -Scott ^ permalink raw reply [flat|nested] 39+ messages in thread
* [PATCH v2 1/2] fsl: Add binding for RCPM @ 2015-09-16 2:35 ` Yuantian Tang 0 siblings, 0 replies; 39+ messages in thread From: Yuantian Tang @ 2015-09-16 2:35 UTC (permalink / raw) To: linux-arm-kernel > -----Original Message----- > From: Wood Scott-B07421 > Sent: Wednesday, September 16, 2015 10:32 AM > To: Wang Dongsheng-B40534 <Dongsheng.Wang@freescale.com> > Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; > robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang Huan- > B18965 <alison.wang@freescale.com>; Jin Zhengxiong-R64188 > <Jason.Jin@freescale.com>; Zhao Chenhui-B35336 > <chenhui.zhao@freescale.com>; Tang Yuantian-B29983 > <Yuantian.Tang@freescale.com> > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > On Tue, 2015-09-15 at 21:30 -0500, Wang Dongsheng-B40534 wrote: > > Hi Scott, > > > > > -----Original Message----- > > > From: Wood Scott-B07421 > > > Sent: Wednesday, September 16, 2015 10:19 AM > > > To: Wang Dongsheng-B40534 > > > Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; > > > robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang Huan- > > > B18965; Jin > > > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983 > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > On Tue, 2015-09-15 at 21:15 -0500, Wang Dongsheng-B40534 wrote: > > > > Hi Scott, > > > > > > > > > -----Original Message----- > > > > > From: Wood Scott-B07421 > > > > > Sent: Wednesday, September 16, 2015 7:57 AM > > > > > To: Wang Dongsheng-B40534 > > > > > Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; > > > > > robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang > > > > > robh+Huan- > > > > > B18965; Jin > > > > > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983 > > > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > > > > > On Tue, 2015-09-15 at 16:55 +0800, Dongsheng Wang wrote: > > > > > > +* Freescale RCPM Wakeup Source Device Tree Bindings > > > > > > +------------------------------------------- > > > > > > +Required rcpm-wakeup property should be added to a device > > > > > > +node if the > > > > > > device > > > > > > +can be used as a wakeup source. > > > > > > + > > > > > > + - rcpm-wakeup: The value of the property consists of 3 cells. > > > > > > + The > > > > > > first > > > > > > cell > > > > > > + is a pointer to the rcpm node, the second cell is the > > > > > > + bit mask > > > > > > that > > > > > > + should be set in IPPDEXPCR0, and the last cell is for > > > > > > IPPDEXPCR1. > > > > > > + Note: If the platform has no IPPDEXPCR1 register, put a > > > > > > + zero > > > > > > here. > > > > > > > > > > What if a future platform has more than two of these registers? > > > > > > > > Those registers are only used for wakeup device, we have a lot of > > > > available bit for feature. For example, In LS1021a platform only > > > > 7bits has used in the registers, and 57bits is reserved. > > > > > > Still, it'd be better to for the rcpm node to advertise the number > > > of cells it expects. > > > > For the foreseeable future it should be enough to use, even if not > > enough to use in the future at that time we can update the binding. > > That's the whole point. Device tree is stable ABI. Updating it later to not be > fixed to two cells would be a lot harder than getting it right from the > beginning. Putting the number of cells in the phandle target is a standard > device tree idiom. > I agree with you. But what's the point a SOC has more than 64 wakeup source? Regards, Yuantian > -Scott ^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [PATCH v2 1/2] fsl: Add binding for RCPM 2015-09-16 2:35 ` Yuantian Tang (?) @ 2015-09-16 2:37 ` Scott Wood -1 siblings, 0 replies; 39+ messages in thread From: Scott Wood @ 2015-09-16 2:37 UTC (permalink / raw) To: Tang Yuantian-B29983 Cc: Wang Dongsheng-B40534, devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, Wang Huan-B18965, Jin Zhengxiong-R64188, Zhao Chenhui-B35336 On Tue, 2015-09-15 at 21:35 -0500, Tang Yuantian-B29983 wrote: > > > -----Original Message----- > > From: Wood Scott-B07421 > > Sent: Wednesday, September 16, 2015 10:32 AM > > To: Wang Dongsheng-B40534 <Dongsheng.Wang@freescale.com> > > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > > robh+dt@kernel.org; linux-arm-kernel@lists.infradead.org; Wang Huan- > > B18965 <alison.wang@freescale.com>; Jin Zhengxiong-R64188 > > <Jason.Jin@freescale.com>; Zhao Chenhui-B35336 > > <chenhui.zhao@freescale.com>; Tang Yuantian-B29983 > > <Yuantian.Tang@freescale.com> > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > On Tue, 2015-09-15 at 21:30 -0500, Wang Dongsheng-B40534 wrote: > > > Hi Scott, > > > > > > > -----Original Message----- > > > > From: Wood Scott-B07421 > > > > Sent: Wednesday, September 16, 2015 10:19 AM > > > > To: Wang Dongsheng-B40534 > > > > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > > > > robh+dt@kernel.org; linux-arm-kernel@lists.infradead.org; Wang Huan- > > > > B18965; Jin > > > > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983 > > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > > > On Tue, 2015-09-15 at 21:15 -0500, Wang Dongsheng-B40534 wrote: > > > > > Hi Scott, > > > > > > > > > > > -----Original Message----- > > > > > > From: Wood Scott-B07421 > > > > > > Sent: Wednesday, September 16, 2015 7:57 AM > > > > > > To: Wang Dongsheng-B40534 > > > > > > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > > > > > > robh+dt@kernel.org; linux-arm-kernel@lists.infradead.org; Wang > > > > > > robh+Huan- > > > > > > B18965; Jin > > > > > > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983 > > > > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > > > > > > > On Tue, 2015-09-15 at 16:55 +0800, Dongsheng Wang wrote: > > > > > > > +* Freescale RCPM Wakeup Source Device Tree Bindings > > > > > > > +------------------------------------------- > > > > > > > +Required rcpm-wakeup property should be added to a device > > > > > > > +node if the > > > > > > > device > > > > > > > +can be used as a wakeup source. > > > > > > > + > > > > > > > + - rcpm-wakeup: The value of the property consists of 3 cells. > > > > > > > + The > > > > > > > first > > > > > > > cell > > > > > > > + is a pointer to the rcpm node, the second cell is the > > > > > > > + bit mask > > > > > > > that > > > > > > > + should be set in IPPDEXPCR0, and the last cell is for > > > > > > > IPPDEXPCR1. > > > > > > > + Note: If the platform has no IPPDEXPCR1 register, put a > > > > > > > + zero > > > > > > > here. > > > > > > > > > > > > What if a future platform has more than two of these registers? > > > > > > > > > > Those registers are only used for wakeup device, we have a lot of > > > > > available bit for feature. For example, In LS1021a platform only > > > > > 7bits has used in the registers, and 57bits is reserved. > > > > > > > > Still, it'd be better to for the rcpm node to advertise the number > > > > of cells it expects. > > > > > > For the foreseeable future it should be enough to use, even if not > > > enough to use in the future at that time we can update the binding. > > > > That's the whole point. Device tree is stable ABI. Updating it later to > > not be > > fixed to two cells would be a lot harder than getting it right from the > > beginning. Putting the number of cells in the phandle target is a > > standard > > device tree idiom. > > > I agree with you. But what's the point a SOC has more than 64 wakeup source? I don't know. Hardware people do strange things sometimes. They might not want to reuse bits they once used for something on some other chip, or they might have some encoding scheme in mind that results in the bits not being packed as tightly as possible, or there may be some big array of similar devices... What's the point of skipping this part of the phandle-plus-arguments idiom? -Scott ^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [PATCH v2 1/2] fsl: Add binding for RCPM @ 2015-09-16 2:37 ` Scott Wood 0 siblings, 0 replies; 39+ messages in thread From: Scott Wood @ 2015-09-16 2:37 UTC (permalink / raw) To: Tang Yuantian-B29983 Cc: Wang Dongsheng-B40534, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Wang Huan-B18965, Jin Zhengxiong-R64188, Zhao Chenhui-B35336 On Tue, 2015-09-15 at 21:35 -0500, Tang Yuantian-B29983 wrote: > > > -----Original Message----- > > From: Wood Scott-B07421 > > Sent: Wednesday, September 16, 2015 10:32 AM > > To: Wang Dongsheng-B40534 <Dongsheng.Wang-KZfg59tc24xl57MIdRCFDg@public.gmane.org> > > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org; > > robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org; linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org; Wang Huan- > > B18965 <alison.wang-KZfg59tc24xl57MIdRCFDg@public.gmane.org>; Jin Zhengxiong-R64188 > > <Jason.Jin-KZfg59tc24xl57MIdRCFDg@public.gmane.org>; Zhao Chenhui-B35336 > > <chenhui.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org>; Tang Yuantian-B29983 > > <Yuantian.Tang-KZfg59tc24xl57MIdRCFDg@public.gmane.org> > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > On Tue, 2015-09-15 at 21:30 -0500, Wang Dongsheng-B40534 wrote: > > > Hi Scott, > > > > > > > -----Original Message----- > > > > From: Wood Scott-B07421 > > > > Sent: Wednesday, September 16, 2015 10:19 AM > > > > To: Wang Dongsheng-B40534 > > > > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org; > > > > robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org; linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org; Wang Huan- > > > > B18965; Jin > > > > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983 > > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > > > On Tue, 2015-09-15 at 21:15 -0500, Wang Dongsheng-B40534 wrote: > > > > > Hi Scott, > > > > > > > > > > > -----Original Message----- > > > > > > From: Wood Scott-B07421 > > > > > > Sent: Wednesday, September 16, 2015 7:57 AM > > > > > > To: Wang Dongsheng-B40534 > > > > > > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org; > > > > > > robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org; linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org; Wang > > > > > > robh+Huan- > > > > > > B18965; Jin > > > > > > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983 > > > > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > > > > > > > On Tue, 2015-09-15 at 16:55 +0800, Dongsheng Wang wrote: > > > > > > > +* Freescale RCPM Wakeup Source Device Tree Bindings > > > > > > > +------------------------------------------- > > > > > > > +Required rcpm-wakeup property should be added to a device > > > > > > > +node if the > > > > > > > device > > > > > > > +can be used as a wakeup source. > > > > > > > + > > > > > > > + - rcpm-wakeup: The value of the property consists of 3 cells. > > > > > > > + The > > > > > > > first > > > > > > > cell > > > > > > > + is a pointer to the rcpm node, the second cell is the > > > > > > > + bit mask > > > > > > > that > > > > > > > + should be set in IPPDEXPCR0, and the last cell is for > > > > > > > IPPDEXPCR1. > > > > > > > + Note: If the platform has no IPPDEXPCR1 register, put a > > > > > > > + zero > > > > > > > here. > > > > > > > > > > > > What if a future platform has more than two of these registers? > > > > > > > > > > Those registers are only used for wakeup device, we have a lot of > > > > > available bit for feature. For example, In LS1021a platform only > > > > > 7bits has used in the registers, and 57bits is reserved. > > > > > > > > Still, it'd be better to for the rcpm node to advertise the number > > > > of cells it expects. > > > > > > For the foreseeable future it should be enough to use, even if not > > > enough to use in the future at that time we can update the binding. > > > > That's the whole point. Device tree is stable ABI. Updating it later to > > not be > > fixed to two cells would be a lot harder than getting it right from the > > beginning. Putting the number of cells in the phandle target is a > > standard > > device tree idiom. > > > I agree with you. But what's the point a SOC has more than 64 wakeup source? I don't know. Hardware people do strange things sometimes. They might not want to reuse bits they once used for something on some other chip, or they might have some encoding scheme in mind that results in the bits not being packed as tightly as possible, or there may be some big array of similar devices... What's the point of skipping this part of the phandle-plus-arguments idiom? -Scott -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 39+ messages in thread
* [PATCH v2 1/2] fsl: Add binding for RCPM @ 2015-09-16 2:37 ` Scott Wood 0 siblings, 0 replies; 39+ messages in thread From: Scott Wood @ 2015-09-16 2:37 UTC (permalink / raw) To: linux-arm-kernel On Tue, 2015-09-15 at 21:35 -0500, Tang Yuantian-B29983 wrote: > > > -----Original Message----- > > From: Wood Scott-B07421 > > Sent: Wednesday, September 16, 2015 10:32 AM > > To: Wang Dongsheng-B40534 <Dongsheng.Wang@freescale.com> > > Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; > > robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang Huan- > > B18965 <alison.wang@freescale.com>; Jin Zhengxiong-R64188 > > <Jason.Jin@freescale.com>; Zhao Chenhui-B35336 > > <chenhui.zhao@freescale.com>; Tang Yuantian-B29983 > > <Yuantian.Tang@freescale.com> > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > On Tue, 2015-09-15 at 21:30 -0500, Wang Dongsheng-B40534 wrote: > > > Hi Scott, > > > > > > > -----Original Message----- > > > > From: Wood Scott-B07421 > > > > Sent: Wednesday, September 16, 2015 10:19 AM > > > > To: Wang Dongsheng-B40534 > > > > Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; > > > > robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang Huan- > > > > B18965; Jin > > > > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983 > > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > > > On Tue, 2015-09-15 at 21:15 -0500, Wang Dongsheng-B40534 wrote: > > > > > Hi Scott, > > > > > > > > > > > -----Original Message----- > > > > > > From: Wood Scott-B07421 > > > > > > Sent: Wednesday, September 16, 2015 7:57 AM > > > > > > To: Wang Dongsheng-B40534 > > > > > > Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; > > > > > > robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang > > > > > > robh+Huan- > > > > > > B18965; Jin > > > > > > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983 > > > > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > > > > > > > On Tue, 2015-09-15 at 16:55 +0800, Dongsheng Wang wrote: > > > > > > > +* Freescale RCPM Wakeup Source Device Tree Bindings > > > > > > > +------------------------------------------- > > > > > > > +Required rcpm-wakeup property should be added to a device > > > > > > > +node if the > > > > > > > device > > > > > > > +can be used as a wakeup source. > > > > > > > + > > > > > > > + - rcpm-wakeup: The value of the property consists of 3 cells. > > > > > > > + The > > > > > > > first > > > > > > > cell > > > > > > > + is a pointer to the rcpm node, the second cell is the > > > > > > > + bit mask > > > > > > > that > > > > > > > + should be set in IPPDEXPCR0, and the last cell is for > > > > > > > IPPDEXPCR1. > > > > > > > + Note: If the platform has no IPPDEXPCR1 register, put a > > > > > > > + zero > > > > > > > here. > > > > > > > > > > > > What if a future platform has more than two of these registers? > > > > > > > > > > Those registers are only used for wakeup device, we have a lot of > > > > > available bit for feature. For example, In LS1021a platform only > > > > > 7bits has used in the registers, and 57bits is reserved. > > > > > > > > Still, it'd be better to for the rcpm node to advertise the number > > > > of cells it expects. > > > > > > For the foreseeable future it should be enough to use, even if not > > > enough to use in the future at that time we can update the binding. > > > > That's the whole point. Device tree is stable ABI. Updating it later to > > not be > > fixed to two cells would be a lot harder than getting it right from the > > beginning. Putting the number of cells in the phandle target is a > > standard > > device tree idiom. > > > I agree with you. But what's the point a SOC has more than 64 wakeup source? I don't know. Hardware people do strange things sometimes. They might not want to reuse bits they once used for something on some other chip, or they might have some encoding scheme in mind that results in the bits not being packed as tightly as possible, or there may be some big array of similar devices... What's the point of skipping this part of the phandle-plus-arguments idiom? -Scott ^ permalink raw reply [flat|nested] 39+ messages in thread
* RE: [PATCH v2 1/2] fsl: Add binding for RCPM 2015-09-16 2:37 ` Scott Wood (?) @ 2015-09-16 2:43 ` Wang Dongsheng -1 siblings, 0 replies; 39+ messages in thread From: Wang Dongsheng @ 2015-09-16 2:43 UTC (permalink / raw) To: Scott Wood, Yuantian Tang Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, Huan Wang, Jin Jason, Zhao C.H. DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogV29vZCBTY290dC1CMDc0 MjENCj4gU2VudDogV2VkbmVzZGF5LCBTZXB0ZW1iZXIgMTYsIDIwMTUgMTA6MzggQU0NCj4gVG86 IFRhbmcgWXVhbnRpYW4tQjI5OTgzDQo+IENjOiBXYW5nIERvbmdzaGVuZy1CNDA1MzQ7IGRldmlj ZXRyZWVAdmdlci5rZXJuZWwub3JnOyBsaW51eHBwYy0NCj4gZGV2QGxpc3RzLm96bGFicy5vcmc7 IHJvYmgrZHRAa2VybmVsLm9yZzsgbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3Jn Ow0KPiBXYW5nIEh1YW4tQjE4OTY1OyBKaW4gWmhlbmd4aW9uZy1SNjQxODg7IFpoYW8gQ2hlbmh1 aS1CMzUzMzYNCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2MiAxLzJdIGZzbDogQWRkIGJpbmRpbmcg Zm9yIFJDUE0NCj4gDQo+IE9uIFR1ZSwgMjAxNS0wOS0xNSBhdCAyMTozNSAtMDUwMCwgVGFuZyBZ dWFudGlhbi1CMjk5ODMgd3JvdGU6DQo+ID4NCj4gPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0t LS0tDQo+ID4gPiBGcm9tOiBXb29kIFNjb3R0LUIwNzQyMQ0KPiA+ID4gU2VudDogV2VkbmVzZGF5 LCBTZXB0ZW1iZXIgMTYsIDIwMTUgMTA6MzIgQU0NCj4gPiA+IFRvOiBXYW5nIERvbmdzaGVuZy1C NDA1MzQgPERvbmdzaGVuZy5XYW5nQGZyZWVzY2FsZS5jb20+DQo+ID4gPiBDYzogZGV2aWNldHJl ZUB2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4cHBjLWRldkBsaXN0cy5vemxhYnMub3JnOw0KPiA+ID4g cm9iaCtkdEBrZXJuZWwub3JnOyBsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmc7 IFdhbmcgSHVhbi0NCj4gPiA+IEIxODk2NSA8YWxpc29uLndhbmdAZnJlZXNjYWxlLmNvbT47IEpp biBaaGVuZ3hpb25nLVI2NDE4OA0KPiA+ID4gPEphc29uLkppbkBmcmVlc2NhbGUuY29tPjsgWmhh byBDaGVuaHVpLUIzNTMzNg0KPiA+ID4gPGNoZW5odWkuemhhb0BmcmVlc2NhbGUuY29tPjsgVGFu ZyBZdWFudGlhbi1CMjk5ODMNCj4gPiA+IDxZdWFudGlhbi5UYW5nQGZyZWVzY2FsZS5jb20+DQo+ ID4gPiBTdWJqZWN0OiBSZTogW1BBVENIIHYyIDEvMl0gZnNsOiBBZGQgYmluZGluZyBmb3IgUkNQ TQ0KPiA+ID4NCj4gPiA+IE9uIFR1ZSwgMjAxNS0wOS0xNSBhdCAyMTozMCAtMDUwMCwgV2FuZyBE b25nc2hlbmctQjQwNTM0IHdyb3RlOg0KPiA+ID4gPiBIaSBTY290dCwNCj4gPiA+ID4NCj4gPiA+ ID4gPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+ID4gPiA+IEZyb206IFdvb2QgU2Nv dHQtQjA3NDIxDQo+ID4gPiA+ID4gU2VudDogV2VkbmVzZGF5LCBTZXB0ZW1iZXIgMTYsIDIwMTUg MTA6MTkgQU0NCj4gPiA+ID4gPiBUbzogV2FuZyBEb25nc2hlbmctQjQwNTM0DQo+ID4gPiA+ID4g Q2M6IGRldmljZXRyZWVAdmdlci5rZXJuZWwub3JnOyBsaW51eHBwYy1kZXZAbGlzdHMub3psYWJz Lm9yZzsNCj4gPiA+ID4gPiByb2JoK2R0QGtlcm5lbC5vcmc7IGxpbnV4LWFybS1rZXJuZWxAbGlz dHMuaW5mcmFkZWFkLm9yZzsgV2FuZyBIdWFuLQ0KPiA+ID4gPiA+IEIxODk2NTsgSmluDQo+ID4g PiA+ID4gWmhlbmd4aW9uZy1SNjQxODg7IFpoYW8gQ2hlbmh1aS1CMzUzMzY7IFRhbmcgWXVhbnRp YW4tQjI5OTgzDQo+ID4gPiA+ID4gU3ViamVjdDogUmU6IFtQQVRDSCB2MiAxLzJdIGZzbDogQWRk IGJpbmRpbmcgZm9yIFJDUE0NCj4gPiA+ID4gPg0KPiA+ID4gPiA+IE9uIFR1ZSwgMjAxNS0wOS0x NSBhdCAyMToxNSAtMDUwMCwgV2FuZyBEb25nc2hlbmctQjQwNTM0IHdyb3RlOg0KPiA+ID4gPiA+ ID4gSGkgU2NvdHQsDQo+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiAtLS0tLU9yaWdpbmFsIE1l c3NhZ2UtLS0tLQ0KPiA+ID4gPiA+ID4gPiBGcm9tOiBXb29kIFNjb3R0LUIwNzQyMQ0KPiA+ID4g PiA+ID4gPiBTZW50OiBXZWRuZXNkYXksIFNlcHRlbWJlciAxNiwgMjAxNSA3OjU3IEFNDQo+ID4g PiA+ID4gPiA+IFRvOiBXYW5nIERvbmdzaGVuZy1CNDA1MzQNCj4gPiA+ID4gPiA+ID4gQ2M6IGRl dmljZXRyZWVAdmdlci5rZXJuZWwub3JnOyBsaW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9yZzsN Cj4gPiA+ID4gPiA+ID4gcm9iaCtkdEBrZXJuZWwub3JnOyBsaW51eC1hcm0ta2VybmVsQGxpc3Rz LmluZnJhZGVhZC5vcmc7IFdhbmcNCj4gPiA+ID4gPiA+ID4gcm9iaCtIdWFuLQ0KPiA+ID4gPiA+ ID4gPiBCMTg5NjU7IEppbg0KPiA+ID4gPiA+ID4gPiBaaGVuZ3hpb25nLVI2NDE4ODsgWmhhbyBD aGVuaHVpLUIzNTMzNjsgVGFuZyBZdWFudGlhbi1CMjk5ODMNCj4gPiA+ID4gPiA+ID4gU3ViamVj dDogUmU6IFtQQVRDSCB2MiAxLzJdIGZzbDogQWRkIGJpbmRpbmcgZm9yIFJDUE0NCj4gPiA+ID4g PiA+ID4NCj4gPiA+ID4gPiA+ID4gT24gVHVlLCAyMDE1LTA5LTE1IGF0IDE2OjU1ICswODAwLCBE b25nc2hlbmcgV2FuZyB3cm90ZToNCj4gPiA+ID4gPiA+ID4gPiArKiBGcmVlc2NhbGUgUkNQTSBX YWtldXAgU291cmNlIERldmljZSBUcmVlIEJpbmRpbmdzDQo+ID4gPiA+ID4gPiA+ID4gKy0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0NCj4gPiA+ID4gPiA+ID4gPiAr UmVxdWlyZWQgcmNwbS13YWtldXAgcHJvcGVydHkgc2hvdWxkIGJlIGFkZGVkIHRvIGEgZGV2aWNl DQo+ID4gPiA+ID4gPiA+ID4gK25vZGUgaWYgdGhlDQo+ID4gPiA+ID4gPiA+ID4gZGV2aWNlDQo+ ID4gPiA+ID4gPiA+ID4gK2NhbiBiZSB1c2VkIGFzIGEgd2FrZXVwIHNvdXJjZS4NCj4gPiA+ID4g PiA+ID4gPiArDQo+ID4gPiA+ID4gPiA+ID4gKyAgLSByY3BtLXdha2V1cDogVGhlIHZhbHVlIG9m IHRoZSBwcm9wZXJ0eSBjb25zaXN0cyBvZiAzIGNlbGxzLg0KPiA+ID4gPiA+ID4gPiA+ICsgVGhl DQo+ID4gPiA+ID4gPiA+ID4gZmlyc3QNCj4gPiA+ID4gPiA+ID4gPiBjZWxsDQo+ID4gPiA+ID4g PiA+ID4gKyAgICAgaXMgYSBwb2ludGVyIHRvIHRoZSByY3BtIG5vZGUsIHRoZSBzZWNvbmQgY2Vs bCBpcyB0aGUNCj4gPiA+ID4gPiA+ID4gPiArIGJpdCBtYXNrDQo+ID4gPiA+ID4gPiA+ID4gdGhh dA0KPiA+ID4gPiA+ID4gPiA+ICsgICAgIHNob3VsZCBiZSBzZXQgaW4gSVBQREVYUENSMCwgYW5k IHRoZSBsYXN0IGNlbGwgaXMgZm9yDQo+ID4gPiA+ID4gPiA+ID4gSVBQREVYUENSMS4NCj4gPiA+ ID4gPiA+ID4gPiArICAgICBOb3RlOiBJZiB0aGUgcGxhdGZvcm0gaGFzIG5vIElQUERFWFBDUjEg cmVnaXN0ZXIsIHB1dCBhDQo+ID4gPiA+ID4gPiA+ID4gKyB6ZXJvDQo+ID4gPiA+ID4gPiA+ID4g aGVyZS4NCj4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gV2hhdCBpZiBhIGZ1dHVyZSBwbGF0 Zm9ybSBoYXMgbW9yZSB0aGFuIHR3byBvZiB0aGVzZSByZWdpc3RlcnM/DQo+ID4gPiA+ID4gPg0K PiA+ID4gPiA+ID4gVGhvc2UgcmVnaXN0ZXJzIGFyZSBvbmx5IHVzZWQgZm9yIHdha2V1cCBkZXZp Y2UsIHdlIGhhdmUgYSBsb3Qgb2YNCj4gPiA+ID4gPiA+IGF2YWlsYWJsZSBiaXQgZm9yIGZlYXR1 cmUuIEZvciBleGFtcGxlLCBJbiBMUzEwMjFhIHBsYXRmb3JtIG9ubHkNCj4gPiA+ID4gPiA+IDdi aXRzIGhhcyB1c2VkIGluIHRoZSByZWdpc3RlcnMsIGFuZCA1N2JpdHMgaXMgcmVzZXJ2ZWQuDQo+ ID4gPiA+ID4NCj4gPiA+ID4gPiBTdGlsbCwgaXQnZCBiZSBiZXR0ZXIgdG8gZm9yIHRoZSByY3Bt IG5vZGUgdG8gYWR2ZXJ0aXNlIHRoZSBudW1iZXINCj4gPiA+ID4gPiBvZiBjZWxscyBpdCBleHBl Y3RzLg0KPiA+ID4gPg0KPiA+ID4gPiBGb3IgdGhlIGZvcmVzZWVhYmxlIGZ1dHVyZSBpdCBzaG91 bGQgYmUgZW5vdWdoIHRvIHVzZSwgZXZlbiBpZiBub3QNCj4gPiA+ID4gZW5vdWdoIHRvIHVzZSBp biB0aGUgZnV0dXJlIGF0IHRoYXQgdGltZSB3ZSBjYW4gdXBkYXRlIHRoZSBiaW5kaW5nLg0KPiA+ ID4NCj4gPiA+IFRoYXQncyB0aGUgd2hvbGUgcG9pbnQuICBEZXZpY2UgdHJlZSBpcyBzdGFibGUg QUJJLiAgVXBkYXRpbmcgaXQgbGF0ZXIgdG8NCj4gPiA+IG5vdCBiZQ0KPiA+ID4gZml4ZWQgdG8g dHdvIGNlbGxzIHdvdWxkIGJlIGEgbG90IGhhcmRlciB0aGFuIGdldHRpbmcgaXQgcmlnaHQgZnJv bSB0aGUNCj4gPiA+IGJlZ2lubmluZy4gIFB1dHRpbmcgdGhlIG51bWJlciBvZiBjZWxscyBpbiB0 aGUgcGhhbmRsZSB0YXJnZXQgaXMgYQ0KPiA+ID4gc3RhbmRhcmQNCj4gPiA+IGRldmljZSB0cmVl IGlkaW9tLg0KPiA+ID4NCj4gPiBJIGFncmVlIHdpdGggeW91LiBCdXQgd2hhdCdzIHRoZSBwb2lu dCBhIFNPQyBoYXMgbW9yZSB0aGFuIDY0IHdha2V1cCBzb3VyY2U/DQo+IA0KPiBJIGRvbid0IGtu b3cuICBIYXJkd2FyZSBwZW9wbGUgZG8gc3RyYW5nZSB0aGluZ3Mgc29tZXRpbWVzLiAgVGhleSBt aWdodCBub3QNCj4gd2FudCB0byByZXVzZSBiaXRzIHRoZXkgb25jZSB1c2VkIGZvciBzb21ldGhp bmcgb24gc29tZSBvdGhlciBjaGlwLCBvciB0aGV5DQo+IG1pZ2h0IGhhdmUgc29tZSBlbmNvZGlu ZyBzY2hlbWUgaW4gbWluZCB0aGF0IHJlc3VsdHMgaW4gdGhlIGJpdHMgbm90IGJlaW5nDQo+IHBh Y2tlZCBhcyB0aWdodGx5IGFzIHBvc3NpYmxlLCBvciB0aGVyZSBtYXkgYmUgc29tZSBiaWcgYXJy YXkgb2Ygc2ltaWxhcg0KPiBkZXZpY2VzLi4uDQo+IA0KPiBXaGF0J3MgdGhlIHBvaW50IG9mIHNr aXBwaW5nIHRoaXMgcGFydCBvZiB0aGUgcGhhbmRsZS1wbHVzLWFyZ3VtZW50cyBpZGlvbT8NCg0K RmluZSwgSSB3aWxsIGFkZCBhIHByb3BlcnR5IGluIHJjcG0gbm9kZSB0byBkZXNjcmliZSB0aGUg bnVtYmVyIG9mIHJlZ2lzdGVyLg0KDQpSZWdhcmRzLA0KLURvbmdzaGVuZw0K ^ permalink raw reply [flat|nested] 39+ messages in thread
* RE: [PATCH v2 1/2] fsl: Add binding for RCPM @ 2015-09-16 2:43 ` Wang Dongsheng 0 siblings, 0 replies; 39+ messages in thread From: Wang Dongsheng @ 2015-09-16 2:43 UTC (permalink / raw) To: Scott Wood, Yuantian Tang Cc: devicetree@vger.kernel.org, Zhao C.H., Huan Wang, robh+dt@kernel.org, Jin Jason, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org > -----Original Message----- > From: Wood Scott-B07421 > Sent: Wednesday, September 16, 2015 10:38 AM > To: Tang Yuantian-B29983 > Cc: Wang Dongsheng-B40534; devicetree@vger.kernel.org; linuxppc- > dev@lists.ozlabs.org; robh+dt@kernel.org; linux-arm-kernel@lists.infradead.org; > Wang Huan-B18965; Jin Zhengxiong-R64188; Zhao Chenhui-B35336 > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > On Tue, 2015-09-15 at 21:35 -0500, Tang Yuantian-B29983 wrote: > > > > > -----Original Message----- > > > From: Wood Scott-B07421 > > > Sent: Wednesday, September 16, 2015 10:32 AM > > > To: Wang Dongsheng-B40534 <Dongsheng.Wang@freescale.com> > > > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > > > robh+dt@kernel.org; linux-arm-kernel@lists.infradead.org; Wang Huan- > > > B18965 <alison.wang@freescale.com>; Jin Zhengxiong-R64188 > > > <Jason.Jin@freescale.com>; Zhao Chenhui-B35336 > > > <chenhui.zhao@freescale.com>; Tang Yuantian-B29983 > > > <Yuantian.Tang@freescale.com> > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > On Tue, 2015-09-15 at 21:30 -0500, Wang Dongsheng-B40534 wrote: > > > > Hi Scott, > > > > > > > > > -----Original Message----- > > > > > From: Wood Scott-B07421 > > > > > Sent: Wednesday, September 16, 2015 10:19 AM > > > > > To: Wang Dongsheng-B40534 > > > > > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > > > > > robh+dt@kernel.org; linux-arm-kernel@lists.infradead.org; Wang Huan- > > > > > B18965; Jin > > > > > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983 > > > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > > > > > On Tue, 2015-09-15 at 21:15 -0500, Wang Dongsheng-B40534 wrote: > > > > > > Hi Scott, > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Wood Scott-B07421 > > > > > > > Sent: Wednesday, September 16, 2015 7:57 AM > > > > > > > To: Wang Dongsheng-B40534 > > > > > > > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > > > > > > > robh+dt@kernel.org; linux-arm-kernel@lists.infradead.org; Wang > > > > > > > robh+Huan- > > > > > > > B18965; Jin > > > > > > > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983 > > > > > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > > > > > > > > > On Tue, 2015-09-15 at 16:55 +0800, Dongsheng Wang wrote: > > > > > > > > +* Freescale RCPM Wakeup Source Device Tree Bindings > > > > > > > > +------------------------------------------- > > > > > > > > +Required rcpm-wakeup property should be added to a device > > > > > > > > +node if the > > > > > > > > device > > > > > > > > +can be used as a wakeup source. > > > > > > > > + > > > > > > > > + - rcpm-wakeup: The value of the property consists of 3 cells. > > > > > > > > + The > > > > > > > > first > > > > > > > > cell > > > > > > > > + is a pointer to the rcpm node, the second cell is the > > > > > > > > + bit mask > > > > > > > > that > > > > > > > > + should be set in IPPDEXPCR0, and the last cell is for > > > > > > > > IPPDEXPCR1. > > > > > > > > + Note: If the platform has no IPPDEXPCR1 register, put a > > > > > > > > + zero > > > > > > > > here. > > > > > > > > > > > > > > What if a future platform has more than two of these registers? > > > > > > > > > > > > Those registers are only used for wakeup device, we have a lot of > > > > > > available bit for feature. For example, In LS1021a platform only > > > > > > 7bits has used in the registers, and 57bits is reserved. > > > > > > > > > > Still, it'd be better to for the rcpm node to advertise the number > > > > > of cells it expects. > > > > > > > > For the foreseeable future it should be enough to use, even if not > > > > enough to use in the future at that time we can update the binding. > > > > > > That's the whole point. Device tree is stable ABI. Updating it later to > > > not be > > > fixed to two cells would be a lot harder than getting it right from the > > > beginning. Putting the number of cells in the phandle target is a > > > standard > > > device tree idiom. > > > > > I agree with you. But what's the point a SOC has more than 64 wakeup source? > > I don't know. Hardware people do strange things sometimes. They might not > want to reuse bits they once used for something on some other chip, or they > might have some encoding scheme in mind that results in the bits not being > packed as tightly as possible, or there may be some big array of similar > devices... > > What's the point of skipping this part of the phandle-plus-arguments idiom? Fine, I will add a property in rcpm node to describe the number of register. Regards, -Dongsheng _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev ^ permalink raw reply [flat|nested] 39+ messages in thread
* [PATCH v2 1/2] fsl: Add binding for RCPM @ 2015-09-16 2:43 ` Wang Dongsheng 0 siblings, 0 replies; 39+ messages in thread From: Wang Dongsheng @ 2015-09-16 2:43 UTC (permalink / raw) To: linux-arm-kernel > -----Original Message----- > From: Wood Scott-B07421 > Sent: Wednesday, September 16, 2015 10:38 AM > To: Tang Yuantian-B29983 > Cc: Wang Dongsheng-B40534; devicetree at vger.kernel.org; linuxppc- > dev at lists.ozlabs.org; robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; > Wang Huan-B18965; Jin Zhengxiong-R64188; Zhao Chenhui-B35336 > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > On Tue, 2015-09-15 at 21:35 -0500, Tang Yuantian-B29983 wrote: > > > > > -----Original Message----- > > > From: Wood Scott-B07421 > > > Sent: Wednesday, September 16, 2015 10:32 AM > > > To: Wang Dongsheng-B40534 <Dongsheng.Wang@freescale.com> > > > Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; > > > robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang Huan- > > > B18965 <alison.wang@freescale.com>; Jin Zhengxiong-R64188 > > > <Jason.Jin@freescale.com>; Zhao Chenhui-B35336 > > > <chenhui.zhao@freescale.com>; Tang Yuantian-B29983 > > > <Yuantian.Tang@freescale.com> > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > On Tue, 2015-09-15 at 21:30 -0500, Wang Dongsheng-B40534 wrote: > > > > Hi Scott, > > > > > > > > > -----Original Message----- > > > > > From: Wood Scott-B07421 > > > > > Sent: Wednesday, September 16, 2015 10:19 AM > > > > > To: Wang Dongsheng-B40534 > > > > > Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; > > > > > robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang Huan- > > > > > B18965; Jin > > > > > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983 > > > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > > > > > On Tue, 2015-09-15 at 21:15 -0500, Wang Dongsheng-B40534 wrote: > > > > > > Hi Scott, > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Wood Scott-B07421 > > > > > > > Sent: Wednesday, September 16, 2015 7:57 AM > > > > > > > To: Wang Dongsheng-B40534 > > > > > > > Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; > > > > > > > robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang > > > > > > > robh+Huan- > > > > > > > B18965; Jin > > > > > > > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983 > > > > > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > > > > > > > > > On Tue, 2015-09-15 at 16:55 +0800, Dongsheng Wang wrote: > > > > > > > > +* Freescale RCPM Wakeup Source Device Tree Bindings > > > > > > > > +------------------------------------------- > > > > > > > > +Required rcpm-wakeup property should be added to a device > > > > > > > > +node if the > > > > > > > > device > > > > > > > > +can be used as a wakeup source. > > > > > > > > + > > > > > > > > + - rcpm-wakeup: The value of the property consists of 3 cells. > > > > > > > > + The > > > > > > > > first > > > > > > > > cell > > > > > > > > + is a pointer to the rcpm node, the second cell is the > > > > > > > > + bit mask > > > > > > > > that > > > > > > > > + should be set in IPPDEXPCR0, and the last cell is for > > > > > > > > IPPDEXPCR1. > > > > > > > > + Note: If the platform has no IPPDEXPCR1 register, put a > > > > > > > > + zero > > > > > > > > here. > > > > > > > > > > > > > > What if a future platform has more than two of these registers? > > > > > > > > > > > > Those registers are only used for wakeup device, we have a lot of > > > > > > available bit for feature. For example, In LS1021a platform only > > > > > > 7bits has used in the registers, and 57bits is reserved. > > > > > > > > > > Still, it'd be better to for the rcpm node to advertise the number > > > > > of cells it expects. > > > > > > > > For the foreseeable future it should be enough to use, even if not > > > > enough to use in the future at that time we can update the binding. > > > > > > That's the whole point. Device tree is stable ABI. Updating it later to > > > not be > > > fixed to two cells would be a lot harder than getting it right from the > > > beginning. Putting the number of cells in the phandle target is a > > > standard > > > device tree idiom. > > > > > I agree with you. But what's the point a SOC has more than 64 wakeup source? > > I don't know. Hardware people do strange things sometimes. They might not > want to reuse bits they once used for something on some other chip, or they > might have some encoding scheme in mind that results in the bits not being > packed as tightly as possible, or there may be some big array of similar > devices... > > What's the point of skipping this part of the phandle-plus-arguments idiom? Fine, I will add a property in rcpm node to describe the number of register. Regards, -Dongsheng ^ permalink raw reply [flat|nested] 39+ messages in thread
* RE: [PATCH v2 1/2] fsl: Add binding for RCPM 2015-09-16 2:37 ` Scott Wood (?) @ 2015-09-16 3:18 ` Wang Dongsheng -1 siblings, 0 replies; 39+ messages in thread From: Wang Dongsheng @ 2015-09-16 3:18 UTC (permalink / raw) To: Scott Wood, Yuantian Tang Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, Huan Wang, Jin Jason, Zhao C.H., Wang Dongsheng SGkgU2NvdHQsDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogV2FuZyBE b25nc2hlbmctQjQwNTM0DQo+IFNlbnQ6IFdlZG5lc2RheSwgU2VwdGVtYmVyIDE2LCAyMDE1IDEw OjQ0IEFNDQo+IFRvOiBXb29kIFNjb3R0LUIwNzQyMTsgVGFuZyBZdWFudGlhbi1CMjk5ODMNCj4g Q2M6IGRldmljZXRyZWVAdmdlci5rZXJuZWwub3JnOyBsaW51eHBwYy1kZXZAbGlzdHMub3psYWJz Lm9yZzsNCj4gcm9iaCtkdEBrZXJuZWwub3JnOyBsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJh ZGVhZC5vcmc7IFdhbmcgSHVhbi1CMTg5NjU7IEppbg0KPiBaaGVuZ3hpb25nLVI2NDE4ODsgWmhh byBDaGVuaHVpLUIzNTMzNg0KPiBTdWJqZWN0OiBSRTogW1BBVENIIHYyIDEvMl0gZnNsOiBBZGQg YmluZGluZyBmb3IgUkNQTQ0KPiANCj4gDQo+IA0KPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0t LS0tDQo+ID4gRnJvbTogV29vZCBTY290dC1CMDc0MjENCj4gPiBTZW50OiBXZWRuZXNkYXksIFNl cHRlbWJlciAxNiwgMjAxNSAxMDozOCBBTQ0KPiA+IFRvOiBUYW5nIFl1YW50aWFuLUIyOTk4Mw0K PiA+IENjOiBXYW5nIERvbmdzaGVuZy1CNDA1MzQ7IGRldmljZXRyZWVAdmdlci5rZXJuZWwub3Jn OyBsaW51eHBwYy0NCj4gPiBkZXZAbGlzdHMub3psYWJzLm9yZzsgcm9iaCtkdEBrZXJuZWwub3Jn Ow0KPiA+IGxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZzsNCj4gPiBXYW5nIEh1 YW4tQjE4OTY1OyBKaW4gWmhlbmd4aW9uZy1SNjQxODg7IFpoYW8gQ2hlbmh1aS1CMzUzMzYNCj4g PiBTdWJqZWN0OiBSZTogW1BBVENIIHYyIDEvMl0gZnNsOiBBZGQgYmluZGluZyBmb3IgUkNQTQ0K PiA+DQo+ID4gT24gVHVlLCAyMDE1LTA5LTE1IGF0IDIxOjM1IC0wNTAwLCBUYW5nIFl1YW50aWFu LUIyOTk4MyB3cm90ZToNCj4gPiA+DQo+ID4gPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0t DQo+ID4gPiA+IEZyb206IFdvb2QgU2NvdHQtQjA3NDIxDQo+ID4gPiA+IFNlbnQ6IFdlZG5lc2Rh eSwgU2VwdGVtYmVyIDE2LCAyMDE1IDEwOjMyIEFNDQo+ID4gPiA+IFRvOiBXYW5nIERvbmdzaGVu Zy1CNDA1MzQgPERvbmdzaGVuZy5XYW5nQGZyZWVzY2FsZS5jb20+DQo+ID4gPiA+IENjOiBkZXZp Y2V0cmVlQHZnZXIua2VybmVsLm9yZzsgbGludXhwcGMtZGV2QGxpc3RzLm96bGFicy5vcmc7DQo+ ID4gPiA+IHJvYmgrZHRAa2VybmVsLm9yZzsgbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRl YWQub3JnOyBXYW5nDQo+ID4gPiA+IHJvYmgrSHVhbi0NCj4gPiA+ID4gQjE4OTY1IDxhbGlzb24u d2FuZ0BmcmVlc2NhbGUuY29tPjsgSmluIFpoZW5neGlvbmctUjY0MTg4DQo+ID4gPiA+IDxKYXNv bi5KaW5AZnJlZXNjYWxlLmNvbT47IFpoYW8gQ2hlbmh1aS1CMzUzMzYNCj4gPiA+ID4gPGNoZW5o dWkuemhhb0BmcmVlc2NhbGUuY29tPjsgVGFuZyBZdWFudGlhbi1CMjk5ODMNCj4gPiA+ID4gPFl1 YW50aWFuLlRhbmdAZnJlZXNjYWxlLmNvbT4NCj4gPiA+ID4gU3ViamVjdDogUmU6IFtQQVRDSCB2 MiAxLzJdIGZzbDogQWRkIGJpbmRpbmcgZm9yIFJDUE0NCj4gPiA+ID4NCj4gPiA+ID4gT24gVHVl LCAyMDE1LTA5LTE1IGF0IDIxOjMwIC0wNTAwLCBXYW5nIERvbmdzaGVuZy1CNDA1MzQgd3JvdGU6 DQo+ID4gPiA+ID4gSGkgU2NvdHQsDQo+ID4gPiA+ID4NCj4gPiA+ID4gPiA+IC0tLS0tT3JpZ2lu YWwgTWVzc2FnZS0tLS0tDQo+ID4gPiA+ID4gPiBGcm9tOiBXb29kIFNjb3R0LUIwNzQyMQ0KPiA+ ID4gPiA+ID4gU2VudDogV2VkbmVzZGF5LCBTZXB0ZW1iZXIgMTYsIDIwMTUgMTA6MTkgQU0NCj4g PiA+ID4gPiA+IFRvOiBXYW5nIERvbmdzaGVuZy1CNDA1MzQNCj4gPiA+ID4gPiA+IENjOiBkZXZp Y2V0cmVlQHZnZXIua2VybmVsLm9yZzsgbGludXhwcGMtZGV2QGxpc3RzLm96bGFicy5vcmc7DQo+ ID4gPiA+ID4gPiByb2JoK2R0QGtlcm5lbC5vcmc7IGxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5m cmFkZWFkLm9yZzsgV2FuZw0KPiA+ID4gPiA+ID4gcm9iaCtIdWFuLQ0KPiA+ID4gPiA+ID4gQjE4 OTY1OyBKaW4NCj4gPiA+ID4gPiA+IFpoZW5neGlvbmctUjY0MTg4OyBaaGFvIENoZW5odWktQjM1 MzM2OyBUYW5nIFl1YW50aWFuLUIyOTk4Mw0KPiA+ID4gPiA+ID4gU3ViamVjdDogUmU6IFtQQVRD SCB2MiAxLzJdIGZzbDogQWRkIGJpbmRpbmcgZm9yIFJDUE0NCj4gPiA+ID4gPiA+DQo+ID4gPiA+ ID4gPiBPbiBUdWUsIDIwMTUtMDktMTUgYXQgMjE6MTUgLTA1MDAsIFdhbmcgRG9uZ3NoZW5nLUI0 MDUzNCB3cm90ZToNCj4gPiA+ID4gPiA+ID4gSGkgU2NvdHQsDQo+ID4gPiA+ID4gPiA+DQo+ID4g PiA+ID4gPiA+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPiA+ID4gPiA+ID4gPiBG cm9tOiBXb29kIFNjb3R0LUIwNzQyMQ0KPiA+ID4gPiA+ID4gPiA+IFNlbnQ6IFdlZG5lc2RheSwg U2VwdGVtYmVyIDE2LCAyMDE1IDc6NTcgQU0NCj4gPiA+ID4gPiA+ID4gPiBUbzogV2FuZyBEb25n c2hlbmctQjQwNTM0DQo+ID4gPiA+ID4gPiA+ID4gQ2M6IGRldmljZXRyZWVAdmdlci5rZXJuZWwu b3JnOw0KPiA+ID4gPiA+ID4gPiA+IGxpbnV4cHBjLWRldkBsaXN0cy5vemxhYnMub3JnOw0KPiA+ ID4gPiA+ID4gPiA+IHJvYmgrZHRAa2VybmVsLm9yZzsgbGludXgtYXJtLWtlcm5lbEBsaXN0cy5p bmZyYWRlYWQub3JnOw0KPiA+ID4gPiA+ID4gPiA+IHJvYmgrV2FuZw0KPiA+ID4gPiA+ID4gPiA+ IHJvYmgrSHVhbi0NCj4gPiA+ID4gPiA+ID4gPiBCMTg5NjU7IEppbg0KPiA+ID4gPiA+ID4gPiA+ IFpoZW5neGlvbmctUjY0MTg4OyBaaGFvIENoZW5odWktQjM1MzM2OyBUYW5nDQo+ID4gPiA+ID4g PiA+ID4gWXVhbnRpYW4tQjI5OTgzDQo+ID4gPiA+ID4gPiA+ID4gU3ViamVjdDogUmU6IFtQQVRD SCB2MiAxLzJdIGZzbDogQWRkIGJpbmRpbmcgZm9yIFJDUE0NCj4gPiA+ID4gPiA+ID4gPg0KPiA+ ID4gPiA+ID4gPiA+IE9uIFR1ZSwgMjAxNS0wOS0xNSBhdCAxNjo1NSArMDgwMCwgRG9uZ3NoZW5n IFdhbmcgd3JvdGU6DQo+ID4gPiA+ID4gPiA+ID4gPiArKiBGcmVlc2NhbGUgUkNQTSBXYWtldXAg U291cmNlIERldmljZSBUcmVlIEJpbmRpbmdzDQo+ID4gPiA+ID4gPiA+ID4gPiArLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0KPiA+ID4gPiA+ID4gPiA+ID4gK1Jl cXVpcmVkIHJjcG0td2FrZXVwIHByb3BlcnR5IHNob3VsZCBiZSBhZGRlZCB0byBhDQo+ID4gPiA+ ID4gPiA+ID4gPiArZGV2aWNlIG5vZGUgaWYgdGhlDQo+ID4gPiA+ID4gPiA+ID4gPiBkZXZpY2UN Cj4gPiA+ID4gPiA+ID4gPiA+ICtjYW4gYmUgdXNlZCBhcyBhIHdha2V1cCBzb3VyY2UuDQo+ID4g PiA+ID4gPiA+ID4gPiArDQo+ID4gPiA+ID4gPiA+ID4gPiArICAtIHJjcG0td2FrZXVwOiBUaGUg dmFsdWUgb2YgdGhlIHByb3BlcnR5IGNvbnNpc3RzIG9mIDMgY2VsbHMuDQo+ID4gPiA+ID4gPiA+ ID4gPiArIFRoZQ0KPiA+ID4gPiA+ID4gPiA+ID4gZmlyc3QNCj4gPiA+ID4gPiA+ID4gPiA+IGNl bGwNCj4gPiA+ID4gPiA+ID4gPiA+ICsgICAgIGlzIGEgcG9pbnRlciB0byB0aGUgcmNwbSBub2Rl LCB0aGUgc2Vjb25kIGNlbGwgaXMNCj4gPiA+ID4gPiA+ID4gPiA+ICsgdGhlIGJpdCBtYXNrDQo+ ID4gPiA+ID4gPiA+ID4gPiB0aGF0DQo+ID4gPiA+ID4gPiA+ID4gPiArICAgICBzaG91bGQgYmUg c2V0IGluIElQUERFWFBDUjAsIGFuZCB0aGUgbGFzdCBjZWxsIGlzDQo+ID4gPiA+ID4gPiA+ID4g PiArIGZvcg0KPiA+ID4gPiA+ID4gPiA+ID4gSVBQREVYUENSMS4NCj4gPiA+ID4gPiA+ID4gPiA+ ICsgICAgIE5vdGU6IElmIHRoZSBwbGF0Zm9ybSBoYXMgbm8gSVBQREVYUENSMSByZWdpc3RlciwN Cj4gPiA+ID4gPiA+ID4gPiA+ICsgcHV0IGEgemVybw0KPiA+ID4gPiA+ID4gPiA+ID4gaGVyZS4N Cj4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+IFdoYXQgaWYgYSBmdXR1cmUgcGxhdGZv cm0gaGFzIG1vcmUgdGhhbiB0d28gb2YgdGhlc2UgcmVnaXN0ZXJzPw0KPiA+ID4gPiA+ID4gPg0K PiA+ID4gPiA+ID4gPiBUaG9zZSByZWdpc3RlcnMgYXJlIG9ubHkgdXNlZCBmb3Igd2FrZXVwIGRl dmljZSwgd2UgaGF2ZSBhDQo+ID4gPiA+ID4gPiA+IGxvdCBvZiBhdmFpbGFibGUgYml0IGZvciBm ZWF0dXJlLiBGb3IgZXhhbXBsZSwgSW4gTFMxMDIxYQ0KPiA+ID4gPiA+ID4gPiBwbGF0Zm9ybSBv bmx5IDdiaXRzIGhhcyB1c2VkIGluIHRoZSByZWdpc3RlcnMsIGFuZCA1N2JpdHMgaXMNCj4gcmVz ZXJ2ZWQuDQo+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gU3RpbGwsIGl0J2QgYmUgYmV0dGVyIHRv IGZvciB0aGUgcmNwbSBub2RlIHRvIGFkdmVydGlzZSB0aGUNCj4gPiA+ID4gPiA+IG51bWJlciBv ZiBjZWxscyBpdCBleHBlY3RzLg0KPiA+ID4gPiA+DQo+ID4gPiA+ID4gRm9yIHRoZSBmb3Jlc2Vl YWJsZSBmdXR1cmUgaXQgc2hvdWxkIGJlIGVub3VnaCB0byB1c2UsIGV2ZW4gaWYNCj4gPiA+ID4g PiBub3QgZW5vdWdoIHRvIHVzZSBpbiB0aGUgZnV0dXJlIGF0IHRoYXQgdGltZSB3ZSBjYW4gdXBk YXRlIHRoZSBiaW5kaW5nLg0KPiA+ID4gPg0KPiA+ID4gPiBUaGF0J3MgdGhlIHdob2xlIHBvaW50 LiAgRGV2aWNlIHRyZWUgaXMgc3RhYmxlIEFCSS4gIFVwZGF0aW5nIGl0DQo+ID4gPiA+IGxhdGVy IHRvIG5vdCBiZSBmaXhlZCB0byB0d28gY2VsbHMgd291bGQgYmUgYSBsb3QgaGFyZGVyIHRoYW4N Cj4gPiA+ID4gZ2V0dGluZyBpdCByaWdodCBmcm9tIHRoZSBiZWdpbm5pbmcuICBQdXR0aW5nIHRo ZSBudW1iZXIgb2YgY2VsbHMNCj4gPiA+ID4gaW4gdGhlIHBoYW5kbGUgdGFyZ2V0IGlzIGEgc3Rh bmRhcmQgZGV2aWNlIHRyZWUgaWRpb20uDQo+ID4gPiA+DQo+ID4gPiBJIGFncmVlIHdpdGggeW91 LiBCdXQgd2hhdCdzIHRoZSBwb2ludCBhIFNPQyBoYXMgbW9yZSB0aGFuIDY0IHdha2V1cCBzb3Vy Y2U/DQo+ID4NCj4gPiBJIGRvbid0IGtub3cuICBIYXJkd2FyZSBwZW9wbGUgZG8gc3RyYW5nZSB0 aGluZ3Mgc29tZXRpbWVzLiAgVGhleQ0KPiA+IG1pZ2h0IG5vdCB3YW50IHRvIHJldXNlIGJpdHMg dGhleSBvbmNlIHVzZWQgZm9yIHNvbWV0aGluZyBvbiBzb21lDQo+ID4gb3RoZXIgY2hpcCwgb3Ig dGhleSBtaWdodCBoYXZlIHNvbWUgZW5jb2Rpbmcgc2NoZW1lIGluIG1pbmQgdGhhdA0KPiA+IHJl c3VsdHMgaW4gdGhlIGJpdHMgbm90IGJlaW5nIHBhY2tlZCBhcyB0aWdodGx5IGFzIHBvc3NpYmxl LCBvciB0aGVyZQ0KPiA+IG1heSBiZSBzb21lIGJpZyBhcnJheSBvZiBzaW1pbGFyIGRldmljZXMu Li4NCj4gPg0KPiA+IFdoYXQncyB0aGUgcG9pbnQgb2Ygc2tpcHBpbmcgdGhpcyBwYXJ0IG9mIHRo ZSBwaGFuZGxlLXBsdXMtYXJndW1lbnRzIGlkaW9tPw0KPiANCj4gRmluZSwgSSB3aWxsIGFkZCBh IHByb3BlcnR5IGluIHJjcG0gbm9kZSB0byBkZXNjcmliZSB0aGUgbnVtYmVyIG9mIHJlZ2lzdGVy Lg0KPiANCg0KSG93IGFib3V0IHRoZSBmb2xsb3dpbmcgbW9kaWZ5PyBJZiBva2F5IGZvciB5b3Ug SSB3aWxsIGZpeCBpbiBuZXh0IHZlcnNpb24uDQoNClJlcXVpcmVkIHByb3Blcml0ZXM6DQogICAt IHJlZyA6IE9mZnNldCBhbmQgbGVuZ3RoIG9mIHRoZSByZWdpc3RlciBzZXQgb2YgUkNQTSBibG9j ay4NCisgIC0gZnNsLHJjcG0td2FrZXVwLWNlbGwtbnVtIDogVGhlIG51bWJlciBvZiBjZWxsIGlu IHJjcG0td2FrZXVwIHByb3BlcnR5Lg0KDQogICAgICAgIHJjcG06IGdsb2JhbC11dGlsaXRpZXNA ZTIwMDAgew0KICAgICAgICAgICAgICAgIGNvbXBhdGlibGUgPSAiZnNsLHQ0MjQwLXJjcG0iLCAi ZnNsLHFvcmlxLXJjcG0tMi4wIjsNCiAgICAgICAgICAgICAgICByZWcgPSA8MHhlMjAwMCAweDEw MDA+Ow0KKyAgICAgICAgICAgICAgIGZzbCxyY3BtLXdha2V1cC1jZWxsLW51bSA9IDwyPjsNCiAg ICAgICAgfTsNCg0KUmVnYXJkcywNCi1Eb25nc2hlbmcNCg== ^ permalink raw reply [flat|nested] 39+ messages in thread
* RE: [PATCH v2 1/2] fsl: Add binding for RCPM @ 2015-09-16 3:18 ` Wang Dongsheng 0 siblings, 0 replies; 39+ messages in thread From: Wang Dongsheng @ 2015-09-16 3:18 UTC (permalink / raw) To: Scott Wood, Yuantian Tang Cc: devicetree@vger.kernel.org, Zhao C.H., Huan Wang, Wang Dongsheng, robh+dt@kernel.org, Jin Jason, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Hi Scott, > -----Original Message----- > From: Wang Dongsheng-B40534 > Sent: Wednesday, September 16, 2015 10:44 AM > To: Wood Scott-B07421; Tang Yuantian-B29983 > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > robh+dt@kernel.org; linux-arm-kernel@lists.infradead.org; Wang Huan-B18965; Jin > Zhengxiong-R64188; Zhao Chenhui-B35336 > Subject: RE: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > -----Original Message----- > > From: Wood Scott-B07421 > > Sent: Wednesday, September 16, 2015 10:38 AM > > To: Tang Yuantian-B29983 > > Cc: Wang Dongsheng-B40534; devicetree@vger.kernel.org; linuxppc- > > dev@lists.ozlabs.org; robh+dt@kernel.org; > > linux-arm-kernel@lists.infradead.org; > > Wang Huan-B18965; Jin Zhengxiong-R64188; Zhao Chenhui-B35336 > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > On Tue, 2015-09-15 at 21:35 -0500, Tang Yuantian-B29983 wrote: > > > > > > > -----Original Message----- > > > > From: Wood Scott-B07421 > > > > Sent: Wednesday, September 16, 2015 10:32 AM > > > > To: Wang Dongsheng-B40534 <Dongsheng.Wang@freescale.com> > > > > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > > > > robh+dt@kernel.org; linux-arm-kernel@lists.infradead.org; Wang > > > > robh+Huan- > > > > B18965 <alison.wang@freescale.com>; Jin Zhengxiong-R64188 > > > > <Jason.Jin@freescale.com>; Zhao Chenhui-B35336 > > > > <chenhui.zhao@freescale.com>; Tang Yuantian-B29983 > > > > <Yuantian.Tang@freescale.com> > > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > > > On Tue, 2015-09-15 at 21:30 -0500, Wang Dongsheng-B40534 wrote: > > > > > Hi Scott, > > > > > > > > > > > -----Original Message----- > > > > > > From: Wood Scott-B07421 > > > > > > Sent: Wednesday, September 16, 2015 10:19 AM > > > > > > To: Wang Dongsheng-B40534 > > > > > > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > > > > > > robh+dt@kernel.org; linux-arm-kernel@lists.infradead.org; Wang > > > > > > robh+Huan- > > > > > > B18965; Jin > > > > > > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983 > > > > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > > > > > > > On Tue, 2015-09-15 at 21:15 -0500, Wang Dongsheng-B40534 wrote: > > > > > > > Hi Scott, > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > From: Wood Scott-B07421 > > > > > > > > Sent: Wednesday, September 16, 2015 7:57 AM > > > > > > > > To: Wang Dongsheng-B40534 > > > > > > > > Cc: devicetree@vger.kernel.org; > > > > > > > > linuxppc-dev@lists.ozlabs.org; > > > > > > > > robh+dt@kernel.org; linux-arm-kernel@lists.infradead.org; > > > > > > > > robh+Wang > > > > > > > > robh+Huan- > > > > > > > > B18965; Jin > > > > > > > > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang > > > > > > > > Yuantian-B29983 > > > > > > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > > > > > > > > > > > On Tue, 2015-09-15 at 16:55 +0800, Dongsheng Wang wrote: > > > > > > > > > +* Freescale RCPM Wakeup Source Device Tree Bindings > > > > > > > > > +------------------------------------------- > > > > > > > > > +Required rcpm-wakeup property should be added to a > > > > > > > > > +device node if the > > > > > > > > > device > > > > > > > > > +can be used as a wakeup source. > > > > > > > > > + > > > > > > > > > + - rcpm-wakeup: The value of the property consists of 3 cells. > > > > > > > > > + The > > > > > > > > > first > > > > > > > > > cell > > > > > > > > > + is a pointer to the rcpm node, the second cell is > > > > > > > > > + the bit mask > > > > > > > > > that > > > > > > > > > + should be set in IPPDEXPCR0, and the last cell is > > > > > > > > > + for > > > > > > > > > IPPDEXPCR1. > > > > > > > > > + Note: If the platform has no IPPDEXPCR1 register, > > > > > > > > > + put a zero > > > > > > > > > here. > > > > > > > > > > > > > > > > What if a future platform has more than two of these registers? > > > > > > > > > > > > > > Those registers are only used for wakeup device, we have a > > > > > > > lot of available bit for feature. For example, In LS1021a > > > > > > > platform only 7bits has used in the registers, and 57bits is > reserved. > > > > > > > > > > > > Still, it'd be better to for the rcpm node to advertise the > > > > > > number of cells it expects. > > > > > > > > > > For the foreseeable future it should be enough to use, even if > > > > > not enough to use in the future at that time we can update the binding. > > > > > > > > That's the whole point. Device tree is stable ABI. Updating it > > > > later to not be fixed to two cells would be a lot harder than > > > > getting it right from the beginning. Putting the number of cells > > > > in the phandle target is a standard device tree idiom. > > > > > > > I agree with you. But what's the point a SOC has more than 64 wakeup source? > > > > I don't know. Hardware people do strange things sometimes. They > > might not want to reuse bits they once used for something on some > > other chip, or they might have some encoding scheme in mind that > > results in the bits not being packed as tightly as possible, or there > > may be some big array of similar devices... > > > > What's the point of skipping this part of the phandle-plus-arguments idiom? > > Fine, I will add a property in rcpm node to describe the number of register. > How about the following modify? If okay for you I will fix in next version. Required properites: - reg : Offset and length of the register set of RCPM block. + - fsl,rcpm-wakeup-cell-num : The number of cell in rcpm-wakeup property. rcpm: global-utilities@e2000 { compatible = "fsl,t4240-rcpm", "fsl,qoriq-rcpm-2.0"; reg = <0xe2000 0x1000>; + fsl,rcpm-wakeup-cell-num = <2>; }; Regards, -Dongsheng _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev ^ permalink raw reply [flat|nested] 39+ messages in thread
* [PATCH v2 1/2] fsl: Add binding for RCPM @ 2015-09-16 3:18 ` Wang Dongsheng 0 siblings, 0 replies; 39+ messages in thread From: Wang Dongsheng @ 2015-09-16 3:18 UTC (permalink / raw) To: linux-arm-kernel Hi Scott, > -----Original Message----- > From: Wang Dongsheng-B40534 > Sent: Wednesday, September 16, 2015 10:44 AM > To: Wood Scott-B07421; Tang Yuantian-B29983 > Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; > robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang Huan-B18965; Jin > Zhengxiong-R64188; Zhao Chenhui-B35336 > Subject: RE: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > -----Original Message----- > > From: Wood Scott-B07421 > > Sent: Wednesday, September 16, 2015 10:38 AM > > To: Tang Yuantian-B29983 > > Cc: Wang Dongsheng-B40534; devicetree at vger.kernel.org; linuxppc- > > dev at lists.ozlabs.org; robh+dt at kernel.org; > > linux-arm-kernel at lists.infradead.org; > > Wang Huan-B18965; Jin Zhengxiong-R64188; Zhao Chenhui-B35336 > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > On Tue, 2015-09-15 at 21:35 -0500, Tang Yuantian-B29983 wrote: > > > > > > > -----Original Message----- > > > > From: Wood Scott-B07421 > > > > Sent: Wednesday, September 16, 2015 10:32 AM > > > > To: Wang Dongsheng-B40534 <Dongsheng.Wang@freescale.com> > > > > Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; > > > > robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang > > > > robh+Huan- > > > > B18965 <alison.wang@freescale.com>; Jin Zhengxiong-R64188 > > > > <Jason.Jin@freescale.com>; Zhao Chenhui-B35336 > > > > <chenhui.zhao@freescale.com>; Tang Yuantian-B29983 > > > > <Yuantian.Tang@freescale.com> > > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > > > On Tue, 2015-09-15 at 21:30 -0500, Wang Dongsheng-B40534 wrote: > > > > > Hi Scott, > > > > > > > > > > > -----Original Message----- > > > > > > From: Wood Scott-B07421 > > > > > > Sent: Wednesday, September 16, 2015 10:19 AM > > > > > > To: Wang Dongsheng-B40534 > > > > > > Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; > > > > > > robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang > > > > > > robh+Huan- > > > > > > B18965; Jin > > > > > > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983 > > > > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > > > > > > > On Tue, 2015-09-15 at 21:15 -0500, Wang Dongsheng-B40534 wrote: > > > > > > > Hi Scott, > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > From: Wood Scott-B07421 > > > > > > > > Sent: Wednesday, September 16, 2015 7:57 AM > > > > > > > > To: Wang Dongsheng-B40534 > > > > > > > > Cc: devicetree at vger.kernel.org; > > > > > > > > linuxppc-dev at lists.ozlabs.org; > > > > > > > > robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; > > > > > > > > robh+Wang > > > > > > > > robh+Huan- > > > > > > > > B18965; Jin > > > > > > > > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang > > > > > > > > Yuantian-B29983 > > > > > > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > > > > > > > > > > > On Tue, 2015-09-15 at 16:55 +0800, Dongsheng Wang wrote: > > > > > > > > > +* Freescale RCPM Wakeup Source Device Tree Bindings > > > > > > > > > +------------------------------------------- > > > > > > > > > +Required rcpm-wakeup property should be added to a > > > > > > > > > +device node if the > > > > > > > > > device > > > > > > > > > +can be used as a wakeup source. > > > > > > > > > + > > > > > > > > > + - rcpm-wakeup: The value of the property consists of 3 cells. > > > > > > > > > + The > > > > > > > > > first > > > > > > > > > cell > > > > > > > > > + is a pointer to the rcpm node, the second cell is > > > > > > > > > + the bit mask > > > > > > > > > that > > > > > > > > > + should be set in IPPDEXPCR0, and the last cell is > > > > > > > > > + for > > > > > > > > > IPPDEXPCR1. > > > > > > > > > + Note: If the platform has no IPPDEXPCR1 register, > > > > > > > > > + put a zero > > > > > > > > > here. > > > > > > > > > > > > > > > > What if a future platform has more than two of these registers? > > > > > > > > > > > > > > Those registers are only used for wakeup device, we have a > > > > > > > lot of available bit for feature. For example, In LS1021a > > > > > > > platform only 7bits has used in the registers, and 57bits is > reserved. > > > > > > > > > > > > Still, it'd be better to for the rcpm node to advertise the > > > > > > number of cells it expects. > > > > > > > > > > For the foreseeable future it should be enough to use, even if > > > > > not enough to use in the future at that time we can update the binding. > > > > > > > > That's the whole point. Device tree is stable ABI. Updating it > > > > later to not be fixed to two cells would be a lot harder than > > > > getting it right from the beginning. Putting the number of cells > > > > in the phandle target is a standard device tree idiom. > > > > > > > I agree with you. But what's the point a SOC has more than 64 wakeup source? > > > > I don't know. Hardware people do strange things sometimes. They > > might not want to reuse bits they once used for something on some > > other chip, or they might have some encoding scheme in mind that > > results in the bits not being packed as tightly as possible, or there > > may be some big array of similar devices... > > > > What's the point of skipping this part of the phandle-plus-arguments idiom? > > Fine, I will add a property in rcpm node to describe the number of register. > How about the following modify? If okay for you I will fix in next version. Required properites: - reg : Offset and length of the register set of RCPM block. + - fsl,rcpm-wakeup-cell-num : The number of cell in rcpm-wakeup property. rcpm: global-utilities at e2000 { compatible = "fsl,t4240-rcpm", "fsl,qoriq-rcpm-2.0"; reg = <0xe2000 0x1000>; + fsl,rcpm-wakeup-cell-num = <2>; }; Regards, -Dongsheng ^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [PATCH v2 1/2] fsl: Add binding for RCPM 2015-09-16 3:18 ` Wang Dongsheng (?) @ 2015-09-16 4:13 ` Scott Wood -1 siblings, 0 replies; 39+ messages in thread From: Scott Wood @ 2015-09-16 4:13 UTC (permalink / raw) To: Wang Dongsheng-B40534 Cc: Tang Yuantian-B29983, devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, Wang Huan-B18965, Jin Zhengxiong-R64188, Zhao Chenhui-B35336 On Tue, 2015-09-15 at 22:18 -0500, Wang Dongsheng-B40534 wrote: > Hi Scott, > > > -----Original Message----- > > From: Wang Dongsheng-B40534 > > Sent: Wednesday, September 16, 2015 10:44 AM > > To: Wood Scott-B07421; Tang Yuantian-B29983 > > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > > robh+dt@kernel.org; linux-arm-kernel@lists.infradead.org; Wang Huan- > > B18965; Jin > > Zhengxiong-R64188; Zhao Chenhui-B35336 > > Subject: RE: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > > > > -----Original Message----- > > > From: Wood Scott-B07421 > > > Sent: Wednesday, September 16, 2015 10:38 AM > > > To: Tang Yuantian-B29983 > > > Cc: Wang Dongsheng-B40534; devicetree@vger.kernel.org; linuxppc- > > > dev@lists.ozlabs.org; robh+dt@kernel.org; > > > linux-arm-kernel@lists.infradead.org; > > > Wang Huan-B18965; Jin Zhengxiong-R64188; Zhao Chenhui-B35336 > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > On Tue, 2015-09-15 at 21:35 -0500, Tang Yuantian-B29983 wrote: > > > > > > > > > -----Original Message----- > > > > > From: Wood Scott-B07421 > > > > > Sent: Wednesday, September 16, 2015 10:32 AM > > > > > To: Wang Dongsheng-B40534 <Dongsheng.Wang@freescale.com> > > > > > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > > > > > robh+dt@kernel.org; linux-arm-kernel@lists.infradead.org; Wang > > > > > robh+Huan- > > > > > B18965 <alison.wang@freescale.com>; Jin Zhengxiong-R64188 > > > > > <Jason.Jin@freescale.com>; Zhao Chenhui-B35336 > > > > > <chenhui.zhao@freescale.com>; Tang Yuantian-B29983 > > > > > <Yuantian.Tang@freescale.com> > > > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > > > > > On Tue, 2015-09-15 at 21:30 -0500, Wang Dongsheng-B40534 wrote: > > > > > > Hi Scott, > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Wood Scott-B07421 > > > > > > > Sent: Wednesday, September 16, 2015 10:19 AM > > > > > > > To: Wang Dongsheng-B40534 > > > > > > > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > > > > > > > robh+dt@kernel.org; linux-arm-kernel@lists.infradead.org; Wang > > > > > > > robh+Huan- > > > > > > > B18965; Jin > > > > > > > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983 > > > > > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > > > > > > > > > On Tue, 2015-09-15 at 21:15 -0500, Wang Dongsheng-B40534 wrote: > > > > > > > > Hi Scott, > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > > From: Wood Scott-B07421 > > > > > > > > > Sent: Wednesday, September 16, 2015 7:57 AM > > > > > > > > > To: Wang Dongsheng-B40534 > > > > > > > > > Cc: devicetree@vger.kernel.org; > > > > > > > > > linuxppc-dev@lists.ozlabs.org; > > > > > > > > > robh+dt@kernel.org; linux-arm-kernel@lists.infradead.org; > > > > > > > > > robh+Wang > > > > > > > > > robh+Huan- > > > > > > > > > B18965; Jin > > > > > > > > > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang > > > > > > > > > Yuantian-B29983 > > > > > > > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > > > > > > > > > > > > > On Tue, 2015-09-15 at 16:55 +0800, Dongsheng Wang wrote: > > > > > > > > > > +* Freescale RCPM Wakeup Source Device Tree Bindings > > > > > > > > > > +------------------------------------------- > > > > > > > > > > +Required rcpm-wakeup property should be added to a > > > > > > > > > > +device node if the > > > > > > > > > > device > > > > > > > > > > +can be used as a wakeup source. > > > > > > > > > > + > > > > > > > > > > + - rcpm-wakeup: The value of the property consists of 3 > > > > > > > > > > cells. > > > > > > > > > > + The > > > > > > > > > > first > > > > > > > > > > cell > > > > > > > > > > + is a pointer to the rcpm node, the second cell is > > > > > > > > > > + the bit mask > > > > > > > > > > that > > > > > > > > > > + should be set in IPPDEXPCR0, and the last cell is > > > > > > > > > > + for > > > > > > > > > > IPPDEXPCR1. > > > > > > > > > > + Note: If the platform has no IPPDEXPCR1 register, > > > > > > > > > > + put a zero > > > > > > > > > > here. > > > > > > > > > > > > > > > > > > What if a future platform has more than two of these > > > > > > > > > registers? > > > > > > > > > > > > > > > > Those registers are only used for wakeup device, we have a > > > > > > > > lot of available bit for feature. For example, In LS1021a > > > > > > > > platform only 7bits has used in the registers, and 57bits is > > reserved. > > > > > > > > > > > > > > Still, it'd be better to for the rcpm node to advertise the > > > > > > > number of cells it expects. > > > > > > > > > > > > For the foreseeable future it should be enough to use, even if > > > > > > not enough to use in the future at that time we can update the > > > > > > binding. > > > > > > > > > > That's the whole point. Device tree is stable ABI. Updating it > > > > > later to not be fixed to two cells would be a lot harder than > > > > > getting it right from the beginning. Putting the number of cells > > > > > in the phandle target is a standard device tree idiom. > > > > > > > > > I agree with you. But what's the point a SOC has more than 64 wakeup > > > > source? > > > > > > I don't know. Hardware people do strange things sometimes. They > > > might not want to reuse bits they once used for something on some > > > other chip, or they might have some encoding scheme in mind that > > > results in the bits not being packed as tightly as possible, or there > > > may be some big array of similar devices... > > > > > > What's the point of skipping this part of the phandle-plus-arguments > > > idiom? > > > > Fine, I will add a property in rcpm node to describe the number of > > register. > > > > How about the following modify? If okay for you I will fix in next version. > > Required properites: > - reg : Offset and length of the register set of RCPM block. > + - fsl,rcpm-wakeup-cell-num : The number of cell in rcpm-wakeup property. > > rcpm: global-utilities@e2000{ > compatible = "fsl,t4240-rcpm", "fsl,qoriq-rcpm-2.0"; > reg = <0xe2000 0x1000>; > + fsl,rcpm-wakeup-cell-num = <2>; > }; OK, though "fsl,#rcpm-wakeup-cells" would be more idiomatic. Also s/number of cell/number of cells/ -Scott ^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [PATCH v2 1/2] fsl: Add binding for RCPM @ 2015-09-16 4:13 ` Scott Wood 0 siblings, 0 replies; 39+ messages in thread From: Scott Wood @ 2015-09-16 4:13 UTC (permalink / raw) To: Wang Dongsheng-B40534 Cc: Tang Yuantian-B29983, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Wang Huan-B18965, Jin Zhengxiong-R64188, Zhao Chenhui-B35336 On Tue, 2015-09-15 at 22:18 -0500, Wang Dongsheng-B40534 wrote: > Hi Scott, > > > -----Original Message----- > > From: Wang Dongsheng-B40534 > > Sent: Wednesday, September 16, 2015 10:44 AM > > To: Wood Scott-B07421; Tang Yuantian-B29983 > > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org; > > robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org; linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org; Wang Huan- > > B18965; Jin > > Zhengxiong-R64188; Zhao Chenhui-B35336 > > Subject: RE: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > > > > -----Original Message----- > > > From: Wood Scott-B07421 > > > Sent: Wednesday, September 16, 2015 10:38 AM > > > To: Tang Yuantian-B29983 > > > Cc: Wang Dongsheng-B40534; devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linuxppc- > > > dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org; robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org; > > > linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org; > > > Wang Huan-B18965; Jin Zhengxiong-R64188; Zhao Chenhui-B35336 > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > On Tue, 2015-09-15 at 21:35 -0500, Tang Yuantian-B29983 wrote: > > > > > > > > > -----Original Message----- > > > > > From: Wood Scott-B07421 > > > > > Sent: Wednesday, September 16, 2015 10:32 AM > > > > > To: Wang Dongsheng-B40534 <Dongsheng.Wang-KZfg59tc24xl57MIdRCFDg@public.gmane.org> > > > > > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org; > > > > > robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org; linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org; Wang > > > > > robh+Huan- > > > > > B18965 <alison.wang-KZfg59tc24xl57MIdRCFDg@public.gmane.org>; Jin Zhengxiong-R64188 > > > > > <Jason.Jin-KZfg59tc24xl57MIdRCFDg@public.gmane.org>; Zhao Chenhui-B35336 > > > > > <chenhui.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org>; Tang Yuantian-B29983 > > > > > <Yuantian.Tang-KZfg59tc24xl57MIdRCFDg@public.gmane.org> > > > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > > > > > On Tue, 2015-09-15 at 21:30 -0500, Wang Dongsheng-B40534 wrote: > > > > > > Hi Scott, > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Wood Scott-B07421 > > > > > > > Sent: Wednesday, September 16, 2015 10:19 AM > > > > > > > To: Wang Dongsheng-B40534 > > > > > > > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org; > > > > > > > robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org; linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org; Wang > > > > > > > robh+Huan- > > > > > > > B18965; Jin > > > > > > > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983 > > > > > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > > > > > > > > > On Tue, 2015-09-15 at 21:15 -0500, Wang Dongsheng-B40534 wrote: > > > > > > > > Hi Scott, > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > > From: Wood Scott-B07421 > > > > > > > > > Sent: Wednesday, September 16, 2015 7:57 AM > > > > > > > > > To: Wang Dongsheng-B40534 > > > > > > > > > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; > > > > > > > > > linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org; > > > > > > > > > robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org; linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org; > > > > > > > > > robh+Wang > > > > > > > > > robh+Huan- > > > > > > > > > B18965; Jin > > > > > > > > > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang > > > > > > > > > Yuantian-B29983 > > > > > > > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > > > > > > > > > > > > > On Tue, 2015-09-15 at 16:55 +0800, Dongsheng Wang wrote: > > > > > > > > > > +* Freescale RCPM Wakeup Source Device Tree Bindings > > > > > > > > > > +------------------------------------------- > > > > > > > > > > +Required rcpm-wakeup property should be added to a > > > > > > > > > > +device node if the > > > > > > > > > > device > > > > > > > > > > +can be used as a wakeup source. > > > > > > > > > > + > > > > > > > > > > + - rcpm-wakeup: The value of the property consists of 3 > > > > > > > > > > cells. > > > > > > > > > > + The > > > > > > > > > > first > > > > > > > > > > cell > > > > > > > > > > + is a pointer to the rcpm node, the second cell is > > > > > > > > > > + the bit mask > > > > > > > > > > that > > > > > > > > > > + should be set in IPPDEXPCR0, and the last cell is > > > > > > > > > > + for > > > > > > > > > > IPPDEXPCR1. > > > > > > > > > > + Note: If the platform has no IPPDEXPCR1 register, > > > > > > > > > > + put a zero > > > > > > > > > > here. > > > > > > > > > > > > > > > > > > What if a future platform has more than two of these > > > > > > > > > registers? > > > > > > > > > > > > > > > > Those registers are only used for wakeup device, we have a > > > > > > > > lot of available bit for feature. For example, In LS1021a > > > > > > > > platform only 7bits has used in the registers, and 57bits is > > reserved. > > > > > > > > > > > > > > Still, it'd be better to for the rcpm node to advertise the > > > > > > > number of cells it expects. > > > > > > > > > > > > For the foreseeable future it should be enough to use, even if > > > > > > not enough to use in the future at that time we can update the > > > > > > binding. > > > > > > > > > > That's the whole point. Device tree is stable ABI. Updating it > > > > > later to not be fixed to two cells would be a lot harder than > > > > > getting it right from the beginning. Putting the number of cells > > > > > in the phandle target is a standard device tree idiom. > > > > > > > > > I agree with you. But what's the point a SOC has more than 64 wakeup > > > > source? > > > > > > I don't know. Hardware people do strange things sometimes. They > > > might not want to reuse bits they once used for something on some > > > other chip, or they might have some encoding scheme in mind that > > > results in the bits not being packed as tightly as possible, or there > > > may be some big array of similar devices... > > > > > > What's the point of skipping this part of the phandle-plus-arguments > > > idiom? > > > > Fine, I will add a property in rcpm node to describe the number of > > register. > > > > How about the following modify? If okay for you I will fix in next version. > > Required properites: > - reg : Offset and length of the register set of RCPM block. > + - fsl,rcpm-wakeup-cell-num : The number of cell in rcpm-wakeup property. > > rcpm: global-utilities@e2000{ > compatible = "fsl,t4240-rcpm", "fsl,qoriq-rcpm-2.0"; > reg = <0xe2000 0x1000>; > + fsl,rcpm-wakeup-cell-num = <2>; > }; OK, though "fsl,#rcpm-wakeup-cells" would be more idiomatic. Also s/number of cell/number of cells/ -Scott -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 39+ messages in thread
* [PATCH v2 1/2] fsl: Add binding for RCPM @ 2015-09-16 4:13 ` Scott Wood 0 siblings, 0 replies; 39+ messages in thread From: Scott Wood @ 2015-09-16 4:13 UTC (permalink / raw) To: linux-arm-kernel On Tue, 2015-09-15 at 22:18 -0500, Wang Dongsheng-B40534 wrote: > Hi Scott, > > > -----Original Message----- > > From: Wang Dongsheng-B40534 > > Sent: Wednesday, September 16, 2015 10:44 AM > > To: Wood Scott-B07421; Tang Yuantian-B29983 > > Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; > > robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang Huan- > > B18965; Jin > > Zhengxiong-R64188; Zhao Chenhui-B35336 > > Subject: RE: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > > > > -----Original Message----- > > > From: Wood Scott-B07421 > > > Sent: Wednesday, September 16, 2015 10:38 AM > > > To: Tang Yuantian-B29983 > > > Cc: Wang Dongsheng-B40534; devicetree at vger.kernel.org; linuxppc- > > > dev at lists.ozlabs.org; robh+dt at kernel.org; > > > linux-arm-kernel at lists.infradead.org; > > > Wang Huan-B18965; Jin Zhengxiong-R64188; Zhao Chenhui-B35336 > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > On Tue, 2015-09-15 at 21:35 -0500, Tang Yuantian-B29983 wrote: > > > > > > > > > -----Original Message----- > > > > > From: Wood Scott-B07421 > > > > > Sent: Wednesday, September 16, 2015 10:32 AM > > > > > To: Wang Dongsheng-B40534 <Dongsheng.Wang@freescale.com> > > > > > Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; > > > > > robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang > > > > > robh+Huan- > > > > > B18965 <alison.wang@freescale.com>; Jin Zhengxiong-R64188 > > > > > <Jason.Jin@freescale.com>; Zhao Chenhui-B35336 > > > > > <chenhui.zhao@freescale.com>; Tang Yuantian-B29983 > > > > > <Yuantian.Tang@freescale.com> > > > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > > > > > On Tue, 2015-09-15 at 21:30 -0500, Wang Dongsheng-B40534 wrote: > > > > > > Hi Scott, > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Wood Scott-B07421 > > > > > > > Sent: Wednesday, September 16, 2015 10:19 AM > > > > > > > To: Wang Dongsheng-B40534 > > > > > > > Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; > > > > > > > robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang > > > > > > > robh+Huan- > > > > > > > B18965; Jin > > > > > > > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983 > > > > > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > > > > > > > > > On Tue, 2015-09-15 at 21:15 -0500, Wang Dongsheng-B40534 wrote: > > > > > > > > Hi Scott, > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > > From: Wood Scott-B07421 > > > > > > > > > Sent: Wednesday, September 16, 2015 7:57 AM > > > > > > > > > To: Wang Dongsheng-B40534 > > > > > > > > > Cc: devicetree at vger.kernel.org; > > > > > > > > > linuxppc-dev at lists.ozlabs.org; > > > > > > > > > robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; > > > > > > > > > robh+Wang > > > > > > > > > robh+Huan- > > > > > > > > > B18965; Jin > > > > > > > > > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang > > > > > > > > > Yuantian-B29983 > > > > > > > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > > > > > > > > > > > > > On Tue, 2015-09-15 at 16:55 +0800, Dongsheng Wang wrote: > > > > > > > > > > +* Freescale RCPM Wakeup Source Device Tree Bindings > > > > > > > > > > +------------------------------------------- > > > > > > > > > > +Required rcpm-wakeup property should be added to a > > > > > > > > > > +device node if the > > > > > > > > > > device > > > > > > > > > > +can be used as a wakeup source. > > > > > > > > > > + > > > > > > > > > > + - rcpm-wakeup: The value of the property consists of 3 > > > > > > > > > > cells. > > > > > > > > > > + The > > > > > > > > > > first > > > > > > > > > > cell > > > > > > > > > > + is a pointer to the rcpm node, the second cell is > > > > > > > > > > + the bit mask > > > > > > > > > > that > > > > > > > > > > + should be set in IPPDEXPCR0, and the last cell is > > > > > > > > > > + for > > > > > > > > > > IPPDEXPCR1. > > > > > > > > > > + Note: If the platform has no IPPDEXPCR1 register, > > > > > > > > > > + put a zero > > > > > > > > > > here. > > > > > > > > > > > > > > > > > > What if a future platform has more than two of these > > > > > > > > > registers? > > > > > > > > > > > > > > > > Those registers are only used for wakeup device, we have a > > > > > > > > lot of available bit for feature. For example, In LS1021a > > > > > > > > platform only 7bits has used in the registers, and 57bits is > > reserved. > > > > > > > > > > > > > > Still, it'd be better to for the rcpm node to advertise the > > > > > > > number of cells it expects. > > > > > > > > > > > > For the foreseeable future it should be enough to use, even if > > > > > > not enough to use in the future at that time we can update the > > > > > > binding. > > > > > > > > > > That's the whole point. Device tree is stable ABI. Updating it > > > > > later to not be fixed to two cells would be a lot harder than > > > > > getting it right from the beginning. Putting the number of cells > > > > > in the phandle target is a standard device tree idiom. > > > > > > > > > I agree with you. But what's the point a SOC has more than 64 wakeup > > > > source? > > > > > > I don't know. Hardware people do strange things sometimes. They > > > might not want to reuse bits they once used for something on some > > > other chip, or they might have some encoding scheme in mind that > > > results in the bits not being packed as tightly as possible, or there > > > may be some big array of similar devices... > > > > > > What's the point of skipping this part of the phandle-plus-arguments > > > idiom? > > > > Fine, I will add a property in rcpm node to describe the number of > > register. > > > > How about the following modify? If okay for you I will fix in next version. > > Required properites: > - reg : Offset and length of the register set of RCPM block. > + - fsl,rcpm-wakeup-cell-num : The number of cell in rcpm-wakeup property. > > rcpm: global-utilities at e2000{ > compatible = "fsl,t4240-rcpm", "fsl,qoriq-rcpm-2.0"; > reg = <0xe2000 0x1000>; > + fsl,rcpm-wakeup-cell-num = <2>; > }; OK, though "fsl,#rcpm-wakeup-cells" would be more idiomatic. Also s/number of cell/number of cells/ -Scott ^ permalink raw reply [flat|nested] 39+ messages in thread
* RE: [PATCH v2 1/2] fsl: Add binding for RCPM 2015-09-16 4:13 ` Scott Wood (?) @ 2015-09-16 5:11 ` Wang Dongsheng -1 siblings, 0 replies; 39+ messages in thread From: Wang Dongsheng @ 2015-09-16 5:11 UTC (permalink / raw) To: Scott Wood Cc: Yuantian Tang, devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, Huan Wang, Jin Jason, Zhao C.H. DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogV29vZCBTY290dC1CMDc0 MjENCj4gU2VudDogV2VkbmVzZGF5LCBTZXB0ZW1iZXIgMTYsIDIwMTUgMTI6MTQgUE0NCj4gVG86 IFdhbmcgRG9uZ3NoZW5nLUI0MDUzNA0KPiBDYzogVGFuZyBZdWFudGlhbi1CMjk5ODM7IGRldmlj ZXRyZWVAdmdlci5rZXJuZWwub3JnOyBsaW51eHBwYy0NCj4gZGV2QGxpc3RzLm96bGFicy5vcmc7 IHJvYmgrZHRAa2VybmVsLm9yZzsgbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3Jn Ow0KPiBXYW5nIEh1YW4tQjE4OTY1OyBKaW4gWmhlbmd4aW9uZy1SNjQxODg7IFpoYW8gQ2hlbmh1 aS1CMzUzMzYNCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2MiAxLzJdIGZzbDogQWRkIGJpbmRpbmcg Zm9yIFJDUE0NCj4gDQo+IE9uIFR1ZSwgMjAxNS0wOS0xNSBhdCAyMjoxOCAtMDUwMCwgV2FuZyBE b25nc2hlbmctQjQwNTM0IHdyb3RlOg0KPiA+IEhpIFNjb3R0LA0KPiA+DQo+ID4gPiAtLS0tLU9y aWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+ID4gRnJvbTogV2FuZyBEb25nc2hlbmctQjQwNTM0DQo+ ID4gPiBTZW50OiBXZWRuZXNkYXksIFNlcHRlbWJlciAxNiwgMjAxNSAxMDo0NCBBTQ0KPiA+ID4g VG86IFdvb2QgU2NvdHQtQjA3NDIxOyBUYW5nIFl1YW50aWFuLUIyOTk4Mw0KPiA+ID4gQ2M6IGRl dmljZXRyZWVAdmdlci5rZXJuZWwub3JnOyBsaW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9yZzsN Cj4gPiA+IHJvYmgrZHRAa2VybmVsLm9yZzsgbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRl YWQub3JnOyBXYW5nIEh1YW4tDQo+ID4gPiBCMTg5NjU7IEppbg0KPiA+ID4gWmhlbmd4aW9uZy1S NjQxODg7IFpoYW8gQ2hlbmh1aS1CMzUzMzYNCj4gPiA+IFN1YmplY3Q6IFJFOiBbUEFUQ0ggdjIg MS8yXSBmc2w6IEFkZCBiaW5kaW5nIGZvciBSQ1BNDQo+ID4gPg0KPiA+ID4NCj4gPiA+DQo+ID4g PiA+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4gPiA+IEZyb206IFdvb2QgU2NvdHQt QjA3NDIxDQo+ID4gPiA+IFNlbnQ6IFdlZG5lc2RheSwgU2VwdGVtYmVyIDE2LCAyMDE1IDEwOjM4 IEFNDQo+ID4gPiA+IFRvOiBUYW5nIFl1YW50aWFuLUIyOTk4Mw0KPiA+ID4gPiBDYzogV2FuZyBE b25nc2hlbmctQjQwNTM0OyBkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZzsgbGludXhwcGMtDQo+ ID4gPiA+IGRldkBsaXN0cy5vemxhYnMub3JnOyByb2JoK2R0QGtlcm5lbC5vcmc7DQo+ID4gPiA+ IGxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZzsNCj4gPiA+ID4gV2FuZyBIdWFu LUIxODk2NTsgSmluIFpoZW5neGlvbmctUjY0MTg4OyBaaGFvIENoZW5odWktQjM1MzM2DQo+ID4g PiA+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjIgMS8yXSBmc2w6IEFkZCBiaW5kaW5nIGZvciBSQ1BN DQo+ID4gPiA+DQo+ID4gPiA+IE9uIFR1ZSwgMjAxNS0wOS0xNSBhdCAyMTozNSAtMDUwMCwgVGFu ZyBZdWFudGlhbi1CMjk5ODMgd3JvdGU6DQo+ID4gPiA+ID4NCj4gPiA+ID4gPiA+IC0tLS0tT3Jp Z2luYWwgTWVzc2FnZS0tLS0tDQo+ID4gPiA+ID4gPiBGcm9tOiBXb29kIFNjb3R0LUIwNzQyMQ0K PiA+ID4gPiA+ID4gU2VudDogV2VkbmVzZGF5LCBTZXB0ZW1iZXIgMTYsIDIwMTUgMTA6MzIgQU0N Cj4gPiA+ID4gPiA+IFRvOiBXYW5nIERvbmdzaGVuZy1CNDA1MzQgPERvbmdzaGVuZy5XYW5nQGZy ZWVzY2FsZS5jb20+DQo+ID4gPiA+ID4gPiBDYzogZGV2aWNldHJlZUB2Z2VyLmtlcm5lbC5vcmc7 IGxpbnV4cHBjLWRldkBsaXN0cy5vemxhYnMub3JnOw0KPiA+ID4gPiA+ID4gcm9iaCtkdEBrZXJu ZWwub3JnOyBsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmc7IFdhbmcNCj4gPiA+ ID4gPiA+IHJvYmgrSHVhbi0NCj4gPiA+ID4gPiA+IEIxODk2NSA8YWxpc29uLndhbmdAZnJlZXNj YWxlLmNvbT47IEppbiBaaGVuZ3hpb25nLVI2NDE4OA0KPiA+ID4gPiA+ID4gPEphc29uLkppbkBm cmVlc2NhbGUuY29tPjsgWmhhbyBDaGVuaHVpLUIzNTMzNg0KPiA+ID4gPiA+ID4gPGNoZW5odWku emhhb0BmcmVlc2NhbGUuY29tPjsgVGFuZyBZdWFudGlhbi1CMjk5ODMNCj4gPiA+ID4gPiA+IDxZ dWFudGlhbi5UYW5nQGZyZWVzY2FsZS5jb20+DQo+ID4gPiA+ID4gPiBTdWJqZWN0OiBSZTogW1BB VENIIHYyIDEvMl0gZnNsOiBBZGQgYmluZGluZyBmb3IgUkNQTQ0KPiA+ID4gPiA+ID4NCj4gPiA+ ID4gPiA+IE9uIFR1ZSwgMjAxNS0wOS0xNSBhdCAyMTozMCAtMDUwMCwgV2FuZyBEb25nc2hlbmct QjQwNTM0IHdyb3RlOg0KPiA+ID4gPiA+ID4gPiBIaSBTY290dCwNCj4gPiA+ID4gPiA+ID4NCj4g PiA+ID4gPiA+ID4gPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+ID4gPiA+ID4gPiA+ IEZyb206IFdvb2QgU2NvdHQtQjA3NDIxDQo+ID4gPiA+ID4gPiA+ID4gU2VudDogV2VkbmVzZGF5 LCBTZXB0ZW1iZXIgMTYsIDIwMTUgMTA6MTkgQU0NCj4gPiA+ID4gPiA+ID4gPiBUbzogV2FuZyBE b25nc2hlbmctQjQwNTM0DQo+ID4gPiA+ID4gPiA+ID4gQ2M6IGRldmljZXRyZWVAdmdlci5rZXJu ZWwub3JnOw0KPiA+ID4gPiA+ID4gPiA+IGxpbnV4cHBjLWRldkBsaXN0cy5vemxhYnMub3JnOw0K PiA+ID4gPiA+ID4gPiA+IHJvYmgrZHRAa2VybmVsLm9yZzsgbGludXgtYXJtLWtlcm5lbEBsaXN0 cy5pbmZyYWRlYWQub3JnOw0KPiA+ID4gPiA+ID4gPiA+IHJvYmgrV2FuZw0KPiA+ID4gPiA+ID4g PiA+IHJvYmgrSHVhbi0NCj4gPiA+ID4gPiA+ID4gPiBCMTg5NjU7IEppbg0KPiA+ID4gPiA+ID4g PiA+IFpoZW5neGlvbmctUjY0MTg4OyBaaGFvIENoZW5odWktQjM1MzM2OyBUYW5nDQo+ID4gPiA+ ID4gPiA+ID4gWXVhbnRpYW4tQjI5OTgzDQo+ID4gPiA+ID4gPiA+ID4gU3ViamVjdDogUmU6IFtQ QVRDSCB2MiAxLzJdIGZzbDogQWRkIGJpbmRpbmcgZm9yIFJDUE0NCj4gPiA+ID4gPiA+ID4gPg0K PiA+ID4gPiA+ID4gPiA+IE9uIFR1ZSwgMjAxNS0wOS0xNSBhdCAyMToxNSAtMDUwMCwgV2FuZyBE b25nc2hlbmctQjQwNTM0IHdyb3RlOg0KPiA+ID4gPiA+ID4gPiA+ID4gSGkgU2NvdHQsDQo+ID4g PiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2Ut LS0tLQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiBGcm9tOiBXb29kIFNjb3R0LUIwNzQyMQ0KPiA+ID4g PiA+ID4gPiA+ID4gPiBTZW50OiBXZWRuZXNkYXksIFNlcHRlbWJlciAxNiwgMjAxNSA3OjU3IEFN DQo+ID4gPiA+ID4gPiA+ID4gPiA+IFRvOiBXYW5nIERvbmdzaGVuZy1CNDA1MzQNCj4gPiA+ID4g PiA+ID4gPiA+ID4gQ2M6IGRldmljZXRyZWVAdmdlci5rZXJuZWwub3JnOw0KPiA+ID4gPiA+ID4g PiA+ID4gPiBsaW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9yZzsNCj4gPiA+ID4gPiA+ID4gPiA+ ID4gcm9iaCtkdEBrZXJuZWwub3JnOw0KPiA+ID4gPiA+ID4gPiA+ID4gPiByb2JoK2xpbnV4LWFy bS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZzsNCj4gPiA+ID4gPiA+ID4gPiA+ID4gcm9iaCtX YW5nDQo+ID4gPiA+ID4gPiA+ID4gPiA+IHJvYmgrSHVhbi0NCj4gPiA+ID4gPiA+ID4gPiA+ID4g QjE4OTY1OyBKaW4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gWmhlbmd4aW9uZy1SNjQxODg7IFpoYW8g Q2hlbmh1aS1CMzUzMzY7IFRhbmcNCj4gPiA+ID4gPiA+ID4gPiA+ID4gWXVhbnRpYW4tQjI5OTgz DQo+ID4gPiA+ID4gPiA+ID4gPiA+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjIgMS8yXSBmc2w6IEFk ZCBiaW5kaW5nIGZvciBSQ1BNDQo+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4g PiA+IE9uIFR1ZSwgMjAxNS0wOS0xNSBhdCAxNjo1NSArMDgwMCwgRG9uZ3NoZW5nIFdhbmcgd3Jv dGU6DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gKyogRnJlZXNjYWxlIFJDUE0gV2FrZXVwIFNvdXJj ZSBEZXZpY2UgVHJlZSBCaW5kaW5ncw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ICstLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4g K1JlcXVpcmVkIHJjcG0td2FrZXVwIHByb3BlcnR5IHNob3VsZCBiZSBhZGRlZCB0byBhDQo+ID4g PiA+ID4gPiA+ID4gPiA+ID4gK2RldmljZSBub2RlIGlmIHRoZQ0KPiA+ID4gPiA+ID4gPiA+ID4g PiA+IGRldmljZQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ICtjYW4gYmUgdXNlZCBhcyBhIHdha2V1 cCBzb3VyY2UuDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gKw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ ICsgIC0gcmNwbS13YWtldXA6IFRoZSB2YWx1ZSBvZiB0aGUgcHJvcGVydHkgY29uc2lzdHMNCj4g PiA+ID4gPiA+ID4gPiA+ID4gPiArIG9mIDMNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBjZWxscy4N Cj4gPiA+ID4gPiA+ID4gPiA+ID4gPiArIFRoZQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGZpcnN0 DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gY2VsbA0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ICsgICAg IGlzIGEgcG9pbnRlciB0byB0aGUgcmNwbSBub2RlLCB0aGUgc2Vjb25kIGNlbGwNCj4gPiA+ID4g PiA+ID4gPiA+ID4gPiArIGlzIHRoZSBiaXQgbWFzaw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IHRo YXQNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiArICAgICBzaG91bGQgYmUgc2V0IGluIElQUERFWFBD UjAsIGFuZCB0aGUgbGFzdCBjZWxsDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gKyBpcyBmb3INCj4g PiA+ID4gPiA+ID4gPiA+ID4gPiBJUFBERVhQQ1IxLg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ICsg ICAgIE5vdGU6IElmIHRoZSBwbGF0Zm9ybSBoYXMgbm8gSVBQREVYUENSMQ0KPiA+ID4gPiA+ID4g PiA+ID4gPiA+ICsgcmVnaXN0ZXIsIHB1dCBhIHplcm8NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBo ZXJlLg0KPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiBXaGF0IGlmIGEg ZnV0dXJlIHBsYXRmb3JtIGhhcyBtb3JlIHRoYW4gdHdvIG9mIHRoZXNlDQo+ID4gPiA+ID4gPiA+ ID4gPiA+IHJlZ2lzdGVycz8NCj4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiBU aG9zZSByZWdpc3RlcnMgYXJlIG9ubHkgdXNlZCBmb3Igd2FrZXVwIGRldmljZSwgd2UgaGF2ZQ0K PiA+ID4gPiA+ID4gPiA+ID4gYSBsb3Qgb2YgYXZhaWxhYmxlIGJpdCBmb3IgZmVhdHVyZS4gRm9y IGV4YW1wbGUsIEluDQo+ID4gPiA+ID4gPiA+ID4gPiBMUzEwMjFhIHBsYXRmb3JtIG9ubHkgN2Jp dHMgaGFzIHVzZWQgaW4gdGhlIHJlZ2lzdGVycywNCj4gPiA+ID4gPiA+ID4gPiA+IGFuZCA1N2Jp dHMgaXMNCj4gPiA+IHJlc2VydmVkLg0KPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4g U3RpbGwsIGl0J2QgYmUgYmV0dGVyIHRvIGZvciB0aGUgcmNwbSBub2RlIHRvIGFkdmVydGlzZQ0K PiA+ID4gPiA+ID4gPiA+IHRoZSBudW1iZXIgb2YgY2VsbHMgaXQgZXhwZWN0cy4NCj4gPiA+ID4g PiA+ID4NCj4gPiA+ID4gPiA+ID4gRm9yIHRoZSBmb3Jlc2VlYWJsZSBmdXR1cmUgaXQgc2hvdWxk IGJlIGVub3VnaCB0byB1c2UsIGV2ZW4NCj4gPiA+ID4gPiA+ID4gaWYgbm90IGVub3VnaCB0byB1 c2UgaW4gdGhlIGZ1dHVyZSBhdCB0aGF0IHRpbWUgd2UgY2FuDQo+ID4gPiA+ID4gPiA+IHVwZGF0 ZSB0aGUgYmluZGluZy4NCj4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiBUaGF0J3MgdGhlIHdob2xl IHBvaW50LiAgRGV2aWNlIHRyZWUgaXMgc3RhYmxlIEFCSS4gIFVwZGF0aW5nDQo+ID4gPiA+ID4g PiBpdCBsYXRlciB0byBub3QgYmUgZml4ZWQgdG8gdHdvIGNlbGxzIHdvdWxkIGJlIGEgbG90IGhh cmRlcg0KPiA+ID4gPiA+ID4gdGhhbiBnZXR0aW5nIGl0IHJpZ2h0IGZyb20gdGhlIGJlZ2lubmlu Zy4gIFB1dHRpbmcgdGhlIG51bWJlcg0KPiA+ID4gPiA+ID4gb2YgY2VsbHMgaW4gdGhlIHBoYW5k bGUgdGFyZ2V0IGlzIGEgc3RhbmRhcmQgZGV2aWNlIHRyZWUgaWRpb20uDQo+ID4gPiA+ID4gPg0K PiA+ID4gPiA+IEkgYWdyZWUgd2l0aCB5b3UuIEJ1dCB3aGF0J3MgdGhlIHBvaW50IGEgU09DIGhh cyBtb3JlIHRoYW4gNjQNCj4gPiA+ID4gPiB3YWtldXAgc291cmNlPw0KPiA+ID4gPg0KPiA+ID4g PiBJIGRvbid0IGtub3cuICBIYXJkd2FyZSBwZW9wbGUgZG8gc3RyYW5nZSB0aGluZ3Mgc29tZXRp bWVzLiAgVGhleQ0KPiA+ID4gPiBtaWdodCBub3Qgd2FudCB0byByZXVzZSBiaXRzIHRoZXkgb25j ZSB1c2VkIGZvciBzb21ldGhpbmcgb24gc29tZQ0KPiA+ID4gPiBvdGhlciBjaGlwLCBvciB0aGV5 IG1pZ2h0IGhhdmUgc29tZSBlbmNvZGluZyBzY2hlbWUgaW4gbWluZCB0aGF0DQo+ID4gPiA+IHJl c3VsdHMgaW4gdGhlIGJpdHMgbm90IGJlaW5nIHBhY2tlZCBhcyB0aWdodGx5IGFzIHBvc3NpYmxl LCBvcg0KPiA+ID4gPiB0aGVyZSBtYXkgYmUgc29tZSBiaWcgYXJyYXkgb2Ygc2ltaWxhciBkZXZp Y2VzLi4uDQo+ID4gPiA+DQo+ID4gPiA+IFdoYXQncyB0aGUgcG9pbnQgb2Ygc2tpcHBpbmcgdGhp cyBwYXJ0IG9mIHRoZQ0KPiA+ID4gPiBwaGFuZGxlLXBsdXMtYXJndW1lbnRzIGlkaW9tPw0KPiA+ ID4NCj4gPiA+IEZpbmUsIEkgd2lsbCBhZGQgYSBwcm9wZXJ0eSBpbiByY3BtIG5vZGUgdG8gZGVz Y3JpYmUgdGhlIG51bWJlciBvZg0KPiA+ID4gcmVnaXN0ZXIuDQo+ID4gPg0KPiA+DQo+ID4gSG93 IGFib3V0IHRoZSBmb2xsb3dpbmcgbW9kaWZ5PyBJZiBva2F5IGZvciB5b3UgSSB3aWxsIGZpeCBp biBuZXh0IHZlcnNpb24uDQo+ID4NCj4gPiBSZXF1aXJlZCBwcm9wZXJpdGVzOg0KPiA+ICAgIC0g cmVnIDogT2Zmc2V0IGFuZCBsZW5ndGggb2YgdGhlIHJlZ2lzdGVyIHNldCBvZiBSQ1BNIGJsb2Nr Lg0KPiA+ICsgIC0gZnNsLHJjcG0td2FrZXVwLWNlbGwtbnVtIDogVGhlIG51bWJlciBvZiBjZWxs IGluIHJjcG0td2FrZXVwIHByb3BlcnR5Lg0KPiA+DQo+ID4gICAgICAgICByY3BtOiAgZ2xvYmFs LXV0aWxpdGllc0BlMjAwMHsNCj4gPiAgICAgICAgICAgICAgICAgY29tcGF0aWJsZSA9ICJmc2ws dDQyNDAtcmNwbSIsICJmc2wscW9yaXEtcmNwbS0yLjAiOw0KPiA+ICAgICAgICAgICAgICAgICBy ZWcgPSA8MHhlMjAwMCAweDEwMDA+Ow0KPiA+ICsgICAgICAgICAgICAgICBmc2wscmNwbS13YWtl dXAtY2VsbC1udW0gPSA8Mj47DQo+ID4gICAgICAgICB9Ow0KPiANCj4gT0ssIHRob3VnaCAiZnNs LCNyY3BtLXdha2V1cC1jZWxscyIgd291bGQgYmUgbW9yZSBpZGlvbWF0aWMuDQoNCk9LLCB0aGFu a3MuIFdpbGwgZml4IGl0IGluIG5leHQgdmVyc2lvbi4NCg0KUmVnYXJkcywNCi1Eb25nc2hlbmcN Cg== ^ permalink raw reply [flat|nested] 39+ messages in thread
* RE: [PATCH v2 1/2] fsl: Add binding for RCPM @ 2015-09-16 5:11 ` Wang Dongsheng 0 siblings, 0 replies; 39+ messages in thread From: Wang Dongsheng @ 2015-09-16 5:11 UTC (permalink / raw) To: Scott Wood Cc: devicetree@vger.kernel.org, Zhao C.H., Huan Wang, Yuantian Tang, robh+dt@kernel.org, Jin Jason, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org > -----Original Message----- > From: Wood Scott-B07421 > Sent: Wednesday, September 16, 2015 12:14 PM > To: Wang Dongsheng-B40534 > Cc: Tang Yuantian-B29983; devicetree@vger.kernel.org; linuxppc- > dev@lists.ozlabs.org; robh+dt@kernel.org; linux-arm-kernel@lists.infradead.org; > Wang Huan-B18965; Jin Zhengxiong-R64188; Zhao Chenhui-B35336 > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > On Tue, 2015-09-15 at 22:18 -0500, Wang Dongsheng-B40534 wrote: > > Hi Scott, > > > > > -----Original Message----- > > > From: Wang Dongsheng-B40534 > > > Sent: Wednesday, September 16, 2015 10:44 AM > > > To: Wood Scott-B07421; Tang Yuantian-B29983 > > > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > > > robh+dt@kernel.org; linux-arm-kernel@lists.infradead.org; Wang Huan- > > > B18965; Jin > > > Zhengxiong-R64188; Zhao Chenhui-B35336 > > > Subject: RE: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > > > > > > > > -----Original Message----- > > > > From: Wood Scott-B07421 > > > > Sent: Wednesday, September 16, 2015 10:38 AM > > > > To: Tang Yuantian-B29983 > > > > Cc: Wang Dongsheng-B40534; devicetree@vger.kernel.org; linuxppc- > > > > dev@lists.ozlabs.org; robh+dt@kernel.org; > > > > linux-arm-kernel@lists.infradead.org; > > > > Wang Huan-B18965; Jin Zhengxiong-R64188; Zhao Chenhui-B35336 > > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > > > On Tue, 2015-09-15 at 21:35 -0500, Tang Yuantian-B29983 wrote: > > > > > > > > > > > -----Original Message----- > > > > > > From: Wood Scott-B07421 > > > > > > Sent: Wednesday, September 16, 2015 10:32 AM > > > > > > To: Wang Dongsheng-B40534 <Dongsheng.Wang@freescale.com> > > > > > > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > > > > > > robh+dt@kernel.org; linux-arm-kernel@lists.infradead.org; Wang > > > > > > robh+Huan- > > > > > > B18965 <alison.wang@freescale.com>; Jin Zhengxiong-R64188 > > > > > > <Jason.Jin@freescale.com>; Zhao Chenhui-B35336 > > > > > > <chenhui.zhao@freescale.com>; Tang Yuantian-B29983 > > > > > > <Yuantian.Tang@freescale.com> > > > > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > > > > > > > On Tue, 2015-09-15 at 21:30 -0500, Wang Dongsheng-B40534 wrote: > > > > > > > Hi Scott, > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > From: Wood Scott-B07421 > > > > > > > > Sent: Wednesday, September 16, 2015 10:19 AM > > > > > > > > To: Wang Dongsheng-B40534 > > > > > > > > Cc: devicetree@vger.kernel.org; > > > > > > > > linuxppc-dev@lists.ozlabs.org; > > > > > > > > robh+dt@kernel.org; linux-arm-kernel@lists.infradead.org; > > > > > > > > robh+Wang > > > > > > > > robh+Huan- > > > > > > > > B18965; Jin > > > > > > > > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang > > > > > > > > Yuantian-B29983 > > > > > > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > > > > > > > > > > > On Tue, 2015-09-15 at 21:15 -0500, Wang Dongsheng-B40534 wrote: > > > > > > > > > Hi Scott, > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > > > From: Wood Scott-B07421 > > > > > > > > > > Sent: Wednesday, September 16, 2015 7:57 AM > > > > > > > > > > To: Wang Dongsheng-B40534 > > > > > > > > > > Cc: devicetree@vger.kernel.org; > > > > > > > > > > linuxppc-dev@lists.ozlabs.org; > > > > > > > > > > robh+dt@kernel.org; > > > > > > > > > > robh+linux-arm-kernel@lists.infradead.org; > > > > > > > > > > robh+Wang > > > > > > > > > > robh+Huan- > > > > > > > > > > B18965; Jin > > > > > > > > > > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang > > > > > > > > > > Yuantian-B29983 > > > > > > > > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > > > > > > > > > > > > > > > On Tue, 2015-09-15 at 16:55 +0800, Dongsheng Wang wrote: > > > > > > > > > > > +* Freescale RCPM Wakeup Source Device Tree Bindings > > > > > > > > > > > +------------------------------------------- > > > > > > > > > > > +Required rcpm-wakeup property should be added to a > > > > > > > > > > > +device node if the > > > > > > > > > > > device > > > > > > > > > > > +can be used as a wakeup source. > > > > > > > > > > > + > > > > > > > > > > > + - rcpm-wakeup: The value of the property consists > > > > > > > > > > > + of 3 > > > > > > > > > > > cells. > > > > > > > > > > > + The > > > > > > > > > > > first > > > > > > > > > > > cell > > > > > > > > > > > + is a pointer to the rcpm node, the second cell > > > > > > > > > > > + is the bit mask > > > > > > > > > > > that > > > > > > > > > > > + should be set in IPPDEXPCR0, and the last cell > > > > > > > > > > > + is for > > > > > > > > > > > IPPDEXPCR1. > > > > > > > > > > > + Note: If the platform has no IPPDEXPCR1 > > > > > > > > > > > + register, put a zero > > > > > > > > > > > here. > > > > > > > > > > > > > > > > > > > > What if a future platform has more than two of these > > > > > > > > > > registers? > > > > > > > > > > > > > > > > > > Those registers are only used for wakeup device, we have > > > > > > > > > a lot of available bit for feature. For example, In > > > > > > > > > LS1021a platform only 7bits has used in the registers, > > > > > > > > > and 57bits is > > > reserved. > > > > > > > > > > > > > > > > Still, it'd be better to for the rcpm node to advertise > > > > > > > > the number of cells it expects. > > > > > > > > > > > > > > For the foreseeable future it should be enough to use, even > > > > > > > if not enough to use in the future at that time we can > > > > > > > update the binding. > > > > > > > > > > > > That's the whole point. Device tree is stable ABI. Updating > > > > > > it later to not be fixed to two cells would be a lot harder > > > > > > than getting it right from the beginning. Putting the number > > > > > > of cells in the phandle target is a standard device tree idiom. > > > > > > > > > > > I agree with you. But what's the point a SOC has more than 64 > > > > > wakeup source? > > > > > > > > I don't know. Hardware people do strange things sometimes. They > > > > might not want to reuse bits they once used for something on some > > > > other chip, or they might have some encoding scheme in mind that > > > > results in the bits not being packed as tightly as possible, or > > > > there may be some big array of similar devices... > > > > > > > > What's the point of skipping this part of the > > > > phandle-plus-arguments idiom? > > > > > > Fine, I will add a property in rcpm node to describe the number of > > > register. > > > > > > > How about the following modify? If okay for you I will fix in next version. > > > > Required properites: > > - reg : Offset and length of the register set of RCPM block. > > + - fsl,rcpm-wakeup-cell-num : The number of cell in rcpm-wakeup property. > > > > rcpm: global-utilities@e2000{ > > compatible = "fsl,t4240-rcpm", "fsl,qoriq-rcpm-2.0"; > > reg = <0xe2000 0x1000>; > > + fsl,rcpm-wakeup-cell-num = <2>; > > }; > > OK, though "fsl,#rcpm-wakeup-cells" would be more idiomatic. OK, thanks. Will fix it in next version. Regards, -Dongsheng _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev ^ permalink raw reply [flat|nested] 39+ messages in thread
* [PATCH v2 1/2] fsl: Add binding for RCPM @ 2015-09-16 5:11 ` Wang Dongsheng 0 siblings, 0 replies; 39+ messages in thread From: Wang Dongsheng @ 2015-09-16 5:11 UTC (permalink / raw) To: linux-arm-kernel > -----Original Message----- > From: Wood Scott-B07421 > Sent: Wednesday, September 16, 2015 12:14 PM > To: Wang Dongsheng-B40534 > Cc: Tang Yuantian-B29983; devicetree at vger.kernel.org; linuxppc- > dev at lists.ozlabs.org; robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; > Wang Huan-B18965; Jin Zhengxiong-R64188; Zhao Chenhui-B35336 > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > On Tue, 2015-09-15 at 22:18 -0500, Wang Dongsheng-B40534 wrote: > > Hi Scott, > > > > > -----Original Message----- > > > From: Wang Dongsheng-B40534 > > > Sent: Wednesday, September 16, 2015 10:44 AM > > > To: Wood Scott-B07421; Tang Yuantian-B29983 > > > Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; > > > robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang Huan- > > > B18965; Jin > > > Zhengxiong-R64188; Zhao Chenhui-B35336 > > > Subject: RE: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > > > > > > > > -----Original Message----- > > > > From: Wood Scott-B07421 > > > > Sent: Wednesday, September 16, 2015 10:38 AM > > > > To: Tang Yuantian-B29983 > > > > Cc: Wang Dongsheng-B40534; devicetree at vger.kernel.org; linuxppc- > > > > dev at lists.ozlabs.org; robh+dt at kernel.org; > > > > linux-arm-kernel at lists.infradead.org; > > > > Wang Huan-B18965; Jin Zhengxiong-R64188; Zhao Chenhui-B35336 > > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > > > On Tue, 2015-09-15 at 21:35 -0500, Tang Yuantian-B29983 wrote: > > > > > > > > > > > -----Original Message----- > > > > > > From: Wood Scott-B07421 > > > > > > Sent: Wednesday, September 16, 2015 10:32 AM > > > > > > To: Wang Dongsheng-B40534 <Dongsheng.Wang@freescale.com> > > > > > > Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; > > > > > > robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang > > > > > > robh+Huan- > > > > > > B18965 <alison.wang@freescale.com>; Jin Zhengxiong-R64188 > > > > > > <Jason.Jin@freescale.com>; Zhao Chenhui-B35336 > > > > > > <chenhui.zhao@freescale.com>; Tang Yuantian-B29983 > > > > > > <Yuantian.Tang@freescale.com> > > > > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > > > > > > > On Tue, 2015-09-15 at 21:30 -0500, Wang Dongsheng-B40534 wrote: > > > > > > > Hi Scott, > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > From: Wood Scott-B07421 > > > > > > > > Sent: Wednesday, September 16, 2015 10:19 AM > > > > > > > > To: Wang Dongsheng-B40534 > > > > > > > > Cc: devicetree at vger.kernel.org; > > > > > > > > linuxppc-dev at lists.ozlabs.org; > > > > > > > > robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; > > > > > > > > robh+Wang > > > > > > > > robh+Huan- > > > > > > > > B18965; Jin > > > > > > > > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang > > > > > > > > Yuantian-B29983 > > > > > > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > > > > > > > > > > > On Tue, 2015-09-15 at 21:15 -0500, Wang Dongsheng-B40534 wrote: > > > > > > > > > Hi Scott, > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > > > From: Wood Scott-B07421 > > > > > > > > > > Sent: Wednesday, September 16, 2015 7:57 AM > > > > > > > > > > To: Wang Dongsheng-B40534 > > > > > > > > > > Cc: devicetree at vger.kernel.org; > > > > > > > > > > linuxppc-dev at lists.ozlabs.org; > > > > > > > > > > robh+dt at kernel.org; > > > > > > > > > > robh+linux-arm-kernel at lists.infradead.org; > > > > > > > > > > robh+Wang > > > > > > > > > > robh+Huan- > > > > > > > > > > B18965; Jin > > > > > > > > > > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang > > > > > > > > > > Yuantian-B29983 > > > > > > > > > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > > > > > > > > > > > > > > > > > On Tue, 2015-09-15 at 16:55 +0800, Dongsheng Wang wrote: > > > > > > > > > > > +* Freescale RCPM Wakeup Source Device Tree Bindings > > > > > > > > > > > +------------------------------------------- > > > > > > > > > > > +Required rcpm-wakeup property should be added to a > > > > > > > > > > > +device node if the > > > > > > > > > > > device > > > > > > > > > > > +can be used as a wakeup source. > > > > > > > > > > > + > > > > > > > > > > > + - rcpm-wakeup: The value of the property consists > > > > > > > > > > > + of 3 > > > > > > > > > > > cells. > > > > > > > > > > > + The > > > > > > > > > > > first > > > > > > > > > > > cell > > > > > > > > > > > + is a pointer to the rcpm node, the second cell > > > > > > > > > > > + is the bit mask > > > > > > > > > > > that > > > > > > > > > > > + should be set in IPPDEXPCR0, and the last cell > > > > > > > > > > > + is for > > > > > > > > > > > IPPDEXPCR1. > > > > > > > > > > > + Note: If the platform has no IPPDEXPCR1 > > > > > > > > > > > + register, put a zero > > > > > > > > > > > here. > > > > > > > > > > > > > > > > > > > > What if a future platform has more than two of these > > > > > > > > > > registers? > > > > > > > > > > > > > > > > > > Those registers are only used for wakeup device, we have > > > > > > > > > a lot of available bit for feature. For example, In > > > > > > > > > LS1021a platform only 7bits has used in the registers, > > > > > > > > > and 57bits is > > > reserved. > > > > > > > > > > > > > > > > Still, it'd be better to for the rcpm node to advertise > > > > > > > > the number of cells it expects. > > > > > > > > > > > > > > For the foreseeable future it should be enough to use, even > > > > > > > if not enough to use in the future at that time we can > > > > > > > update the binding. > > > > > > > > > > > > That's the whole point. Device tree is stable ABI. Updating > > > > > > it later to not be fixed to two cells would be a lot harder > > > > > > than getting it right from the beginning. Putting the number > > > > > > of cells in the phandle target is a standard device tree idiom. > > > > > > > > > > > I agree with you. But what's the point a SOC has more than 64 > > > > > wakeup source? > > > > > > > > I don't know. Hardware people do strange things sometimes. They > > > > might not want to reuse bits they once used for something on some > > > > other chip, or they might have some encoding scheme in mind that > > > > results in the bits not being packed as tightly as possible, or > > > > there may be some big array of similar devices... > > > > > > > > What's the point of skipping this part of the > > > > phandle-plus-arguments idiom? > > > > > > Fine, I will add a property in rcpm node to describe the number of > > > register. > > > > > > > How about the following modify? If okay for you I will fix in next version. > > > > Required properites: > > - reg : Offset and length of the register set of RCPM block. > > + - fsl,rcpm-wakeup-cell-num : The number of cell in rcpm-wakeup property. > > > > rcpm: global-utilities at e2000{ > > compatible = "fsl,t4240-rcpm", "fsl,qoriq-rcpm-2.0"; > > reg = <0xe2000 0x1000>; > > + fsl,rcpm-wakeup-cell-num = <2>; > > }; > > OK, though "fsl,#rcpm-wakeup-cells" would be more idiomatic. OK, thanks. Will fix it in next version. Regards, -Dongsheng ^ permalink raw reply [flat|nested] 39+ messages in thread
end of thread, other threads:[~2015-09-16 6:08 UTC | newest] Thread overview: 39+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-09-15 8:55 [PATCH v2 1/2] fsl: Add binding for RCPM Dongsheng Wang 2015-09-15 8:55 ` Dongsheng Wang 2015-09-15 8:55 ` Dongsheng Wang 2015-09-15 8:55 ` [PATCH v2 2/2] arm/layerscape: add RCPM device tree support for ls1021a Dongsheng Wang 2015-09-15 8:55 ` Dongsheng Wang 2015-09-15 8:55 ` Dongsheng Wang 2015-09-15 23:56 ` [PATCH v2 1/2] fsl: Add binding for RCPM Scott Wood 2015-09-15 23:56 ` Scott Wood 2015-09-15 23:56 ` Scott Wood 2015-09-16 2:15 ` Wang Dongsheng 2015-09-16 2:15 ` Wang Dongsheng 2015-09-16 2:15 ` Wang Dongsheng 2015-09-16 2:19 ` Scott Wood 2015-09-16 2:19 ` Scott Wood 2015-09-16 2:19 ` Scott Wood 2015-09-16 2:30 ` Wang Dongsheng 2015-09-16 2:30 ` Wang Dongsheng 2015-09-16 2:30 ` Wang Dongsheng 2015-09-16 2:31 ` Scott Wood 2015-09-16 2:31 ` Scott Wood 2015-09-16 2:31 ` Scott Wood 2015-09-16 2:35 ` Yuantian Tang 2015-09-16 2:35 ` Yuantian Tang 2015-09-16 2:35 ` Yuantian Tang 2015-09-16 2:37 ` Scott Wood 2015-09-16 2:37 ` Scott Wood 2015-09-16 2:37 ` Scott Wood 2015-09-16 2:43 ` Wang Dongsheng 2015-09-16 2:43 ` Wang Dongsheng 2015-09-16 2:43 ` Wang Dongsheng 2015-09-16 3:18 ` Wang Dongsheng 2015-09-16 3:18 ` Wang Dongsheng 2015-09-16 3:18 ` Wang Dongsheng 2015-09-16 4:13 ` Scott Wood 2015-09-16 4:13 ` Scott Wood 2015-09-16 4:13 ` Scott Wood 2015-09-16 5:11 ` Wang Dongsheng 2015-09-16 5:11 ` Wang Dongsheng 2015-09-16 5:11 ` Wang Dongsheng
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.