Re: [OSSTEST PATCH 02/27] Executive: cs-job-create: Check that OSSTEST_FLIGHT is not set

[Ian Campbell <ian.campbell@citrix.com>]

On Wed, 2015-09-16 at 14:35 +0100, Ian Jackson wrote:
> If OSSTEST_FLIGHT is set on entry to JobDB::Executive::flight_create,
> fail.  This obviously represents some kind of mistake.
> 
> One effect is that standalone-generate-dump-flight-runvars won't fill
> an Executive database with test flights.

Speaking from experience there?


> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>

Acked-by: Ian Campbell <ian.campbell@citrix.com>
> ---
>  Osstest/JobDB/Executive.pm |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Osstest/JobDB/Executive.pm b/Osstest/JobDB/Executive.pm
> index cc52f57..6ba3d37 100644
> --- a/Osstest/JobDB/Executive.pm
> +++ b/Osstest/JobDB/Executive.pm
> @@ -89,6 +89,8 @@ END
>  
>  sub flight_create ($$$) { #method
>      my ($jd,$intended,$branch) = @_;
> +    die "OSSTEST_FLIGHT set on entry to
> JobDB::Executive::flight_create\n"
> +	if $ENV{'OSSTEST_FLIGHT'};
>      $dbh_tests->do(<<END, {}, $branch, $intended);
>               INSERT INTO flights
>                           (flight,  started, blessing,       branch,
> intended)