All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Vijay Kilari <vijay.kilari@gmail.com>,
	Julien Grall <julien.grall@citrix.com>,
	Stefano Stabellini <stefano.stabellini@citrix.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: xen/arm: gicv3: Computation of GICD_TYPER.IDbits
Date: Fri, 18 Sep 2015 09:33:50 +0100	[thread overview]
Message-ID: <1442565230.18856.240.camel@citrix.com> (raw)
In-Reply-To: <CALicx6s4Nej2ejduV1j3Xt_Rcgng50jo-19UBpe4QwikJyktYw@mail.gmail.com>

On Fri, 2015-09-18 at 12:56 +0530, Vijay Kilari wrote:
> Hi Julien,
> 
>  static int vgic_v3_distr_mmio_read(struct vcpu *v, mmio_info_t *info)
>  {
>      ...
>            case GICD_TYPER:
>            {
>                /*
>                 * Number of interrupt identifier bits supported by the
> GIC
>                 * Stream Protocol Interface
>                 */
>                unsigned int irq_bits =
> get_count_order(vgic_num_irqs(v->domain));
> }
> 
> I think we should use ilog2() instead of get_count_order()?

Please explain why.

Ian.

  reply	other threads:[~2015-09-18  8:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-18  7:26 xen/arm: gicv3: Computation of GICD_TYPER.IDbits Vijay Kilari
2015-09-18  8:33 ` Ian Campbell [this message]
2015-09-18  9:48   ` Vijay Kilari
2015-09-18 10:21     ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442565230.18856.240.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=julien.grall@citrix.com \
    --cc=stefano.stabellini@citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=vijay.kilari@gmail.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.