From: Gerd Hoffmann <kraxel@redhat.com>
To: "Marc Marí" <markmb@redhat.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, Drew <drjones@redhat.com>,
Kevin O'Connor <kevin@koconnor.net>, Laszlo <lersek@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 5/5] Enable fw_cfg DMA interface for x86
Date: Fri, 18 Sep 2015 12:58:42 +0200 [thread overview]
Message-ID: <1442573922.29362.7.camel@redhat.com> (raw)
In-Reply-To: <1442566729-5133-6-git-send-email-markmb@redhat.com>
Hi,
> - fw_cfg = fw_cfg_init_io(BIOS_CFG_IOPORT);
> + fw_cfg = fw_cfg_init_io_dma(BIOS_CFG_IOPORT, BIOS_CFG_IOPORT + 4, as);
> + as = g_malloc(sizeof(*as));
> + address_space_init(as, ram_below_4g, "pc.as");
> + fw_cfg = bochs_bios_init(as);
I think we can use address_space_memory on x86 too (and can remove the
AddressSpace argument to fw_cfg_init_io_dma).
Otherwise the series looks fine to me (and thanks for picking it up).
cheers,
Gerd
next prev parent reply other threads:[~2015-09-18 10:58 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 8:58 QEMU fw_cfg DMA interface Marc Marí
2015-09-18 8:58 ` [Qemu-devel] " Marc Marí
2015-09-18 8:58 ` Marc Marí
2015-09-18 8:58 ` [Qemu-devel] [PATCH v3 0/5] " Marc Marí
2015-09-18 8:58 ` [Qemu-devel] [PATCH v3 1/5] fw_cfg: document fw_cfg_modify_iXX() update functions Marc Marí
2015-09-18 8:58 ` [Qemu-devel] [PATCH v3 2/5] fw_cfg DMA interface documentation Marc Marí
2015-09-18 15:15 ` Peter Maydell
2015-09-18 8:58 ` [Qemu-devel] [PATCH v3 3/5] Implement fw_cfg DMA interface Marc Marí
2015-09-18 15:31 ` Peter Maydell
2015-09-18 18:29 ` Kevin O'Connor
2015-09-18 8:58 ` [Qemu-devel] [PATCH v3 4/5] Enable fw_cfg DMA interface for ARM Marc Marí
2015-09-18 15:15 ` Peter Maydell
2015-09-18 19:33 ` Laszlo Ersek
2015-09-18 20:16 ` Laszlo Ersek
2015-09-18 20:24 ` Marc Marí
2015-09-18 23:10 ` Laszlo Ersek
2015-09-19 13:09 ` Marc Marí
2015-10-22 21:22 ` Gabriel L. Somlo
2015-10-26 10:48 ` Stefan Hajnoczi
2015-10-26 12:49 ` Gabriel L. Somlo
2015-10-26 13:38 ` Laszlo Ersek
2015-10-26 14:21 ` Gabriel L. Somlo
2015-10-27 11:11 ` Gerd Hoffmann
2015-10-27 12:43 ` Laszlo Ersek
2015-10-28 1:12 ` Gabriel L. Somlo
2015-10-28 10:42 ` Laszlo Ersek
2015-09-18 8:58 ` [Qemu-devel] [PATCH v3 5/5] Enable fw_cfg DMA interface for x86 Marc Marí
2015-09-18 10:58 ` Gerd Hoffmann [this message]
2015-09-18 15:12 ` Peter Maydell
2015-09-18 18:25 ` [Qemu-devel] [PATCH v3 0/5] fw_cfg DMA interface Kevin O'Connor
2015-09-18 19:14 ` Marc Marí
2015-09-18 22:47 ` Peter Maydell
2015-09-18 23:43 ` Kevin O'Connor
2015-09-19 9:48 ` Peter Maydell
2015-09-19 15:15 ` Kevin O'Connor
2015-09-18 8:59 ` [PATCH v3] QEMU fw_cfg DMA interface documentation Marc Marí
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442573922.29362.7.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=drjones@redhat.com \
--cc=kevin@koconnor.net \
--cc=lersek@redhat.com \
--cc=markmb@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.