All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] gdk-pixbuf: remove redundant libx11 DEPENDS line
@ 2015-09-18 11:51 Carlos Rafael Giani
  2015-09-18 11:53 ` Otavio Salvador
  2015-09-18 13:32 ` Richard Purdie
  0 siblings, 2 replies; 4+ messages in thread
From: Carlos Rafael Giani @ 2015-09-18 11:51 UTC (permalink / raw)
  To: openembedded-core

The x11 packageconfig already takes care of the X11 dependency, and also
respects the DISTRO_FEATURES

Signed-off-by: Carlos Rafael Giani <dv@pseudoterminal.org>
---
 meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.30.8.bb | 1 -
 1 file changed, 1 deletion(-)

diff --git a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.30.8.bb b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.30.8.bb
index 07c2dce..bdf173a 100644
--- a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.30.8.bb
+++ b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.30.8.bb
@@ -9,7 +9,6 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=3bf50002aefd002f49e7bb854063f7e7 \
 SECTION = "libs"
 
 DEPENDS = "glib-2.0"
-DEPENDS_append_linuxstdbase = " virtual/libx11"
 
 MAJ_VER = "${@oe.utils.trim_version("${PV}", 2)}"
 
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] gdk-pixbuf: remove redundant libx11 DEPENDS line
  2015-09-18 11:51 [PATCH] gdk-pixbuf: remove redundant libx11 DEPENDS line Carlos Rafael Giani
@ 2015-09-18 11:53 ` Otavio Salvador
  2015-09-18 13:32 ` Richard Purdie
  1 sibling, 0 replies; 4+ messages in thread
From: Otavio Salvador @ 2015-09-18 11:53 UTC (permalink / raw)
  To: Carlos Rafael Giani; +Cc: Patches and discussions about the oe-core layer

On Fri, Sep 18, 2015 at 8:51 AM, Carlos Rafael Giani
<dv@pseudoterminal.org> wrote:
> The x11 packageconfig already takes care of the X11 dependency, and also
> respects the DISTRO_FEATURES
>
> Signed-off-by: Carlos Rafael Giani <dv@pseudoterminal.org>

Acked-by: Otavio Salvador <otavio@ossystems.com.br>

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] gdk-pixbuf: remove redundant libx11 DEPENDS line
  2015-09-18 11:51 [PATCH] gdk-pixbuf: remove redundant libx11 DEPENDS line Carlos Rafael Giani
  2015-09-18 11:53 ` Otavio Salvador
@ 2015-09-18 13:32 ` Richard Purdie
  2015-09-18 13:49   ` Paul Eggleton
  1 sibling, 1 reply; 4+ messages in thread
From: Richard Purdie @ 2015-09-18 13:32 UTC (permalink / raw)
  To: Carlos Rafael Giani; +Cc: openembedded-core

On Fri, 2015-09-18 at 13:51 +0200, Carlos Rafael Giani wrote:
> The x11 packageconfig already takes care of the X11 dependency, and also
> respects the DISTRO_FEATURES
> 
> Signed-off-by: Carlos Rafael Giani <dv@pseudoterminal.org>
> ---
>  meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.30.8.bb | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.30.8.bb b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.30.8.bb
> index 07c2dce..bdf173a 100644
> --- a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.30.8.bb
> +++ b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.30.8.bb
> @@ -9,7 +9,6 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=3bf50002aefd002f49e7bb854063f7e7 \
>  SECTION = "libs"
>  
>  DEPENDS = "glib-2.0"
> -DEPENDS_append_linuxstdbase = " virtual/libx11"

Do we not need something like:

PACKAGECONFIG_append_linuxstdbase = "x11"

to ensure that this is enabled for LSB?

Cheers,

Richard



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] gdk-pixbuf: remove redundant libx11 DEPENDS line
  2015-09-18 13:32 ` Richard Purdie
@ 2015-09-18 13:49   ` Paul Eggleton
  0 siblings, 0 replies; 4+ messages in thread
From: Paul Eggleton @ 2015-09-18 13:49 UTC (permalink / raw)
  To: openembedded-core

Hi Richard,

On Friday 18 September 2015 14:32:13 Richard Purdie wrote:
> On Fri, 2015-09-18 at 13:51 +0200, Carlos Rafael Giani wrote:
> > The x11 packageconfig already takes care of the X11 dependency, and also
> > respects the DISTRO_FEATURES
> > 
> > Signed-off-by: Carlos Rafael Giani <dv@pseudoterminal.org>
> > ---
> > 
> >  meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.30.8.bb | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.30.8.bb
> > b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.30.8.bb index
> > 07c2dce..bdf173a 100644
> > --- a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.30.8.bb
> > +++ b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.30.8.bb
> > @@ -9,7 +9,6 @@ LIC_FILES_CHKSUM =
> > "file://COPYING;md5=3bf50002aefd002f49e7bb854063f7e7 \> 
> >  SECTION = "libs"
> >  
> >  DEPENDS = "glib-2.0"
> > 
> > -DEPENDS_append_linuxstdbase = " virtual/libx11"
> 
> Do we not need something like:
> 
> PACKAGECONFIG_append_linuxstdbase = "x11"
> 
> to ensure that this is enabled for LSB?

The recipe already does something like this further down.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-09-18 13:49 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-18 11:51 [PATCH] gdk-pixbuf: remove redundant libx11 DEPENDS line Carlos Rafael Giani
2015-09-18 11:53 ` Otavio Salvador
2015-09-18 13:32 ` Richard Purdie
2015-09-18 13:49   ` Paul Eggleton

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.