From: Scott Wood <scottwood@freescale.com>
To: Mark Rutland <mark.rutland@arm.com>, <marc.zyngier@arm.com>
Cc: "corbet@lwn.net" <corbet@lwn.net>,
"sboyd@codeaurora.org" <sboyd@codeaurora.org>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"bhupesh.sharma@freescale.com" <bhupesh.sharma@freescale.com>,
Catalin Marinas <Catalin.Marinas@arm.com>,
"mturquette@baylibre.com" <mturquette@baylibre.com>,
Zhiqiang Hou <B48286@freescale.com>,
Will Deacon <Will.Deacon@arm.com>,
"wim@iguana.be" <wim@iguana.be>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"wsa@the-dreams.de" <wsa@the-dreams.de>,
"Mingkai.Hu@freescale.com" <Mingkai.Hu@freescale.com>,
"leoli@freescale.com" <leoli@freescale.com>,
"Wenbin.Song@freescale.com" <Wenbin.Song@freescale.com>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Shaohui.Xie@freescale.com" <Shaohui.Xie@freescale.com>
Subject: Re: [PATCH 4/6] arm64/ls1043a: add DTS for Freescale LS1043A SoC
Date: Mon, 21 Sep 2015 20:30:29 -0500 [thread overview]
Message-ID: <1442885429.19102.210.camel@freescale.com> (raw)
In-Reply-To: <20150922012403.GA1535@svinekod>
On Tue, 2015-09-22 at 02:24 +0100, Mark Rutland wrote:
> > + clockgen: clocking@1ee1000{
> > + compatible = "fsl,ls1043a-clockgen";
> > + reg = <0x0 0x1ee1000 0x0 0x1000>;
> > + #clock-cells = <2>;
> > + clocks = <&sysclk>;
> > + sysclk: sysclk {
> > + compatible = "fixed-clock";
> > + #clock-cells = <0>;
> > + clock-frequency = <100000000>;
> > + clock-output-names = "sysclk";
> > + };
> > + };
>
> Why does this fixed clock live under the clockgen? It should live directly
> under the root node.
I think this is copy-and-paste from some legacy PPC stuff. There's no reason
anymore to put sysclk under clockgen.
-Scott
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: Mark Rutland <mark.rutland@arm.com>, marc.zyngier@arm.com
Cc: "corbet@lwn.net" <corbet@lwn.net>,
"sboyd@codeaurora.org" <sboyd@codeaurora.org>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"bhupesh.sharma@freescale.com" <bhupesh.sharma@freescale.com>,
Catalin Marinas <Catalin.Marinas@arm.com>,
"mturquette@baylibre.com" <mturquette@baylibre.com>,
Zhiqiang Hou <B48286@freescale.com>,
Will Deacon <Will.Deacon@arm.com>,
"wim@iguana.be" <wim@iguana.be>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"wsa@the-dreams.de" <wsa@the-dreams.de>,
"Mingkai.Hu@freescale.com" <Mingkai.Hu@freescale.com>,
"leoli@freescale.com" <leoli@freescale.com>,
"Wenbin.Song@freescale.com" <Wenbin.Song@freescale.com>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Shaohui.Xie@freesc
Subject: Re: [PATCH 4/6] arm64/ls1043a: add DTS for Freescale LS1043A SoC
Date: Mon, 21 Sep 2015 20:30:29 -0500 [thread overview]
Message-ID: <1442885429.19102.210.camel@freescale.com> (raw)
In-Reply-To: <20150922012403.GA1535@svinekod>
On Tue, 2015-09-22 at 02:24 +0100, Mark Rutland wrote:
> > + clockgen: clocking@1ee1000{
> > + compatible = "fsl,ls1043a-clockgen";
> > + reg = <0x0 0x1ee1000 0x0 0x1000>;
> > + #clock-cells = <2>;
> > + clocks = <&sysclk>;
> > + sysclk: sysclk {
> > + compatible = "fixed-clock";
> > + #clock-cells = <0>;
> > + clock-frequency = <100000000>;
> > + clock-output-names = "sysclk";
> > + };
> > + };
>
> Why does this fixed clock live under the clockgen? It should live directly
> under the root node.
I think this is copy-and-paste from some legacy PPC stuff. There's no reason
anymore to put sysclk under clockgen.
-Scott
WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: Mark Rutland <mark.rutland@arm.com>, <marc.zyngier@arm.com>
Cc: Zhiqiang Hou <B48286@freescale.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Catalin Marinas <Catalin.Marinas@arm.com>,
Will Deacon <Will.Deacon@arm.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"Shaohui.Xie@freescale.com" <Shaohui.Xie@freescale.com>,
"corbet@lwn.net" <corbet@lwn.net>,
"bhupesh.sharma@freescale.com" <bhupesh.sharma@freescale.com>,
"mturquette@baylibre.com" <mturquette@baylibre.com>,
"wsa@the-dreams.de" <wsa@the-dreams.de>,
"sboyd@codeaurora.org" <sboyd@codeaurora.org>,
"wim@iguana.be" <wim@iguana.be>,
"Wenbin.Song@freescale.com" <Wenbin.Song@freescale.com>,
"Mingkai.Hu@freescale.com" <Mingkai.Hu@freescale.com>,
"leoli@freescale.com" <leoli@freescale.com>
Subject: Re: [PATCH 4/6] arm64/ls1043a: add DTS for Freescale LS1043A SoC
Date: Mon, 21 Sep 2015 20:30:29 -0500 [thread overview]
Message-ID: <1442885429.19102.210.camel@freescale.com> (raw)
In-Reply-To: <20150922012403.GA1535@svinekod>
On Tue, 2015-09-22 at 02:24 +0100, Mark Rutland wrote:
> > + clockgen: clocking@1ee1000{
> > + compatible = "fsl,ls1043a-clockgen";
> > + reg = <0x0 0x1ee1000 0x0 0x1000>;
> > + #clock-cells = <2>;
> > + clocks = <&sysclk>;
> > + sysclk: sysclk {
> > + compatible = "fixed-clock";
> > + #clock-cells = <0>;
> > + clock-frequency = <100000000>;
> > + clock-output-names = "sysclk";
> > + };
> > + };
>
> Why does this fixed clock live under the clockgen? It should live directly
> under the root node.
I think this is copy-and-paste from some legacy PPC stuff. There's no reason
anymore to put sysclk under clockgen.
-Scott
WARNING: multiple messages have this Message-ID (diff)
From: scottwood@freescale.com (Scott Wood)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/6] arm64/ls1043a: add DTS for Freescale LS1043A SoC
Date: Mon, 21 Sep 2015 20:30:29 -0500 [thread overview]
Message-ID: <1442885429.19102.210.camel@freescale.com> (raw)
In-Reply-To: <20150922012403.GA1535@svinekod>
On Tue, 2015-09-22 at 02:24 +0100, Mark Rutland wrote:
> > + clockgen: clocking at 1ee1000{
> > + compatible = "fsl,ls1043a-clockgen";
> > + reg = <0x0 0x1ee1000 0x0 0x1000>;
> > + #clock-cells = <2>;
> > + clocks = <&sysclk>;
> > + sysclk: sysclk {
> > + compatible = "fixed-clock";
> > + #clock-cells = <0>;
> > + clock-frequency = <100000000>;
> > + clock-output-names = "sysclk";
> > + };
> > + };
>
> Why does this fixed clock live under the clockgen? It should live directly
> under the root node.
I think this is copy-and-paste from some legacy PPC stuff. There's no reason
anymore to put sysclk under clockgen.
-Scott
next prev parent reply other threads:[~2015-09-22 1:30 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-21 12:22 [PATCH 0/6] Add LS1043A SoC support Zhiqiang Hou
2015-09-21 12:22 ` Zhiqiang Hou
2015-09-21 12:22 ` Zhiqiang Hou
2015-09-21 12:22 ` [PATCH 1/6] i2c: Add i2c support to Freescale Layerscape platforms Zhiqiang Hou
2015-09-21 12:22 ` Zhiqiang Hou
2015-09-21 12:22 ` Zhiqiang Hou
2015-09-21 12:22 ` Zhiqiang Hou
2015-09-21 12:22 ` [PATCH 2/6] watchdog: Add support for " Zhiqiang Hou
2015-09-21 12:22 ` Zhiqiang Hou
2015-09-21 12:22 ` Zhiqiang Hou
2015-09-21 12:22 ` Zhiqiang Hou
2015-09-21 15:04 ` Guenter Roeck
2015-09-21 15:04 ` Guenter Roeck
2015-09-21 15:04 ` Guenter Roeck
2015-09-21 12:22 ` [PATCH 3/6] Documentation: DT: Add entry for FSL LS1043ARDB board Zhiqiang Hou
2015-09-21 12:22 ` Zhiqiang Hou
2015-09-21 12:22 ` Zhiqiang Hou
2015-09-21 12:22 ` [PATCH 4/6] arm64/ls1043a: add DTS for Freescale LS1043A SoC Zhiqiang Hou
2015-09-21 12:22 ` Zhiqiang Hou
2015-09-21 12:22 ` Zhiqiang Hou
2015-09-21 12:22 ` Zhiqiang Hou
2015-09-22 1:24 ` Mark Rutland, marc.zyngier
2015-09-22 1:24 ` Mark Rutland
2015-09-22 1:24 ` Mark Rutland, marc.zyngier
2015-09-22 1:30 ` Scott Wood [this message]
2015-09-22 1:30 ` Scott Wood
2015-09-22 1:30 ` Scott Wood
2015-09-22 1:30 ` Scott Wood
2015-09-22 9:50 ` Hou Zhiqiang
2015-09-22 9:50 ` Hou Zhiqiang
2015-09-22 9:50 ` Hou Zhiqiang
2015-09-22 9:50 ` Hou Zhiqiang
2015-09-22 17:23 ` Li Leo
2015-09-22 17:23 ` Li Leo
2015-09-22 17:23 ` Li Leo
2015-09-22 17:23 ` Li Leo
2015-09-22 19:04 ` Sharma Bhupesh
2015-09-22 19:04 ` Sharma Bhupesh
2015-09-22 19:04 ` Sharma Bhupesh
2015-09-23 3:05 ` Hou Zhiqiang
2015-09-23 3:05 ` Hou Zhiqiang
2015-09-23 3:05 ` Hou Zhiqiang
2015-09-23 3:05 ` Hou Zhiqiang
2015-09-23 4:16 ` Li Leo
2015-09-23 4:16 ` Li Leo
2015-09-23 4:16 ` Li Leo
2015-09-22 22:15 ` Mark Rutland
2015-09-22 22:15 ` Mark Rutland
2015-09-22 22:15 ` Mark Rutland
2015-09-22 22:39 ` Li Leo
2015-09-22 22:39 ` Li Leo
2015-09-22 22:39 ` Li Leo
2015-09-22 22:39 ` Li Leo
2015-09-22 22:43 ` Scott Wood
2015-09-22 22:43 ` Scott Wood
2015-09-22 22:43 ` Scott Wood
2015-09-23 3:57 ` Hou Zhiqiang
2015-09-23 3:57 ` Hou Zhiqiang
2015-09-23 3:57 ` Hou Zhiqiang
2015-09-21 12:22 ` [PATCH 5/6] clk: qoriq: Add ls1043a support Zhiqiang Hou
2015-09-21 12:22 ` Zhiqiang Hou
2015-09-21 12:22 ` Zhiqiang Hou
2015-09-21 12:22 ` Zhiqiang Hou
2015-10-01 22:56 ` Stephen Boyd
2015-10-01 22:56 ` Stephen Boyd
2015-09-21 12:22 ` [PATCH 6/6] dts/ls1043a: add LS1043ARDB board support Zhiqiang Hou
2015-09-21 12:22 ` Zhiqiang Hou
2015-09-21 12:22 ` Zhiqiang Hou
2015-09-21 23:13 ` Scott Wood
2015-09-21 23:13 ` Scott Wood
2015-09-21 23:13 ` Scott Wood
2015-09-22 9:51 ` Hou Zhiqiang
2015-09-22 9:51 ` Hou Zhiqiang
2015-09-22 9:51 ` Hou Zhiqiang
2015-09-22 9:51 ` Hou Zhiqiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442885429.19102.210.camel@freescale.com \
--to=scottwood@freescale.com \
--cc=B48286@freescale.com \
--cc=Catalin.Marinas@arm.com \
--cc=Mingkai.Hu@freescale.com \
--cc=Shaohui.Xie@freescale.com \
--cc=Wenbin.Song@freescale.com \
--cc=Will.Deacon@arm.com \
--cc=bhupesh.sharma@freescale.com \
--cc=corbet@lwn.net \
--cc=leoli@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=wim@iguana.be \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.