From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: linux-acpi@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-gpio@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
Wolfram Sang <wsa@the-dreams.de>,
Linus Walleij <linus.walleij@linaro.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Mika Westerberg <mika.westerberg@intel.com>,
"Puustinen, Ismo" <ismo.puustinen@intel.com>,
"Pandruvada, Srinivas" <srinivas.pandruvada@intel.com>,
linux-kernel@vger.kernel.org
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Thierry Reding <thierry.reding@gmail.com>
Subject: [PATCH v1 8/8] pwm-pca9685: enable ACPI device found on Galileo Gen2
Date: Tue, 22 Sep 2015 13:10:19 +0300 [thread overview]
Message-ID: <1442916619-140607-9-git-send-email-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <1442916619-140607-1-git-send-email-andriy.shevchenko@linux.intel.com>
There is a chip connected to i2c bus on Intel Galileo Gen2 board. Enable it via
ACPI ID INT3492.
Cc: Thierry Reding <thierry.reding@gmail.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/pwm/Kconfig | 2 +-
drivers/pwm/pwm-pca9685.c | 14 +++++++++++---
2 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
index 062630a..bb114ef 100644
--- a/drivers/pwm/Kconfig
+++ b/drivers/pwm/Kconfig
@@ -242,7 +242,7 @@ config PWM_MXS
config PWM_PCA9685
tristate "NXP PCA9685 PWM driver"
- depends on OF && I2C
+ depends on I2C
select REGMAP_I2C
help
Generic PWM framework driver for NXP PCA9685 LED controller.
diff --git a/drivers/pwm/pwm-pca9685.c b/drivers/pwm/pwm-pca9685.c
index 70448a6..38ea28b 100644
--- a/drivers/pwm/pwm-pca9685.c
+++ b/drivers/pwm/pwm-pca9685.c
@@ -26,6 +26,8 @@
#include <linux/regmap.h>
#include <linux/slab.h>
#include <linux/delay.h>
+#include <linux/acpi.h>
+#include <linux/property.h>
/*
* Because the PCA9685 has only one prescaler per chip, changing the period of
@@ -297,7 +299,6 @@ static const struct regmap_config pca9685_regmap_i2c_config = {
static int pca9685_pwm_probe(struct i2c_client *client,
const struct i2c_device_id *id)
{
- struct device_node *np = client->dev.of_node;
struct pca9685 *pca;
int ret;
int mode2;
@@ -320,12 +321,12 @@ static int pca9685_pwm_probe(struct i2c_client *client,
regmap_read(pca->regmap, PCA9685_MODE2, &mode2);
- if (of_property_read_bool(np, "invert"))
+ if (device_property_read_bool(&client->dev, "invert"))
mode2 |= MODE2_INVRT;
else
mode2 &= ~MODE2_INVRT;
- if (of_property_read_bool(np, "open-drain"))
+ if (device_property_read_bool(&client->dev, "open-drain"))
mode2 &= ~MODE2_OUTDRV;
else
mode2 |= MODE2_OUTDRV;
@@ -363,6 +364,12 @@ static const struct i2c_device_id pca9685_id[] = {
};
MODULE_DEVICE_TABLE(i2c, pca9685_id);
+static const struct acpi_device_id pca9685_acpi_ids[] = {
+ { "INT3492", 0 },
+ { /* sentinel */ },
+};
+MODULE_DEVICE_TABLE(acpi, pca9685_acpi_ids);
+
static const struct of_device_id pca9685_dt_ids[] = {
{ .compatible = "nxp,pca9685-pwm", },
{ /* sentinel */ }
@@ -372,6 +379,7 @@ MODULE_DEVICE_TABLE(of, pca9685_dt_ids);
static struct i2c_driver pca9685_i2c_driver = {
.driver = {
.name = "pca9685-pwm",
+ .acpi_match_table = ACPI_PTR(pca9685_acpi_ids),
.of_match_table = pca9685_dt_ids,
},
.probe = pca9685_pwm_probe,
--
2.5.1
next prev parent reply other threads:[~2015-09-22 10:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 10:10 [PATCH v1 0/8] enable I2C devices behind I2C bus on Gen2 Andy Shevchenko
2015-09-22 10:10 ` [PATCH v1 1/8] i2c / ACPI: Rework I2C device scanning Andy Shevchenko
2015-09-22 10:10 ` [PATCH v1 2/8] mfd: core: redo ACPI matching of the children devices Andy Shevchenko
2015-09-22 22:15 ` Lee Jones
2015-09-23 11:06 ` Andy Shevchenko
2015-09-22 10:10 ` [PATCH v1 3/8] mfd: intel_quark_i2c_gpio: load gpio driver first Andy Shevchenko
2015-09-22 22:23 ` Lee Jones
2015-09-22 22:23 ` Lee Jones
2015-09-23 7:53 ` Andy Shevchenko
2015-09-24 17:29 ` Lee Jones
2015-09-24 17:29 ` Lee Jones
2015-09-22 10:10 ` [PATCH v1 4/8] mfd: intel_quark_i2c_gpio: support devices behind i2c bus Andy Shevchenko
2015-09-22 22:25 ` Lee Jones
2015-09-22 10:10 ` [PATCH v1 5/8] gpio: pca953x: store driver_data for future use Andy Shevchenko
2015-10-02 10:53 ` Linus Walleij
2015-10-02 12:16 ` Andy Shevchenko
2015-09-22 10:10 ` [PATCH v1 6/8] gpio: pca953x: support ACPI devices found on Galileo Gen2 Andy Shevchenko
2015-10-02 10:54 ` Linus Walleij
2015-09-22 10:10 ` [PATCH v1 7/8] at24: enable ACPI device " Andy Shevchenko
2015-09-22 10:10 ` Andy Shevchenko [this message]
2015-09-22 14:37 ` [PATCH v1 8/8] pwm-pca9685: " Thierry Reding
2015-09-23 8:41 ` Andy Shevchenko
2015-09-23 12:48 ` Thierry Reding
2015-09-23 12:56 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442916619-140607-9-git-send-email-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=ismo.puustinen@intel.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@intel.com \
--cc=rjw@rjwysocki.net \
--cc=srinivas.pandruvada@intel.com \
--cc=thierry.reding@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.