From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: linux-acpi@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-gpio@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
Wolfram Sang <wsa@the-dreams.de>,
Linus Walleij <linus.walleij@linaro.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Mika Westerberg <mika.westerberg@intel.com>,
"Puustinen, Ismo" <ismo.puustinen@intel.com>,
"Pandruvada, Srinivas" <srinivas.pandruvada@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 8/8] pwm-pca9685: enable ACPI device found on Galileo Gen2
Date: Wed, 23 Sep 2015 15:56:52 +0300 [thread overview]
Message-ID: <1443013012.8361.172.camel@linux.intel.com> (raw)
In-Reply-To: <20150923124800.GA11187@ulmo.nvidia.com>
On Wed, 2015-09-23 at 14:48 +0200, Thierry Reding wrote:
> > > >
> On Wed, Sep 23, 2015 at 11:41:26AM +0300, Andy Shevchenko wrote:
> > On Tue, 2015-09-22 at 16:37 +0200, Thierry Reding wrote:
> > > On Tue, Sep 22, 2015 at 01:10:19PM +0300, Andy Shevchenko wrote:
> >
> > >
> > > > .of_match_table = pca9685_dt_ids,
> > >
> > > Similarly to the above, this should use of_match_ptr(), which in
> > > turn
> > > will require #ifdef protection for the table to avoid warnings.
> >
> > Hmm... my patch do not touches that part. Perhaps another patch for
> > this?
>
> Your patch does touch that part by removing the dependency on OF.
> That
> makes it possible to build this code with !OF, which in turn would
> make
> the OF match table unused.
Ah, you're right. Will amend this part as well.
Thanks!
>
> Thierry
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
prev parent reply other threads:[~2015-09-23 12:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 10:10 [PATCH v1 0/8] enable I2C devices behind I2C bus on Gen2 Andy Shevchenko
2015-09-22 10:10 ` [PATCH v1 1/8] i2c / ACPI: Rework I2C device scanning Andy Shevchenko
2015-09-22 10:10 ` [PATCH v1 2/8] mfd: core: redo ACPI matching of the children devices Andy Shevchenko
2015-09-22 22:15 ` Lee Jones
2015-09-23 11:06 ` Andy Shevchenko
2015-09-22 10:10 ` [PATCH v1 3/8] mfd: intel_quark_i2c_gpio: load gpio driver first Andy Shevchenko
2015-09-22 22:23 ` Lee Jones
2015-09-22 22:23 ` Lee Jones
2015-09-23 7:53 ` Andy Shevchenko
2015-09-24 17:29 ` Lee Jones
2015-09-24 17:29 ` Lee Jones
2015-09-22 10:10 ` [PATCH v1 4/8] mfd: intel_quark_i2c_gpio: support devices behind i2c bus Andy Shevchenko
2015-09-22 22:25 ` Lee Jones
2015-09-22 10:10 ` [PATCH v1 5/8] gpio: pca953x: store driver_data for future use Andy Shevchenko
2015-10-02 10:53 ` Linus Walleij
2015-10-02 12:16 ` Andy Shevchenko
2015-09-22 10:10 ` [PATCH v1 6/8] gpio: pca953x: support ACPI devices found on Galileo Gen2 Andy Shevchenko
2015-10-02 10:54 ` Linus Walleij
2015-09-22 10:10 ` [PATCH v1 7/8] at24: enable ACPI device " Andy Shevchenko
2015-09-22 10:10 ` [PATCH v1 8/8] pwm-pca9685: " Andy Shevchenko
2015-09-22 14:37 ` Thierry Reding
2015-09-23 8:41 ` Andy Shevchenko
2015-09-23 12:48 ` Thierry Reding
2015-09-23 12:56 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443013012.8361.172.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=ismo.puustinen@intel.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@intel.com \
--cc=rjw@rjwysocki.net \
--cc=srinivas.pandruvada@intel.com \
--cc=thierry.reding@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.