All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Dave Airlie <airlied@redhat.com>,
	open list <linux-kernel@vger.kernel.org>,
	"open list:VIRTIO GPU DRIVER" <dri-devel@lists.freedesktop.org>,
	"open list:VIRTIO GPU DRIVER"
	<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH v2 5/6] virtio-gpu: add basic prime support
Date: Tue, 22 Sep 2015 17:24:29 +0200	[thread overview]
Message-ID: <1442935469.13084.36.camel@redhat.com> (raw)
In-Reply-To: <20150922094027.GF3383@phenom.ffwll.local>

> > +int virtgpu_gem_prime_mmap(struct drm_gem_object *obj,
> > +		       struct vm_area_struct *area)
> > +{
> > +	WARN_ONCE(1, "not implemented");
> > +	return ENOSYS;
> 
> This can get called by userspace, so please don't WARN here. Also missing
> negate sign:
> 
> 	return -ENOSYS;

Hmm now checkpatch throws a warning at me:

<quote>
   WARNING: ENOSYS means 'invalid syscall nr' and nothing else
   #12: FILE: drivers/gpu/drm/virtio/virtgpu_prime.c:70:
   +       return -ENOSYS;
</quote>

I guess I should use something else then (here and elsewhere in the
file)?  Maybe -EINVAL?  Other suggestions?

thanks,
  Gerd


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Gerd Hoffmann <kraxel@redhat.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel <dri-devel@lists.freedesktop.org>,
	open list <linux-kernel@vger.kernel.org>,
	"open list:VIRTIO GPU DRIVER" <dri-devel@lists.freedesktop.org>,
	"open list:VIRTIO GPU DRIVER" 
	<virtualization@lists.linux-foundation.org>,
	Dave Airlie <airlied@redhat.com>
Subject: Re: [PATCH v2 5/6] virtio-gpu: add basic prime support
Date: Tue, 22 Sep 2015 17:24:29 +0200	[thread overview]
Message-ID: <1442935469.13084.36.camel@redhat.com> (raw)
In-Reply-To: <20150922094027.GF3383@phenom.ffwll.local>

> > +int virtgpu_gem_prime_mmap(struct drm_gem_object *obj,
> > +		       struct vm_area_struct *area)
> > +{
> > +	WARN_ONCE(1, "not implemented");
> > +	return ENOSYS;
> 
> This can get called by userspace, so please don't WARN here. Also missing
> negate sign:
> 
> 	return -ENOSYS;

Hmm now checkpatch throws a warning at me:

<quote>
   WARNING: ENOSYS means 'invalid syscall nr' and nothing else
   #12: FILE: drivers/gpu/drm/virtio/virtgpu_prime.c:70:
   +       return -ENOSYS;
</quote>

I guess I should use something else then (here and elsewhere in the
file)?  Maybe -EINVAL?  Other suggestions?

thanks,
  Gerd



  parent reply	other threads:[~2015-09-22 15:24 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1442828417-6165-1-git-send-email-kraxel@redhat.com>
2015-09-21  9:40 ` [PATCH v2 1/6] virtio-gpu: add virtio_gpu_queue_ctrl_buffer_locked Gerd Hoffmann
2015-09-21  9:40   ` Gerd Hoffmann
2015-09-21  9:40 ` Gerd Hoffmann
2015-09-21  9:40 ` [PATCH v2 2/6] virtio-gpu: add & use virtio_gpu_queue_fenced_ctrl_buffer Gerd Hoffmann
2015-09-21  9:40   ` Gerd Hoffmann
2015-09-21  9:40 ` Gerd Hoffmann
2015-09-21  9:40 ` [PATCH v2 3/6] virtio-gpu: wait for cursor updates finish Gerd Hoffmann
2015-09-21  9:40 ` Gerd Hoffmann
2015-09-21  9:40   ` Gerd Hoffmann
2015-09-21  9:40 ` [PATCH v2 4/6] virtio-gpu: add 3d/virgl support Gerd Hoffmann
2015-09-21  9:40   ` Gerd Hoffmann
     [not found]   ` <1442828417-6165-5-git-send-email-kraxel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-21 10:15     ` Michael S. Tsirkin
2015-09-21 10:15       ` Michael S. Tsirkin
2015-09-22 15:18       ` Gerd Hoffmann
2015-09-22 15:18       ` Gerd Hoffmann
2015-09-22 15:18         ` Gerd Hoffmann
2015-09-21 10:15   ` Michael S. Tsirkin
2015-09-21  9:40 ` Gerd Hoffmann
2015-09-21  9:40 ` [PATCH v2 5/6] virtio-gpu: add basic prime support Gerd Hoffmann
2015-09-21  9:40 ` Gerd Hoffmann
2015-09-21  9:40   ` Gerd Hoffmann
2015-09-22  9:40   ` Daniel Vetter
2015-09-22  9:40     ` Daniel Vetter
2015-09-22 15:24     ` Gerd Hoffmann
2015-09-22 15:24     ` Gerd Hoffmann [this message]
2015-09-22 15:24       ` Gerd Hoffmann
2015-09-22 16:15       ` Daniel Vetter
2015-09-22 16:15         ` Daniel Vetter
2015-09-22  9:40   ` Daniel Vetter
2015-09-21  9:40 ` [PATCH v2 6/6] virtio-gpu: mark as a render gpu Gerd Hoffmann
2015-09-21  9:40   ` Gerd Hoffmann
2015-09-21  9:40 ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442935469.13084.36.camel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=airlied@redhat.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.