All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Daney <ddaney.cavm@gmail.com>
To: linux-kernel@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
	linux-pci@vger.kernel.org, Will Deacon <will.deacon@arm.com>,
	Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	Marc Zyngier <marc.zyngier@arm.com>
Cc: David Daney <david.daney@cavium.com>
Subject: [PATCH v3 5/6] PCI: generic: Pass proper starting bus number to pci_scan_root_bus().
Date: Tue, 22 Sep 2015 16:49:16 -0700	[thread overview]
Message-ID: <1442965757-12925-6-git-send-email-ddaney.cavm@gmail.com> (raw)
In-Reply-To: <1442965757-12925-1-git-send-email-ddaney.cavm@gmail.com>

From: David Daney <david.daney@cavium.com>

If the bus is being configured with a bus-range that does not start at
zero, pass that starting bus number to pci_scan_root_bus().  Passing
the incorrect value of zero causes attempted config accesses outside
of the supported range, which cascades to an OOPs spew and eventual
kernel panic.

Acked-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: David Daney <david.daney@cavium.com>
---
No change from v1 or v2.

 drivers/pci/host/pci-host-generic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/host/pci-host-generic.c b/drivers/pci/host/pci-host-generic.c
index 0a9c453..e364232 100644
--- a/drivers/pci/host/pci-host-generic.c
+++ b/drivers/pci/host/pci-host-generic.c
@@ -259,7 +259,7 @@ static int gen_pci_probe(struct platform_device *pdev)
 	if (!pci_has_flag(PCI_PROBE_ONLY))
 		pci_add_flags(PCI_REASSIGN_ALL_RSRC | PCI_REASSIGN_ALL_BUS);
 
-	bus = pci_scan_root_bus(dev, 0,
+	bus = pci_scan_root_bus(dev, pci->cfg.bus_range->start,
 				&pci->cfg.ops.ops, pci, &pci->resources);
 	if (!bus) {
 		dev_err(dev, "Scanning rootbus failed");
-- 
1.9.1


WARNING: multiple messages have this Message-ID (diff)
From: ddaney.cavm@gmail.com (David Daney)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 5/6] PCI: generic: Pass proper starting bus number to pci_scan_root_bus().
Date: Tue, 22 Sep 2015 16:49:16 -0700	[thread overview]
Message-ID: <1442965757-12925-6-git-send-email-ddaney.cavm@gmail.com> (raw)
In-Reply-To: <1442965757-12925-1-git-send-email-ddaney.cavm@gmail.com>

From: David Daney <david.daney@cavium.com>

If the bus is being configured with a bus-range that does not start at
zero, pass that starting bus number to pci_scan_root_bus().  Passing
the incorrect value of zero causes attempted config accesses outside
of the supported range, which cascades to an OOPs spew and eventual
kernel panic.

Acked-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: David Daney <david.daney@cavium.com>
---
No change from v1 or v2.

 drivers/pci/host/pci-host-generic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/host/pci-host-generic.c b/drivers/pci/host/pci-host-generic.c
index 0a9c453..e364232 100644
--- a/drivers/pci/host/pci-host-generic.c
+++ b/drivers/pci/host/pci-host-generic.c
@@ -259,7 +259,7 @@ static int gen_pci_probe(struct platform_device *pdev)
 	if (!pci_has_flag(PCI_PROBE_ONLY))
 		pci_add_flags(PCI_REASSIGN_ALL_RSRC | PCI_REASSIGN_ALL_BUS);
 
-	bus = pci_scan_root_bus(dev, 0,
+	bus = pci_scan_root_bus(dev, pci->cfg.bus_range->start,
 				&pci->cfg.ops.ops, pci, &pci->resources);
 	if (!bus) {
 		dev_err(dev, "Scanning rootbus failed");
-- 
1.9.1

  parent reply	other threads:[~2015-09-22 23:49 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-22 23:49 [PATCH v3 0/6] PCI: generic: Misc. bug fixes/enhancements David Daney
2015-09-22 23:49 ` David Daney
2015-09-22 23:49 ` David Daney
2015-09-22 23:49 ` [PATCH v3 1/6] PCI: Add pci_bus_fixup_irqs() David Daney
2015-09-22 23:49   ` David Daney
2015-09-22 23:49 ` [PATCH v3 2/6] PCI: generic: Only fixup irqs for bus we are creating David Daney
2015-09-22 23:49   ` David Daney
2015-09-22 23:49 ` [PATCH v3 3/6] PCI: generic: Quit clobbering our pci_ops David Daney
2015-09-22 23:49   ` David Daney
2015-09-23  8:21   ` Arnd Bergmann
2015-09-23  8:21     ` Arnd Bergmann
2015-09-23 15:56     ` David Daney
2015-09-23 15:56       ` David Daney
2015-09-23 15:56       ` David Daney
2015-09-22 23:49 ` [PATCH v3 4/6] PCI: generic: Correct, and avoid overflow, in bus_max calculation David Daney
2015-09-22 23:49   ` David Daney
2015-09-23  8:01   ` Arnd Bergmann
2015-09-23  8:01     ` Arnd Bergmann
2015-09-23 15:50     ` David Daney
2015-09-23 15:50       ` David Daney
2015-09-23 15:50       ` David Daney
2015-09-23 19:35       ` Arnd Bergmann
2015-09-23 19:35         ` Arnd Bergmann
2015-09-23 19:35         ` Arnd Bergmann
2015-09-22 23:49 ` David Daney [this message]
2015-09-22 23:49   ` [PATCH v3 5/6] PCI: generic: Pass proper starting bus number to pci_scan_root_bus() David Daney
2015-09-22 23:49 ` [PATCH v3 6/6] PCI: generic: Claim device resources if PCI_PROBE_ONLY David Daney
2015-09-22 23:49   ` David Daney
2015-09-23  8:02 ` [PATCH v3 0/6] PCI: generic: Misc. bug fixes/enhancements Arnd Bergmann
2015-09-23  8:02   ` Arnd Bergmann
2015-09-23  8:02   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442965757-12925-6-git-send-email-ddaney.cavm@gmail.com \
    --to=ddaney.cavm@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=david.daney@cavium.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.