From: Ian Campbell <ian.campbell@citrix.com>
To: Jan Beulich <JBeulich@suse.com>, He Chen <he.chen@linux.intel.com>
Cc: wei.liu2@citrix.com, stefano.stabellini@eu.citrix.com,
andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com,
xen-devel@lists.xenproject.org, chao.p.peng@linux.intel.com,
keir@xen.org
Subject: Re: [PATCH v4 3/4] tools: add tools support for Intel CDP
Date: Thu, 24 Sep 2015 13:31:08 +0100 [thread overview]
Message-ID: <1443097868.25250.8.camel@citrix.com> (raw)
In-Reply-To: <5604069402000078000A54D1@prv-mh.provo.novell.com>
On Thu, 2015-09-24 at 06:20 -0600, Jan Beulich wrote:
> > > > On 24.09.15 at 14:07, <ian.campbell@citrix.com> wrote:
> > On Thu, 2015-09-24 at 05:50 -0600, Jan Beulich wrote:
> > > a specific error type
> > > to me seems to go too far. Surely out of the several dozen
> > > possibilities a handful of not-so-common ones can be picked?
> >
> > I was thinking in particular EINVAL was not in the not-so-common
> > bracket.
>
> Which I fully agree with.
>
> > The current code already uses 9 values FWIW.
>
> Right, but ENXIO would e.g. seem to be a reasonable fit for
> "Unable to set code or data CBM when CDP is disabled".
That would be better yes (sorry I didn't check if this came up in the
review of the hypervisor side)
Ian.
next prev parent reply other threads:[~2015-09-24 12:31 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 9:35 [PATCH v4 0/4] detect and initialize CDP (Code/Data Prioritization) feature He Chen
2015-09-17 9:35 ` [PATCH v4 1/4] x86: Support enable CDP by boot parameter and add get CDP status He Chen
2015-09-17 10:20 ` Andrew Cooper
2015-09-24 15:57 ` Jan Beulich
2015-09-17 9:35 ` [PATCH v4 2/4] x86: add domctl cmd to set/get CDP code/data CBM He Chen
2015-09-17 10:25 ` Andrew Cooper
2015-09-17 9:35 ` [PATCH v4 3/4] tools: add tools support for Intel CDP He Chen
2015-09-17 10:38 ` Andrew Cooper
2015-09-24 10:56 ` Ian Campbell
2015-09-24 10:57 ` Ian Campbell
2015-09-24 11:12 ` Andrew Cooper
2015-09-24 11:00 ` Ian Campbell
2015-09-24 11:50 ` Jan Beulich
2015-09-24 12:07 ` Ian Campbell
2015-09-24 12:20 ` Jan Beulich
2015-09-24 12:31 ` Ian Campbell [this message]
2015-09-24 11:07 ` Ian Campbell
2015-09-24 11:22 ` Ian Campbell
2015-09-25 9:04 ` He Chen
2015-09-25 9:19 ` Ian Campbell
2015-09-25 8:43 ` He Chen
2015-09-25 9:18 ` Ian Campbell
2015-09-25 9:53 ` He Chen
2015-09-25 10:30 ` Ian Campbell
2015-09-17 9:35 ` [PATCH v4 4/4] docs: add document to introduce CDP command He Chen
2015-09-24 11:22 ` Ian Campbell
2015-09-24 11:53 ` Jan Beulich
2015-09-25 9:29 ` He Chen
2015-09-25 9:58 ` Ian Campbell
2015-09-25 10:16 ` He Chen
2015-09-25 10:38 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443097868.25250.8.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=chao.p.peng@linux.intel.com \
--cc=he.chen@linux.intel.com \
--cc=ian.jackson@eu.citrix.com \
--cc=keir@xen.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.