All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Ian Campbell <ian.campbell@citrix.com>,
	He Chen <he.chen@linux.intel.com>,
	xen-devel@lists.xenproject.org
Cc: wei.liu2@citrix.com, stefano.stabellini@eu.citrix.com,
	ian.jackson@eu.citrix.com, jbeulich@suse.com,
	chao.p.peng@linux.intel.com, keir@xen.org
Subject: Re: [PATCH v4 3/4] tools: add tools support for Intel CDP
Date: Thu, 24 Sep 2015 12:12:58 +0100	[thread overview]
Message-ID: <5603DABA.6050603@citrix.com> (raw)
In-Reply-To: <1443092267.10338.273.camel@citrix.com>

On 24/09/15 11:57, Ian Campbell wrote:
> On Thu, 2015-09-17 at 11:38 +0100, Andrew Cooper wrote:
>> @@ -320,6 +333,8 @@ int xc_psr_cat_get_l3_info(xc_interface *xch,
>>> uint32_t socket,
>>>       {
>>>           *cos_max = sysctl.u.psr_cat_op.u.l3_info.cos_max;
>>>           *cbm_len = sysctl.u.psr_cat_op.u.l3_info.cbm_len;
>>> +        *cdp_enabled = sysctl.u.psr_cat_op.u.l3_info.flags &
>>> +                       XEN_SYSCTL_PSR_CAT_L3_CDP;
>> !!(sysctl.u.psr_cat_op.u.l3_info.flags & XEN_SYSCTL_PSR_CAT_L3_CDP);
>>
>> To turn it into a proper boolean, rather than a just a non-zero integer.
> Given that *cdp_endabled is bool type does this not happen automagically?
>

Hmm - spec says yes.  Any assignment of a non-zero integer to a _Bool is 
will be converted to a 1.

~Andrew

  reply	other threads:[~2015-09-24 11:13 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-17  9:35 [PATCH v4 0/4] detect and initialize CDP (Code/Data Prioritization) feature He Chen
2015-09-17  9:35 ` [PATCH v4 1/4] x86: Support enable CDP by boot parameter and add get CDP status He Chen
2015-09-17 10:20   ` Andrew Cooper
2015-09-24 15:57   ` Jan Beulich
2015-09-17  9:35 ` [PATCH v4 2/4] x86: add domctl cmd to set/get CDP code/data CBM He Chen
2015-09-17 10:25   ` Andrew Cooper
2015-09-17  9:35 ` [PATCH v4 3/4] tools: add tools support for Intel CDP He Chen
2015-09-17 10:38   ` Andrew Cooper
2015-09-24 10:56     ` Ian Campbell
2015-09-24 10:57     ` Ian Campbell
2015-09-24 11:12       ` Andrew Cooper [this message]
2015-09-24 11:00   ` Ian Campbell
2015-09-24 11:50     ` Jan Beulich
2015-09-24 12:07       ` Ian Campbell
2015-09-24 12:20         ` Jan Beulich
2015-09-24 12:31           ` Ian Campbell
2015-09-24 11:07   ` Ian Campbell
2015-09-24 11:22     ` Ian Campbell
2015-09-25  9:04       ` He Chen
2015-09-25  9:19         ` Ian Campbell
2015-09-25  8:43     ` He Chen
2015-09-25  9:18       ` Ian Campbell
2015-09-25  9:53         ` He Chen
2015-09-25 10:30           ` Ian Campbell
2015-09-17  9:35 ` [PATCH v4 4/4] docs: add document to introduce CDP command He Chen
2015-09-24 11:22   ` Ian Campbell
2015-09-24 11:53     ` Jan Beulich
2015-09-25  9:29     ` He Chen
2015-09-25  9:58       ` Ian Campbell
2015-09-25 10:16         ` He Chen
2015-09-25 10:38           ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5603DABA.6050603@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=chao.p.peng@linux.intel.com \
    --cc=he.chen@linux.intel.com \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=keir@xen.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.