From: Gerd Hoffmann <kraxel@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "David Airlie" <airlied@linux.ie>,
"Marc-André Lureau" <marcandre.lureau@gmail.com>,
qemu-devel@nongnu.org, "Max Reitz" <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 04/11] virtio-gpu: move iov free to virtio_gpu_cleanup_mapping_iov
Date: Fri, 25 Sep 2015 15:14:59 +0200 [thread overview]
Message-ID: <1443186899.1789.4.camel@redhat.com> (raw)
In-Reply-To: <20150924131554-mutt-send-email-mst@redhat.com>
On Do, 2015-09-24 at 13:16 +0300, Michael S. Tsirkin wrote:
> On Thu, Sep 24, 2015 at 11:04:55AM +0200, Gerd Hoffmann wrote:
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>
> It's easy to see this is what the patch does. But why? Some
> explanation in the commit log about why it's done, as opposed to what is
> done, would be better.
It's for symmetry reasons: virtio_gpu_create_mapping_iov() allocates it
so virtio_gpu_cleanup_mapping_iov() should free it, otherwise it's easy
to miss a free() needed and leak memory.
cheers,
Gerd
next prev parent reply other threads:[~2015-09-25 13:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-24 9:04 [Qemu-devel] [PATCH v2 00/11] add virgl rendering support Gerd Hoffmann
2015-09-24 9:04 ` [Qemu-devel] [PATCH v2 01/11] shaders: initialize vertexes once Gerd Hoffmann
2015-09-28 15:32 ` Max Reitz
2015-09-24 9:04 ` [Qemu-devel] [PATCH v2 02/11] sdl2: stop flickering Gerd Hoffmann
2015-09-24 9:04 ` [Qemu-devel] [PATCH v2 03/11] ui/console: add opengl context and scanout support interfaces Gerd Hoffmann
2015-09-24 9:04 ` [Qemu-devel] [PATCH v2 04/11] virtio-gpu: move iov free to virtio_gpu_cleanup_mapping_iov Gerd Hoffmann
2015-09-24 10:16 ` Michael S. Tsirkin
2015-09-25 13:14 ` Gerd Hoffmann [this message]
2015-09-29 13:13 ` Michael S. Tsirkin
2015-09-28 15:46 ` Max Reitz
2015-09-24 9:04 ` [Qemu-devel] [PATCH v2 05/11] virtio-gpu: change licence from GPLv2 to GPLv2+ Gerd Hoffmann
2015-09-28 15:57 ` Max Reitz
2015-09-24 9:04 ` [Qemu-devel] [PATCH v2 06/11] virtio-gpu: update headers for virgl/3d Gerd Hoffmann
2015-09-24 9:04 ` [Qemu-devel] [PATCH v2 07/11] virtio-gpu: add 3d mode and virgl rendering support Gerd Hoffmann
2015-09-28 16:00 ` Max Reitz
2015-09-24 9:04 ` [Qemu-devel] [PATCH v2 08/11] sdl2/opengl: add opengl context and scanout support Gerd Hoffmann
2015-09-28 16:03 ` Max Reitz
2015-09-24 9:05 ` [Qemu-devel] [PATCH v2 09/11] opengl: add egl-context.[ch] helpers Gerd Hoffmann
2015-09-24 9:05 ` [Qemu-devel] [PATCH v2 10/11] gtk/opengl: add opengl context and scanout support (egl) Gerd Hoffmann
2015-09-24 9:05 ` [Qemu-devel] [PATCH v2 11/11] gtk/opengl: add opengl context and scanout support (GtkGLArea) Gerd Hoffmann
2015-09-24 17:09 ` [Qemu-devel] [PATCH v2 00/11] add virgl rendering support Marc-André Lureau
2015-09-25 13:30 ` Gerd Hoffmann
2015-09-28 16:07 ` Max Reitz
2015-09-29 12:46 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443186899.1789.4.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=airlied@linux.ie \
--cc=marcandre.lureau@gmail.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.