All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
To: Viresh Kumar
	<viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Greg Kroah-Hartman
	<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
Cc: alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
	linaro-kernel-cunTk1MwBs8s++Sfvej+rw@public.gmane.org,
	linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	QCA ath9k Development
	<ath9k-devel-A+ZNKFmMK5xy9aJCnZT0Uw@public.gmane.org>,
	Intel Linux Wireless
	<ilw-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-edac-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'
Date: Fri, 25 Sep 2015 19:42:25 +0200	[thread overview]
Message-ID: <1443202945.2161.8.camel@sipsolutions.net> (raw)
In-Reply-To: <e28c4b4deaf766910c366ab87b64325da59c8ad6.1443198783.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> (sfid-20150925_184230_610012_AD3DF607)

On Fri, 2015-09-25 at 09:41 -0700, Viresh Kumar wrote:

> Signed-off-by: Viresh Kumar <viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> ---
> V3->V4:
> - Create a local variable instead of changing type of global_lock
>   (Rafael)

Err, surely that wasn't what Rafael meant, since it's clearly
impossible to use a pointer to the stack, assign to it once, and the
expect anything to wkr at all ...

johannes

WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes@sipsolutions.net>
To: Viresh Kumar <viresh.kumar@linaro.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linaro-kernel@lists.linaro.org,
	QCA ath9k Development <ath9k-devel@qca.qualcomm.com>,
	Intel Linux Wireless <ilw@linux.intel.com>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org,
	linux-bluetooth@vger.kernel.org,
	iommu@lists.linux-foundation.org, netdev@vger.kernel.org,
	linux-wireless@vger.kernel.org, linux-scsi@vger.kernel.org,
	linux-usb@vger.kernel.org, linux-edac@vger.kernel.org,
	linux-mm@kvack.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'
Date: Fri, 25 Sep 2015 19:42:25 +0200	[thread overview]
Message-ID: <1443202945.2161.8.camel@sipsolutions.net> (raw)
In-Reply-To: <e28c4b4deaf766910c366ab87b64325da59c8ad6.1443198783.git.viresh.kumar@linaro.org> (sfid-20150925_184230_610012_AD3DF607)

On Fri, 2015-09-25 at 09:41 -0700, Viresh Kumar wrote:

> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> V3->V4:
> - Create a local variable instead of changing type of global_lock
>   (Rafael)

Err, surely that wasn't what Rafael meant, since it's clearly
impossible to use a pointer to the stack, assign to it once, and the
expect anything to wkr at all ...

johannes


WARNING: multiple messages have this Message-ID (diff)
From: johannes@sipsolutions.net (Johannes Berg)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'
Date: Fri, 25 Sep 2015 19:42:25 +0200	[thread overview]
Message-ID: <1443202945.2161.8.camel@sipsolutions.net> (raw)
In-Reply-To: <e28c4b4deaf766910c366ab87b64325da59c8ad6.1443198783.git.viresh.kumar@linaro.org> (sfid-20150925_184230_610012_AD3DF607)

On Fri, 2015-09-25 at 09:41 -0700, Viresh Kumar wrote:

> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> V3->V4:
> - Create a local variable instead of changing type of global_lock
>   (Rafael)

Err, surely that wasn't what Rafael meant, since it's clearly
impossible to use a pointer to the stack, assign to it once, and the
expect anything to wkr at all ...

johannes

WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes@sipsolutions.net>
To: Viresh Kumar <viresh.kumar@linaro.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linaro-kernel@lists.linaro.org,
	QCA ath9k Development <ath9k-devel@qca.qualcomm.com>,
	Intel Linux Wireless <ilw@linux.intel.com>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org,
	linux-bluetooth@vger.kernel.org,
	iommu@lists.linux-foundation.org, netdev@vger.kernel.org,
	linux-wireless@vger.kernel.org, linux-scsi@vger.kernel.org,
	linux-usb@vger.kernel.org, linux-edac@vger.kernel.org,
	linux-mm@kvack.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'
Date: Fri, 25 Sep 2015 19:42:25 +0200	[thread overview]
Message-ID: <1443202945.2161.8.camel@sipsolutions.net> (raw)
In-Reply-To: <e28c4b4deaf766910c366ab87b64325da59c8ad6.1443198783.git.viresh.kumar@linaro.org> (sfid-20150925_184230_610012_AD3DF607)

On Fri, 2015-09-25 at 09:41 -0700, Viresh Kumar wrote:

> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> V3->V4:
> - Create a local variable instead of changing type of global_lock
>   (Rafael)

Err, surely that wasn't what Rafael meant, since it's clearly
impossible to use a pointer to the stack, assign to it once, and the
expect anything to wkr at all ...

johannes

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2015-09-25 17:42 UTC|newest]

Thread overview: 121+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-25 16:41 [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' Viresh Kumar
2015-09-25 16:41 ` Viresh Kumar
2015-09-25 16:41 ` Viresh Kumar
2015-09-25 16:41 ` Viresh Kumar
2015-09-25 16:41 ` [PATCH V4 2/2] debugfs: Pass bool pointer to debugfs_create_bool() Viresh Kumar
2015-09-25 16:41   ` Viresh Kumar
2015-09-25 16:41   ` Viresh Kumar
     [not found] ` <e28c4b4deaf766910c366ab87b64325da59c8ad6.1443198783.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-09-25 17:42   ` Johannes Berg [this message]
2015-09-25 17:42     ` [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' Johannes Berg
2015-09-25 17:42     ` Johannes Berg
2015-09-25 17:42     ` Johannes Berg
     [not found]     ` <1443202945.2161.8.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2015-09-25 18:47       ` Viresh Kumar
2015-09-25 18:47         ` Viresh Kumar
2015-09-25 18:47         ` Viresh Kumar
2015-09-25 18:47         ` Viresh Kumar
2015-09-25 18:49         ` Johannes Berg
2015-09-25 18:49           ` Johannes Berg
2015-09-25 18:49           ` Johannes Berg
     [not found]           ` <1443206945.2161.9.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2015-09-25 18:52             ` Viresh Kumar
2015-09-25 18:52               ` Viresh Kumar
2015-09-25 18:52               ` Viresh Kumar
2015-09-25 18:52               ` Viresh Kumar
2015-09-25 20:26               ` Rafael J. Wysocki
2015-09-25 20:26                 ` Rafael J. Wysocki
2015-09-25 20:26                 ` Rafael J. Wysocki
     [not found]                 ` <4331507.W3ZDWldbWu-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org>
2015-09-25 20:33                   ` Rafael J. Wysocki
2015-09-25 20:33                     ` Rafael J. Wysocki
2015-09-25 20:33                     ` Rafael J. Wysocki
2015-09-25 20:33                     ` Rafael J. Wysocki
2015-09-25 20:25                     ` Viresh Kumar
2015-09-25 20:25                       ` Viresh Kumar
2015-09-25 20:25                       ` Viresh Kumar
2015-09-25 20:25                       ` Viresh Kumar
2015-09-25 20:25                       ` Viresh Kumar
     [not found]                       ` <CAKohpok2Z2m7GZt1GzZzofeHEioF=XJEq8YVgtY=VtS9tmpb_Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-09-25 20:58                         ` Rafael J. Wysocki
2015-09-25 20:58                           ` Rafael J. Wysocki
2015-09-25 20:58                           ` Rafael J. Wysocki
2015-09-25 20:58                           ` Rafael J. Wysocki
2015-09-25 20:58                           ` Rafael J. Wysocki
2015-09-25 21:44                           ` Viresh Kumar
2015-09-25 21:44                             ` Viresh Kumar
2015-09-25 21:44                             ` Viresh Kumar
2015-09-25 21:44                             ` Viresh Kumar
2015-09-25 21:44                             ` Viresh Kumar
2015-09-25 22:19                             ` Rafael J. Wysocki
2015-09-25 22:19                               ` Rafael J. Wysocki
2015-09-25 22:19                               ` Rafael J. Wysocki
2015-09-25 22:19                               ` Rafael J. Wysocki
     [not found]                               ` <CAJZ5v0i+xJ4U13vCVsvXc7S8wP0AokbmNXPidBkDwbjXMM8fCw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-09-26 18:40                                 ` Viresh Kumar
2015-09-26 18:40                                   ` Viresh Kumar
2015-09-26 18:40                                   ` Viresh Kumar
2015-09-26 18:40                                   ` Viresh Kumar
2015-09-26 18:40                                   ` Viresh Kumar
2015-09-26 19:33                                   ` Arnd Bergmann
2015-09-26 19:33                                     ` Arnd Bergmann
2015-09-26 19:33                                     ` Arnd Bergmann
2015-09-26 19:33                                     ` Arnd Bergmann
2015-09-27 14:10                                     ` Rafael J. Wysocki
2015-09-27 14:10                                       ` Rafael J. Wysocki
2015-09-27 14:10                                       ` Rafael J. Wysocki
2015-09-27 14:10                                       ` Rafael J. Wysocki
2015-09-27 14:10                                       ` Rafael J. Wysocki
2015-09-28  8:24                                       ` Arnd Bergmann
2015-09-28  8:24                                         ` Arnd Bergmann
2015-09-28  8:24                                         ` Arnd Bergmann
2015-09-28  8:24                                         ` Arnd Bergmann
2015-09-28  8:24                                         ` Arnd Bergmann
2015-09-28 13:07                                         ` Rafael J. Wysocki
2015-09-28 13:07                                           ` Rafael J. Wysocki
2015-09-28 13:07                                           ` Rafael J. Wysocki
2015-09-28 13:07                                           ` Rafael J. Wysocki
2015-09-28 13:07                                           ` Rafael J. Wysocki
     [not found]                           ` <2524822.pQu4UKMrlb-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org>
2015-09-26 19:52                             ` James Bottomley
2015-09-26 19:52                               ` James Bottomley
2015-09-26 19:52                               ` James Bottomley
2015-09-26 19:52                               ` James Bottomley
2015-09-26 19:52                               ` James Bottomley
2015-09-27 14:09                               ` Rafael J. Wysocki
2015-09-27 14:09                                 ` Rafael J. Wysocki
2015-09-27 14:09                                 ` Rafael J. Wysocki
2015-09-27 14:09                                 ` Rafael J. Wysocki
     [not found]                                 ` <3461169.v5xKdGLGjP-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org>
2015-09-28  8:58                                   ` David Laight
2015-09-28  8:58                                     ` David Laight
2015-09-28  8:58                                     ` David Laight
2015-09-28  8:58                                     ` David Laight
2015-09-28  8:58                                     ` David Laight
2015-09-28  8:58                                     ` David Laight
     [not found]                                     ` <063D6719AE5E284EB5DD2968C1650D6D1CBA3BF7-VkEWCZq2GCInGFn1LkZF6NBPR1lH4CV8@public.gmane.org>
2015-09-28 14:26                                       ` James Bottomley
2015-09-28 14:26                                         ` James Bottomley
2015-09-28 14:26                                         ` James Bottomley
2015-09-28 14:26                                         ` James Bottomley
2015-09-28 14:26                                         ` James Bottomley
2015-09-28 14:50                                         ` David Laight
2015-09-28 14:50                                           ` David Laight
2015-09-28 14:50                                           ` David Laight
2015-09-28 14:50                                           ` David Laight
2015-09-28 14:50                                           ` David Laight
2015-09-28 14:50                                           ` David Laight
2015-09-28 15:11                                           ` James Bottomley
2015-09-28 15:11                                             ` James Bottomley
2015-09-28 15:11                                             ` James Bottomley
2015-09-28 15:11                                             ` James Bottomley
2015-09-28 15:11                                             ` James Bottomley
2015-09-28 15:31                                             ` David Laight
2015-09-28 15:31                                               ` David Laight
2015-09-28 15:31                                               ` David Laight
2015-09-28 15:31                                               ` David Laight
2015-09-28 15:31                                               ` David Laight
2015-09-28 15:31                                               ` David Laight
2015-09-25 20:18 ` Rafael J. Wysocki
2015-09-25 20:18   ` Rafael J. Wysocki
2015-09-25 20:18   ` Rafael J. Wysocki
2015-09-25 20:22   ` Rafael J. Wysocki
2015-09-25 20:22     ` Rafael J. Wysocki
2015-09-25 20:22     ` Rafael J. Wysocki
2015-09-27  5:31 ` Jiri Slaby
     [not found]   ` <CAJPN1uvPyZ+hZ64_0ZXU9wPLuAR-qm06GrRmHTjc9+rgiChYDQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-09-27 14:35     ` Viresh Kumar
2015-09-27 14:35       ` Viresh Kumar
2015-09-27 14:35       ` Viresh Kumar
2015-09-27 14:35       ` Viresh Kumar
2015-09-27 14:35       ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1443202945.2161.8.camel@sipsolutions.net \
    --to=johannes-cdvu00un1vgdhxzaddlk8q@public.gmane.org \
    --cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
    --cc=ath9k-devel-A+ZNKFmMK5xy9aJCnZT0Uw@public.gmane.org \
    --cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
    --cc=ilw-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=linaro-kernel-cunTk1MwBs8s++Sfvej+rw@public.gmane.org \
    --cc=linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-edac-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
    --cc=linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.