From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Tejun Heo <tj@kernel.org>, Paul Mackerras <paulus@ozlabs.org>,
linux-scsi@vger.kernel.org
Subject: Re: Bugs in multipath scsi in 4.3-rc2
Date: Fri, 02 Oct 2015 06:44:57 -0700 [thread overview]
Message-ID: <1443793497.2209.10.camel@HansenPartnership.com> (raw)
In-Reply-To: <20151002133423.GA15867@lst.de>
On Fri, 2015-10-02 at 15:34 +0200, Christoph Hellwig wrote:
> On Fri, Oct 02, 2015 at 06:25:01AM -0700, James Bottomley wrote:
> > That doesn't matter: if you modprobe alua after all devices are
> > discovered, it will attach correctly to all potential devices from the
> > alua module_init. This means the effect is the same whether the
> > request_module is sync or async ... the object is to get the device
> > attached to alua if it is an alua device.
>
> No, in 4.3-rc it won't. We removed that feature.
I think I prefer restoring that to having to build in every dh module to
get them to work. If we take your proposed fix for the sync module load
in the current scheme, any non-built in modules would never attach, so
we'd be moving towards the conclusion that *every* device handler has to
be non-modular.
Skimming the code it looks like dh should be using the driver binding
model rather than reinventing it. That would decouple it better and
make sure binding happened regardless of when the module was loaded.
James
next prev parent reply other threads:[~2015-10-02 13:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-25 12:16 Bugs in multipath scsi in 4.3-rc2 Paul Mackerras
2015-09-25 15:18 ` Christoph Hellwig
2015-09-25 17:31 ` James Bottomley
2015-09-30 15:14 ` Christoph Hellwig
2015-09-30 21:53 ` Tejun Heo
2015-09-30 22:34 ` James Bottomley
2015-10-02 12:56 ` Christoph Hellwig
2015-10-02 13:25 ` James Bottomley
2015-10-02 13:34 ` Christoph Hellwig
2015-10-02 13:44 ` James Bottomley [this message]
2015-10-04 7:45 ` Christoph Hellwig
2015-10-12 12:45 ` Hannes Reinecke
2015-10-12 14:39 ` Christoph Hellwig
2015-10-12 19:29 ` Mike Snitzer
2015-10-12 19:36 ` Christoph Hellwig
2015-10-13 6:00 ` Hannes Reinecke
2015-10-13 11:52 ` Christoph Hellwig
2015-10-12 14:51 ` James Bottomley
2015-10-01 4:34 ` Paul Mackerras
2015-10-02 12:52 ` Christoph Hellwig
2015-10-08 4:59 ` Paul Mackerras
2015-09-25 16:28 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443793497.2209.10.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
--cc=paulus@ozlabs.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.