* Regarding ASoC: rt286: Fix the runtime error in the booting
@ 2015-10-05 10:08 Axel Lin
2015-10-05 10:16 ` Axel Lin
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2015-10-05 10:08 UTC (permalink / raw)
To: Bard Liao, Oder Chiou; +Cc: alsa-devel, Mark Brown, Liam Girdwood
Hi Order,
I just notice your patch on the ML:
http://mailman.alsa-project.org/pipermail/alsa-devel/2015-October/098390.html
I didn't subscribe the ML and I'm not in CC so I cannot directly reply to you.
I think you should make a copy of memory for index_cache rather than
directly use the rt286_index_def if the index_cache is necessary.
diff --git a/sound/soc/codecs/rt286.c b/sound/soc/codecs/rt286.c
index 1fbdb4f..210ab415 100644
--- a/sound/soc/codecs/rt286.c
+++ b/sound/soc/codecs/rt286.c
@@ -37,7 +37,7 @@
#define RT288_VENDOR_ID 0x10ec0288
struct rt286_priv {
- const struct reg_default *index_cache;
+ struct reg_default *index_cache;
int index_cache_size;
struct regmap *regmap;
struct snd_soc_codec *codec;
@@ -1160,8 +1160,12 @@ static int rt286_i2c_probe(struct i2c_client *i2c,
return -ENODEV;
}
- rt286->index_cache = rt286_index_def;
rt286->index_cache_size = INDEX_CACHE_SIZE;
+ rt286->index_cache = devm_kmalloc(&i2c->dev, INDEX_CACHE_SIZE,
+ GFP_KERNEL);
+ if (!rt286->index_cache)
+ return -ENOMEM;
+
rt286->i2c = i2c;
i2c_set_clientdata(i2c, rt286);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: Regarding ASoC: rt286: Fix the runtime error in the booting
2015-10-05 10:08 Regarding ASoC: rt286: Fix the runtime error in the booting Axel Lin
@ 2015-10-05 10:16 ` Axel Lin
0 siblings, 0 replies; 2+ messages in thread
From: Axel Lin @ 2015-10-05 10:16 UTC (permalink / raw)
To: Bard Liao, Oder Chiou
Cc: alsa-devel@alsa-project.org, Mark Brown, Liam Girdwood
> - rt286->index_cache = rt286_index_def;
> rt286->index_cache_size = INDEX_CACHE_SIZE;
> + rt286->index_cache = devm_kmalloc(&i2c->dev, INDEX_CACHE_SIZE,
> + GFP_KERNEL);
Should be devm_kmalloc(&i2c->dev, sizeof(rt286_index_def), GFP_KERNEL);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-05 10:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-05 10:08 Regarding ASoC: rt286: Fix the runtime error in the booting Axel Lin
2015-10-05 10:16 ` Axel Lin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.