All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Kukjin Kim <kgene@kernel.org>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org,
	Thierry Reding <thierry.reding@gmail.com>
Subject: [PATCH 1/6] ARM: s3c24xx: h1940: Use PWM lookup table
Date: Mon,  5 Oct 2015 14:47:12 +0200	[thread overview]
Message-ID: <1444049237-29878-2-git-send-email-thierry.reding@gmail.com> (raw)
In-Reply-To: <1444049237-29878-1-git-send-email-thierry.reding@gmail.com>

Use a PWM lookup table to provide the PWM to the pwm-backlight device.
The driver has a legacy code path that is required only because boards
still use the legacy method of requesting PWMs by global ID. Replacing
these usages allows that legacy fallback to be removed.

Cc: Kukjin Kim <kgene@kernel.org>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
---
 arch/arm/mach-s3c24xx/mach-h1940.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-s3c24xx/mach-h1940.c b/arch/arm/mach-s3c24xx/mach-h1940.c
index d40d4f5244c6..9f54300df4b3 100644
--- a/arch/arm/mach-s3c24xx/mach-h1940.c
+++ b/arch/arm/mach-s3c24xx/mach-h1940.c
@@ -25,6 +25,7 @@
 #include <linux/gpio.h>
 #include <linux/input.h>
 #include <linux/gpio_keys.h>
+#include <linux/pwm.h>
 #include <linux/pwm_backlight.h>
 #include <linux/i2c.h>
 #include <linux/leds.h>
@@ -469,6 +470,11 @@ static struct s3c24xx_mci_pdata h1940_mmc_cfg __initdata = {
 	.ocr_avail     = MMC_VDD_32_33,
 };
 
+static struct pwm_lookup h1940_pwm_lookup[] = {
+	PWM_LOOKUP("samsung-pwm", 0, "pwm-backlight", NULL, 36296,
+		   PWM_POLARITY_NORMAL),
+};
+
 static int h1940_backlight_init(struct device *dev)
 {
 	gpio_request(S3C2410_GPB(0), "Backlight");
@@ -503,11 +509,8 @@ static void h1940_backlight_exit(struct device *dev)
 
 
 static struct platform_pwm_backlight_data backlight_data = {
-	.pwm_id         = 0,
 	.max_brightness = 100,
 	.dft_brightness = 50,
-	/* tcnt = 0x31 */
-	.pwm_period_ns  = 36296,
 	.enable_gpio    = -1,
 	.init           = h1940_backlight_init,
 	.notify		= h1940_backlight_notify,
@@ -725,6 +728,7 @@ static void __init h1940_init(void)
 	gpio_request(H1940_LATCH_SD_POWER, "SD power");
 	gpio_direction_output(H1940_LATCH_SD_POWER, 0);
 
+	pwm_add_table(h1940_pwm_lookup, ARRAY_SIZE(h1940_pwm_lookup));
 	platform_add_devices(h1940_devices, ARRAY_SIZE(h1940_devices));
 
 	gpio_request(S3C2410_GPA(1), "Red LED blink");
-- 
2.5.0

WARNING: multiple messages have this Message-ID (diff)
From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/6] ARM: s3c24xx: h1940: Use PWM lookup table
Date: Mon,  5 Oct 2015 14:47:12 +0200	[thread overview]
Message-ID: <1444049237-29878-2-git-send-email-thierry.reding@gmail.com> (raw)
In-Reply-To: <1444049237-29878-1-git-send-email-thierry.reding@gmail.com>

Use a PWM lookup table to provide the PWM to the pwm-backlight device.
The driver has a legacy code path that is required only because boards
still use the legacy method of requesting PWMs by global ID. Replacing
these usages allows that legacy fallback to be removed.

Cc: Kukjin Kim <kgene@kernel.org>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
---
 arch/arm/mach-s3c24xx/mach-h1940.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-s3c24xx/mach-h1940.c b/arch/arm/mach-s3c24xx/mach-h1940.c
index d40d4f5244c6..9f54300df4b3 100644
--- a/arch/arm/mach-s3c24xx/mach-h1940.c
+++ b/arch/arm/mach-s3c24xx/mach-h1940.c
@@ -25,6 +25,7 @@
 #include <linux/gpio.h>
 #include <linux/input.h>
 #include <linux/gpio_keys.h>
+#include <linux/pwm.h>
 #include <linux/pwm_backlight.h>
 #include <linux/i2c.h>
 #include <linux/leds.h>
@@ -469,6 +470,11 @@ static struct s3c24xx_mci_pdata h1940_mmc_cfg __initdata = {
 	.ocr_avail     = MMC_VDD_32_33,
 };
 
+static struct pwm_lookup h1940_pwm_lookup[] = {
+	PWM_LOOKUP("samsung-pwm", 0, "pwm-backlight", NULL, 36296,
+		   PWM_POLARITY_NORMAL),
+};
+
 static int h1940_backlight_init(struct device *dev)
 {
 	gpio_request(S3C2410_GPB(0), "Backlight");
@@ -503,11 +509,8 @@ static void h1940_backlight_exit(struct device *dev)
 
 
 static struct platform_pwm_backlight_data backlight_data = {
-	.pwm_id         = 0,
 	.max_brightness = 100,
 	.dft_brightness = 50,
-	/* tcnt = 0x31 */
-	.pwm_period_ns  = 36296,
 	.enable_gpio    = -1,
 	.init           = h1940_backlight_init,
 	.notify		= h1940_backlight_notify,
@@ -725,6 +728,7 @@ static void __init h1940_init(void)
 	gpio_request(H1940_LATCH_SD_POWER, "SD power");
 	gpio_direction_output(H1940_LATCH_SD_POWER, 0);
 
+	pwm_add_table(h1940_pwm_lookup, ARRAY_SIZE(h1940_pwm_lookup));
 	platform_add_devices(h1940_devices, ARRAY_SIZE(h1940_devices));
 
 	gpio_request(S3C2410_GPA(1), "Red LED blink");
-- 
2.5.0

  reply	other threads:[~2015-10-05 12:47 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-05 12:47 [PATCH 0/6] ARM: s3cxxxx: Use PWM lookup table Thierry Reding
2015-10-05 12:47 ` Thierry Reding
2015-10-05 12:47 ` Thierry Reding [this message]
2015-10-05 12:47   ` [PATCH 1/6] ARM: s3c24xx: h1940: " Thierry Reding
2015-10-07  1:32   ` Krzysztof Kozlowski
2015-10-07  1:32     ` Krzysztof Kozlowski
2015-10-05 12:47 ` [PATCH 2/6] ARM: s3c24xx: rx1950: " Thierry Reding
2015-10-05 12:47   ` Thierry Reding
2015-10-07  1:35   ` Krzysztof Kozlowski
2015-10-07  1:35     ` Krzysztof Kozlowski
2015-10-07 15:31     ` Thierry Reding
2015-10-07 15:31       ` Thierry Reding
2015-10-08  1:00       ` Krzysztof Kozlowski
2015-10-08  1:00         ` Krzysztof Kozlowski
2015-10-05 12:47 ` [PATCH 3/6] ARM: s3c64xx: smdk6410: " Thierry Reding
2015-10-05 12:47   ` Thierry Reding
2015-10-08  1:00   ` Krzysztof Kozlowski
2015-10-08  1:00     ` Krzysztof Kozlowski
2015-10-05 12:47 ` [PATCH 4/6] ARM: s3c64xx: crag6410: " Thierry Reding
2015-10-05 12:47   ` Thierry Reding
2015-10-07  1:36   ` Krzysztof Kozlowski
2015-10-07  1:36     ` Krzysztof Kozlowski
2015-10-05 12:47 ` [PATCH 5/6] ARM: s3c64xx: hmt: " Thierry Reding
2015-10-05 12:47   ` Thierry Reding
2015-10-07  1:37   ` Krzysztof Kozlowski
2015-10-07  1:37     ` Krzysztof Kozlowski
2015-10-07 15:37     ` Thierry Reding
2015-10-07 15:37       ` Thierry Reding
2015-10-08  1:01       ` Krzysztof Kozlowski
2015-10-08  1:01         ` Krzysztof Kozlowski
2015-10-05 12:47 ` [PATCH 6/6] ARM: s3c64xx: smartq: " Thierry Reding
2015-10-05 12:47   ` Thierry Reding
2015-10-08  1:02   ` Krzysztof Kozlowski
2015-10-08  1:02     ` Krzysztof Kozlowski
2015-10-06  0:28 ` [PATCH 0/6] ARM: s3cxxxx: " Krzysztof Kozlowski
2015-10-06  0:28   ` Krzysztof Kozlowski
2015-10-06  8:43   ` Thierry Reding
2015-10-06  8:43     ` Thierry Reding
2015-10-06 12:27     ` Krzysztof Kozlowski
2015-10-06 12:27       ` Krzysztof Kozlowski
2015-10-12 19:17 ` Kukjin Kim
2015-10-12 19:17   ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1444049237-29878-2-git-send-email-thierry.reding@gmail.com \
    --to=thierry.reding@gmail.com \
    --cc=k.kozlowski@samsung.com \
    --cc=kgene@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.