From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Cc: stephen@networkplumber.org
Subject: [PATCH nf 3/3] netfilter: xt_CT: don't put back reference to timeout policy object
Date: Mon, 5 Oct 2015 16:51:03 +0200 [thread overview]
Message-ID: <1444056663-5913-3-git-send-email-pablo@netfilter.org> (raw)
In-Reply-To: <1444056663-5913-1-git-send-email-pablo@netfilter.org>
On success, this shouldn't put back the timeout policy object, otherwise
we may have module refcount overflow and we allow deletion of timeout
that are still in use.
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
net/netfilter/xt_CT.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/net/netfilter/xt_CT.c b/net/netfilter/xt_CT.c
index b43bf13..e8ac8e0 100644
--- a/net/netfilter/xt_CT.c
+++ b/net/netfilter/xt_CT.c
@@ -171,6 +171,9 @@ xt_ct_set_timeout(struct nf_conn *ct, const struct xt_tgchk_param *par,
if (timeout_ext == NULL)
ret = -ENOMEM;
+ rcu_read_unlock();
+ return 0;
+
err_put_timeout:
__xt_ct_tg_timeout_put(timeout);
out:
--
2.1.4
next prev parent reply other threads:[~2015-10-05 14:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-05 14:51 [PATCH nf 1/3] netfilter: conntrack: fix crash on timeout object removal Pablo Neira Ayuso
2015-10-05 14:51 ` [PATCH nf 2/3] nfnetlink_cttimeout: add rcu_barrier() on module removal Pablo Neira Ayuso
2015-10-05 14:51 ` Pablo Neira Ayuso [this message]
2015-10-05 15:08 ` [PATCH nf 1/3] netfilter: conntrack: fix crash on timeout object removal kbuild test robot
2015-10-12 15:08 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444056663-5913-3-git-send-email-pablo@netfilter.org \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.