All of lore.kernel.org
 help / color / mirror / Atom feed
From: vinod.koul@intel.com (Koul, Vinod)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/9] dmaengine: st_fdma:  Add STMicroelectronics FDMA driver header file
Date: Thu, 8 Oct 2015 15:43:59 +0000	[thread overview]
Message-ID: <1444118413.3579.46.camel@intel.com> (raw)
In-Reply-To: <1441980871-24475-4-git-send-email-peter.griffin@linaro.org>

On Fri, 2015-09-11 at 15:14 +0100, Peter Griffin wrote:

> +#define FDMA_ID_OFST		0x00000
> +#define FDMA_VER_OFST		0x00004
> > +
> +#define FDMA_EN_OFST		0x00008

Why cant these be BIT() to maintain consistency?

-- 
~Vinod

WARNING: multiple messages have this Message-ID (diff)
From: "Koul, Vinod" <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"patrice.chotard-qxv4g6HH51o@public.gmane.org"
	<patrice.chotard-qxv4g6HH51o@public.gmane.org>,
	"maxime.coquelin-qxv4g6HH51o@public.gmane.org"
	<maxime.coquelin-qxv4g6HH51o@public.gmane.org>,
	"srinivas.kandagatla-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
	<srinivas.kandagatla-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"peter.griffin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org"
	<peter.griffin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: "dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"ludovic.barre-qxv4g6HH51o@public.gmane.org"
	<ludovic.barre-qxv4g6HH51o@public.gmane.org>,
	"lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org"
	<lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	"robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
	<robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v2 3/9] dmaengine: st_fdma:  Add STMicroelectronics FDMA driver header file
Date: Thu, 8 Oct 2015 15:43:59 +0000	[thread overview]
Message-ID: <1444118413.3579.46.camel@intel.com> (raw)
In-Reply-To: <1441980871-24475-4-git-send-email-peter.griffin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>

On Fri, 2015-09-11 at 15:14 +0100, Peter Griffin wrote:

> +#define FDMA_ID_OFST		0x00000
> +#define FDMA_VER_OFST		0x00004
> > +
> +#define FDMA_EN_OFST		0x00008

Why cant these be BIT() to maintain consistency?

-- 
~Vinod

WARNING: multiple messages have this Message-ID (diff)
From: "Koul, Vinod" <vinod.koul@intel.com>
To: "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"patrice.chotard@st.com" <patrice.chotard@st.com>,
	"maxime.coquelin@st.com" <maxime.coquelin@st.com>,
	"srinivas.kandagatla@gmail.com" <srinivas.kandagatla@gmail.com>,
	"peter.griffin@linaro.org" <peter.griffin@linaro.org>
Cc: "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
	"ludovic.barre@st.com" <ludovic.barre@st.com>,
	"lee.jones@linaro.org" <lee.jones@linaro.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 3/9] dmaengine: st_fdma:  Add STMicroelectronics FDMA driver header file
Date: Thu, 8 Oct 2015 15:43:59 +0000	[thread overview]
Message-ID: <1444118413.3579.46.camel@intel.com> (raw)
In-Reply-To: <1441980871-24475-4-git-send-email-peter.griffin@linaro.org>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 385 bytes --]

On Fri, 2015-09-11 at 15:14 +0100, Peter Griffin wrote:

> +#define FDMA_ID_OFST		0x00000
> +#define FDMA_VER_OFST		0x00004
> > +
> +#define FDMA_EN_OFST		0x00008

Why cant these be BIT() to maintain consistency?

-- 
~Vinod
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

  reply	other threads:[~2015-10-08 15:43 UTC|newest]

Thread overview: 103+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-11 14:14 [PATCH v2 0/9] Add support for FDMA DMA controller found on STi chipsets Peter Griffin
2015-09-11 14:14 ` Peter Griffin
2015-09-11 14:14 ` Peter Griffin
2015-09-11 14:14 ` [PATCH v2 1/9] dmaengine: st_fdma: Add STMicroelectronics FDMA DT binding documentation Peter Griffin
2015-09-11 14:14   ` Peter Griffin
2015-09-11 14:14   ` Peter Griffin
2015-09-11 20:36   ` Arnd Bergmann
2015-09-11 20:36     ` Arnd Bergmann
2015-09-12 12:07     ` Peter Griffin
2015-09-12 12:07       ` Peter Griffin
2015-09-14  8:19       ` Lee Jones
2015-09-14  8:19         ` Lee Jones
2015-09-29 10:04         ` Peter Griffin
2015-09-29 10:04           ` Peter Griffin
2015-09-29 10:04           ` Peter Griffin
2015-09-29 11:17           ` Arnd Bergmann
2015-09-29 11:17             ` Arnd Bergmann
2015-09-29 11:17             ` Arnd Bergmann
2015-09-29 12:11             ` Peter Griffin
2015-09-29 12:11               ` Peter Griffin
2015-09-29 12:11               ` Peter Griffin
2015-09-29 12:30               ` Arnd Bergmann
2015-09-29 12:30                 ` Arnd Bergmann
2015-09-29 13:42                 ` Peter Griffin
2015-09-29 13:42                   ` Peter Griffin
2015-09-29 14:15                   ` Arnd Bergmann
2015-09-29 14:15                     ` Arnd Bergmann
2015-09-29 14:15                     ` Arnd Bergmann
2015-10-13 11:18                     ` Peter Griffin
2015-10-13 11:18                       ` Peter Griffin
2015-10-13 11:18                       ` Peter Griffin
2015-09-11 14:14 ` [PATCH v2 2/9] dmaengine: st_fdma: Add st fdma platform specific header Peter Griffin
2015-09-11 14:14   ` Peter Griffin
2015-09-11 20:32   ` Arnd Bergmann
2015-09-11 20:32     ` Arnd Bergmann
2015-09-29  9:24     ` Peter Griffin
2015-09-29  9:24       ` Peter Griffin
2015-09-29 11:10       ` Arnd Bergmann
2015-09-29 11:10         ` Arnd Bergmann
2015-09-29 11:10         ` Arnd Bergmann
2015-09-11 14:14 ` [PATCH v2 3/9] dmaengine: st_fdma: Add STMicroelectronics FDMA driver header file Peter Griffin
2015-09-11 14:14   ` Peter Griffin
2015-09-11 14:14   ` Peter Griffin
2015-10-08 15:43   ` Koul, Vinod [this message]
2015-10-08 15:43     ` Koul, Vinod
2015-10-08 15:43     ` Koul, Vinod
2015-10-13 10:41     ` Peter Griffin
2015-10-13 10:43     ` Peter Griffin
2015-10-13 10:43       ` Peter Griffin
2015-10-13 10:43       ` Peter Griffin
2015-09-11 14:14 ` [PATCH v2 4/9] dmaengine: st_fdma: Add STMicroelectronics FDMA engine driver support Peter Griffin
2015-09-11 14:14   ` Peter Griffin
2015-09-11 20:30   ` Arnd Bergmann
2015-09-11 20:30     ` Arnd Bergmann
2015-09-29 10:23     ` Peter Griffin
2015-09-29 10:23       ` Peter Griffin
2015-09-29 10:23       ` Peter Griffin
2015-10-07 11:15   ` Vinod Koul
2015-10-07 11:15     ` Vinod Koul
2015-09-11 14:14 ` [PATCH v2 5/9] dmaengine: st_fdma: Add xp70 firmware loading mechanism Peter Griffin
2015-09-11 14:14   ` Peter Griffin
2015-09-11 14:14   ` Peter Griffin
2015-10-07 11:22   ` Vinod Koul
2015-10-07 11:22     ` Vinod Koul
2015-10-13 10:53     ` Peter Griffin
2015-10-13 10:53       ` Peter Griffin
2015-09-11 14:14 ` [PATCH v2 6/9] dmaengine: st_fdma: Add fdma suspend and resume callbacks Peter Griffin
2015-09-11 14:14   ` Peter Griffin
2015-09-11 14:14   ` Peter Griffin
2015-10-07 11:23   ` Vinod Koul
2015-10-07 11:23     ` Vinod Koul
2015-10-13 11:19     ` Peter Griffin
2015-10-13 11:19       ` Peter Griffin
2015-10-13 11:19       ` Peter Griffin
2015-10-13 11:33       ` Koul, Vinod
2015-10-13 11:33         ` Koul, Vinod
2015-10-13 11:33         ` Koul, Vinod
2015-09-11 14:14 ` [PATCH v2 7/9] ARM: STi: DT: STiH407: Add FDMA driver dt nodes Peter Griffin
2015-09-11 14:14   ` Peter Griffin
2015-09-11 14:14   ` Peter Griffin
2015-09-11 16:27   ` Lee Jones
2015-09-11 16:27     ` Lee Jones
2015-09-11 16:48     ` Peter Griffin
2015-09-11 16:48       ` Peter Griffin
2015-09-11 16:48       ` Peter Griffin
2015-09-11 17:55       ` Lee Jones
2015-09-11 17:55         ` Lee Jones
2015-09-11 17:55         ` Lee Jones
2015-09-11 18:06         ` Peter Griffin
2015-09-11 18:06           ` Peter Griffin
2015-09-11 18:06           ` Peter Griffin
2015-09-11 19:33           ` Lee Jones
2015-09-11 19:33             ` Lee Jones
2015-09-12 12:23             ` Peter Griffin
2015-09-12 12:23               ` Peter Griffin
2015-09-11 14:14 ` [PATCH v2 8/9] MAINTAINERS: Add FDMA driver files to STi section Peter Griffin
2015-09-11 14:14   ` Peter Griffin
2015-09-11 16:22   ` Lee Jones
2015-09-11 16:22     ` Lee Jones
2015-09-11 14:14 ` [PATCH v2 9/9] ARM: multi_v7_defconfig: Enable STi FDMA driver Peter Griffin
2015-09-11 14:14   ` Peter Griffin
2015-09-11 16:22   ` Lee Jones
2015-09-11 16:22     ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1444118413.3579.46.camel@intel.com \
    --to=vinod.koul@intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.