From: Ian Campbell <ian.campbell@citrix.com>
To: Julien Grall <julien.grall@citrix.com>, xen-devel@lists.xenproject.org
Cc: stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH v2 5/9] xen/arm: vgic: Optimize the way to store GICD_IPRIORITYR in the rank
Date: Tue, 6 Oct 2015 14:49:19 +0100 [thread overview]
Message-ID: <1444139359.5302.179.camel@citrix.com> (raw)
In-Reply-To: <1444049512-15323-6-git-send-email-julien.grall@citrix.com>
On Mon, 2015-10-05 at 13:51 +0100, Julien Grall wrote:
> Xen is currently directly storing the value of GICD_IPRIORITYR register
> in the rank. This makes emulation of the register access very simple
> but makes the code to get the priority for a given vIRQ more complex.
>
> While the priority of an vIRQ is retrieved every time an vIRQ is injected
> to the guest, the access to register occurs less often.
>
> Each GICD_IPRIORITYR register stores 4 priorities associated for 4 vIRQs
> (see 4.3.11 in IHI 0048B). As Xen is using little endian, we can use
> an union to access directly a register or a priority for a given IRQ.
>
> Note that the field "ipriority" has been renamed to "ipriorityr" to
> match the name of the register in the GIC spec.
>
> Finally, the implementation of the callback get_irq_priority is exactly
> the same for both vGIC drivers. Consolidate the implementation in the
> common vGIC code and drop the callback.
>
> Signed-off-by: Julien Grall <julien.grall@citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
next prev parent reply other threads:[~2015-10-06 13:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-05 12:51 [PATCH v2 0/9] xen/arm: vgic: Support 32-bit access for 64-bit register Julien Grall
2015-10-05 12:51 ` [PATCH v2 1/9] xen/arm: io: remove mmio_check_t typedef Julien Grall
2015-10-05 12:51 ` [PATCH v2 2/9] xen/arm: io: Extend write/read handler to pass the register in parameter Julien Grall
2015-10-05 12:58 ` Julien Grall
2015-10-06 13:44 ` Ian Campbell
2015-10-05 12:51 ` [PATCH v2 3/9] xen/arm: io: Support sign-extension for every read access Julien Grall
2015-10-06 13:47 ` Ian Campbell
2015-10-06 13:55 ` Julien Grall
2015-10-05 12:51 ` [PATCH v2 4/9] xen/arm: vgic: ctlr stores a 32-bit hardware register so use uint32_t Julien Grall
2015-10-05 12:51 ` [PATCH v2 5/9] xen/arm: vgic: Optimize the way to store GICD_IPRIORITYR in the rank Julien Grall
2015-10-06 13:49 ` Ian Campbell [this message]
2015-10-05 12:51 ` [PATCH v2 6/9] xen/arm: vgic: Introduce a new field to store the rank index and use it Julien Grall
2015-10-06 13:51 ` Ian Campbell
2015-10-06 13:56 ` Julien Grall
2015-10-05 12:51 ` [PATCH v2 7/9] xen/arm: vgic: Optimize the way to store the target vCPU in the rank Julien Grall
2015-10-06 13:59 ` Ian Campbell
2015-10-06 14:18 ` Julien Grall
2015-10-05 12:51 ` [PATCH v2 8/9] xen/arm: vgic: Introduce helpers to extract/update/clear/set vGIC register Julien Grall
2015-10-06 14:01 ` Ian Campbell
2015-10-05 12:51 ` [PATCH v2 9/9] xen/arm: vgic-v3: Support 32-bit access for 64-bit registers Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444139359.5302.179.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=julien.grall@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.