From: Ian Campbell <ian.campbell@citrix.com>
To: Julien Grall <julien.grall@citrix.com>, xen-devel@lists.xenproject.org
Cc: stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH v2 2/9] xen/arm: io: Extend write/read handler to pass the register in parameter
Date: Tue, 6 Oct 2015 14:44:01 +0100 [thread overview]
Message-ID: <1444139041.5302.176.camel@citrix.com> (raw)
In-Reply-To: <561273DC.6080500@citrix.com>
On Mon, 2015-10-05 at 13:58 +0100, Julien Grall wrote:
> On 05/10/15 13:51, Julien Grall wrote:
> > Rather than letting each handler to retrieve the register used by the
> > I/O access, add a new parameter to pass the register in parameter.
> >
> > This will help to implement generic register manipulation on I/O access
> > such as sign-extension and endianess.
> >
> > Read handlers need to modify the value of the register, so a pointer to
> > it is given in argument. Write handlers shouldn't modify the register,
> > therefore only a plain value is given.
> >
> > Signed-off-by: Julien Grall <julien.grall@citrix.com>
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> >
> > ---
> >
> > Ian, I haven't kept my Acked-by because of code clash while rebasing
> > on top of "xen/arm: io: Extend write/read handler to pass private data"
> > [1].
>
> Hmmm, this doesn't match what I did (i.e keeping the acked-by from Ian).
>
> The conflict with "xen/arm: io: Extend write/read handler to pass
> private data" should not be controversial. Let me know if you disagree.
It's fine.
next prev parent reply other threads:[~2015-10-06 13:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-05 12:51 [PATCH v2 0/9] xen/arm: vgic: Support 32-bit access for 64-bit register Julien Grall
2015-10-05 12:51 ` [PATCH v2 1/9] xen/arm: io: remove mmio_check_t typedef Julien Grall
2015-10-05 12:51 ` [PATCH v2 2/9] xen/arm: io: Extend write/read handler to pass the register in parameter Julien Grall
2015-10-05 12:58 ` Julien Grall
2015-10-06 13:44 ` Ian Campbell [this message]
2015-10-05 12:51 ` [PATCH v2 3/9] xen/arm: io: Support sign-extension for every read access Julien Grall
2015-10-06 13:47 ` Ian Campbell
2015-10-06 13:55 ` Julien Grall
2015-10-05 12:51 ` [PATCH v2 4/9] xen/arm: vgic: ctlr stores a 32-bit hardware register so use uint32_t Julien Grall
2015-10-05 12:51 ` [PATCH v2 5/9] xen/arm: vgic: Optimize the way to store GICD_IPRIORITYR in the rank Julien Grall
2015-10-06 13:49 ` Ian Campbell
2015-10-05 12:51 ` [PATCH v2 6/9] xen/arm: vgic: Introduce a new field to store the rank index and use it Julien Grall
2015-10-06 13:51 ` Ian Campbell
2015-10-06 13:56 ` Julien Grall
2015-10-05 12:51 ` [PATCH v2 7/9] xen/arm: vgic: Optimize the way to store the target vCPU in the rank Julien Grall
2015-10-06 13:59 ` Ian Campbell
2015-10-06 14:18 ` Julien Grall
2015-10-05 12:51 ` [PATCH v2 8/9] xen/arm: vgic: Introduce helpers to extract/update/clear/set vGIC register Julien Grall
2015-10-06 14:01 ` Ian Campbell
2015-10-05 12:51 ` [PATCH v2 9/9] xen/arm: vgic-v3: Support 32-bit access for 64-bit registers Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444139041.5302.176.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=julien.grall@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.