Re: [PATCH 1/6] event: add new property to BuildBase class

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Sun, 2015-10-11 at 23:02 +0300, Ed Bartosh wrote:
> On Sun, Oct 11, 2015 at 05:22:10AM +0100, Richard Purdie wrote:
> > On Mon, 2015-10-05 at 10:43 +0100, Elliot Smith wrote:
> > > From: Ed Bartosh <ed.bartosh@linux.intel.com>
> > > 
> > > Added 'task' property to the base class of BuildStarted and
> > > BuildCompleted classes to store bitbake task if it's specified.
> > > 
> > > This is done as without task Build* events can't fully represent
> > > bitbake build. Task information is needed by UI classes to properly
> > > show or process Build* events.
> > 
> > This doesn't make sense I'm afraid. There is no one "task" which a build
> > start/complete event can correspond to. Consider something like:
> > 
> > "bitbake A:do_fetch B:do_rootfs"
> > 
> > There would be one BuildStarted event but task doesn't have a singular
> > value. We therefore don't want to add task information to these events
> > as it will ultimately mislead anything building on top of this
> > information.
> > 
> > I appreciate there is the -c option, but that just means "if there is no
> > specific task specified, use this", i.e. its a default.
> >
> 
> OK. can we call it 'default_task' then?
> You spotted it's purpose right - it's done to represent the task
> specified by -c option.

That would certainly be better. I am a little worried how this would be
used in the UI though. Can you explain where and why the UI needs this
piece of information?

Cheers,

Richard