All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Ed Bartosh <ed.bartosh@linux.intel.com>,
	"toaster@yoctoproject.org" <toaster@yoctoproject.org>
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH v2] bitbake: normalize build targets
Date: Fri, 16 Oct 2015 14:09:56 +0100	[thread overview]
Message-ID: <1445000996.17974.15.camel@linuxfoundation.org> (raw)
In-Reply-To: <1444898260-19877-1-git-send-email-ed.bartosh@linux.intel.com>

On Thu, 2015-10-15 at 11:37 +0300, Ed Bartosh wrote:
> BuildStarted event not fully represents build tasks for
> the targets. If -c option is used to specify default task
> it's not included into the event.
> 
> Made build targets to always look as <target>:do_<task>.
> Consider default task (do_build or specified by -c command
> line option) when normalizing.
> 
> Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>

The correct prefix for the commit shortlog is "cooker:". I'd really like
to see toaster becoming a little more specific too such as
"toaster/xxxx:" instead of the usual "toaster:".

Cheers,

Richard



WARNING: multiple messages have this Message-ID (diff)
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Ed Bartosh <ed.bartosh@linux.intel.com>,
	"toaster@yoctoproject.org" <toaster@yoctoproject.org>
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: [bitbake-devel] [PATCH v2] bitbake: normalize build targets
Date: Fri, 16 Oct 2015 14:09:56 +0100	[thread overview]
Message-ID: <1445000996.17974.15.camel@linuxfoundation.org> (raw)
In-Reply-To: <1444898260-19877-1-git-send-email-ed.bartosh@linux.intel.com>

On Thu, 2015-10-15 at 11:37 +0300, Ed Bartosh wrote:
> BuildStarted event not fully represents build tasks for
> the targets. If -c option is used to specify default task
> it's not included into the event.
> 
> Made build targets to always look as <target>:do_<task>.
> Consider default task (do_build or specified by -c command
> line option) when normalizing.
> 
> Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>

The correct prefix for the commit shortlog is "cooker:". I'd really like
to see toaster becoming a little more specific too such as
"toaster/xxxx:" instead of the usual "toaster:".

Cheers,

Richard



  reply	other threads:[~2015-10-16 13:10 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-05  9:43 [PATCH 0/6] Fixes for toastergui Elliot Smith
2015-10-05  9:43 ` [PATCH 1/6] event: add new property to BuildBase class Elliot Smith
2015-10-11  4:22   ` Richard Purdie
2015-10-11 20:02     ` Ed Bartosh
2015-10-12  4:54       ` Richard Purdie
2015-10-13  8:33         ` Ed Bartosh
2015-10-14  8:41         ` [PATCH] bitbake: normalize build targets Ed Bartosh
2015-10-14 22:20           ` Christopher Larson
2015-10-15  8:37             ` [PATCH v2] " Ed Bartosh
2015-10-16 13:09               ` Richard Purdie [this message]
2015-10-16 13:09                 ` [bitbake-devel] " Richard Purdie
2015-10-05  9:43 ` [PATCH 2/6] event: add new parameter to Build* event APIs Elliot Smith
2015-10-05  9:43 ` [PATCH 3/6] toaster: add task to the target_information Elliot Smith
2015-10-05  9:43 ` [PATCH 4/6] toaster: add get_or_create_targets API Elliot Smith
2015-10-05  9:43 ` [PATCH 5/6] toaster: ignore ReachableStamps event Elliot Smith
2015-10-05  9:43 ` [PATCH 6/6] toaster: use meaningful logging levels Elliot Smith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1445000996.17974.15.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=ed.bartosh@linux.intel.com \
    --cc=toaster@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.