Re: patch "x86/cpufreq: relocate the driver register function" breaks cpu hot(un)plug

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1003 bytes --]

On Mon, 2015-10-12 at 07:19 -0600, Jan Beulich wrote:
> > > > On 09.10.15 at 22:00, <konrad.wilk@oracle.com> wrote:
> > Anyhow it may be due to the fact that cpufreq_register_driver in
> > Xen is now
> > '__init' If you remove that little thing would it work?
> 
> Before adding this annotation I carefully check all callers, and both
> which I could find are themselves __init. Did I overlook any?
> 
No, I've just checked, and I also think __init is fine. And in fact, I
tried removing it, and the issue is still there.

I think the issue is the fact that we register the cpu notifier twice,
as an effect of 49388f11d512bb92706ce046643bfbb3c1d963c9, as Wei noted.

I'm just about try and confirm that...

Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel