Re: [PATCH] raisin: enable ovmf build for arm64

[Ian Campbell <ian.campbell@citrix.com>]

On Mon, 2015-10-12 at 18:18 +0100, Stefano Stabellini wrote:
> @@ -30,9 +38,18 @@ function ovmf_build() {
>      git-checkout $OVMF_URL $OVMF_REVISION ovmf-dir
>      cd ovmf-dir
>  
> -    make -C BaseTools/Source/C
> -    OvmfPkg/build.sh -a X64 -b RELEASE -n 4
> -    cp Build/OvmfX64/RELEASE_GCC*/FV/OVMF.fd ovmf.bin
> +    make -C BaseTools
> +
> +    if [[ $RAISIN_ARCH = "arm64" ]]

Based on what I understand of the OVMF buildsystem I think you are going to
eventually want a case $RAISIN_ARCH here, since it seems to vary a fair
bit.

> +    then
> +        export GCC48_AARCH64_PREFIX=

Won't this (unexpectedly) leak into other subsequent component builds? Or
is each component built in a  fresh sub-shell?

What about host platforms which have a gcc other than 4.8? (e.g. Debian
Jessie uses 4.9 by default)

Should you add a comment explaining why this apparent workaround is needed?

> +        bash -c "source edksetup.sh && build -a AARCH64 -t GCC48 -p ArmVirtPkg/ArmVirtXen.dsc -b RELEASE"
> +        mkdir -p "$INST_DIR"/$PREFIX/lib/xen/boot
> +        cp Build/ArmVirtXen-AARCH64/RELEASE_GCC*/FV/XEN_EFI.fd "$INST_DIR"/$PREFIX/lib/xen/boot/XEN_EFI.fd
> +    else
> +        OvmfPkg/build.sh -a X64 -b RELEASE -n 4
> +        cp Build/OvmfX64/RELEASE_GCC*/FV/OVMF.fd ovmf.bin
> +    fi
>  
>      cd "$BASEDIR"
>  }
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel