All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@citrix.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	Ian Campbell <ian.campbell@citrix.com>
Cc: xen-devel@lists.xensource.com, ard.biesheuvel@linaro.org
Subject: Re: [PATCH] raisin: enable ovmf build for arm64
Date: Tue, 13 Oct 2015 14:31:12 +0100	[thread overview]
Message-ID: <561D07A0.9060804@citrix.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1510131409040.1179@kaball.uk.xensource.com>

On 13/10/15 14:18, Stefano Stabellini wrote:
> On Tue, 13 Oct 2015, Ian Campbell wrote:
>> On Tue, 2015-10-13 at 13:49 +0100, Stefano Stabellini wrote:
>>> I didn't git clean enough. You are right, only -t GCC48 is required.
>>
>> What if only e.g. gcc-4.9 is available though?
> 
> It is just the no -t build that doesn't work. As far as I can tell
> looking at BaseTools/Conf/tools_def.template there is no difference
> between -t GCC49, -t GCC48 and -t GCC47 in terms of gcc flags.

The differences may be more subtle. I would be surprised if they
duplicate code just for having the variable name GCCXX matching the
version of the compiler.

For instance compiling using GCC 5.0 folds under GCC49. They didn't
bother to add a new GCCXX.

FWIW, the scripts to build x86 (OvmfPkg/build.sh) is detecting which
compiler is used and will setup the TARGET_TOOLS correctly:

    gcc_version=$(gcc -v 2>&1 | tail -1 | awk '{print $3}')
    case $gcc_version in
      4.5.*)
        TARGET_TOOLS=GCC45
        ;;
      4.6.*)
        TARGET_TOOLS=GCC46
        ;;
      4.7.*)
        TARGET_TOOLS=GCC47
        ;;
      4.8.*)
        TARGET_TOOLS=GCC48
        ;;
      4.9.*|4.1[0-9].*|5.*.*)
        TARGET_TOOLS=GCC49
        ;;
      *)
        TARGET_TOOLS=GCC44
        ;;
    esac

A couple of weeks ago I've looked at porting this script for ARM but it
wasn't trivial to do it (i.e requiring more than a couple of hours to
fix it).

Regards,

-- 
Julien Grall

  reply	other threads:[~2015-10-13 13:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-12 17:18 [PATCH] raisin: enable ovmf build for arm64 Stefano Stabellini
2015-10-13 10:41 ` Ian Campbell
2015-10-13 10:58   ` Stefano Stabellini
2015-10-13 11:03     ` Ian Campbell
2015-10-13 11:24     ` Julien Grall
2015-10-13 12:49       ` Stefano Stabellini
2015-10-13 13:00         ` Ian Campbell
2015-10-13 13:16           ` Julien Grall
2015-10-13 13:18           ` Stefano Stabellini
2015-10-13 13:31             ` Julien Grall [this message]
2015-10-13 13:41               ` Stefano Stabellini
2015-10-13 13:43               ` Ard Biesheuvel
2015-10-13 13:48                 ` Stefano Stabellini
2015-10-13 14:02                   ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=561D07A0.9060804@citrix.com \
    --to=julien.grall@citrix.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=ian.campbell@citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.