All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Ola Olsson <ola1olsson@gmail.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
	Ola Olsson <ola.olsson@sonymobile.com>
Subject: Re: [PATCH] ocb: use correct "MHz" instead of "MHZ"
Date: Wed, 14 Oct 2015 08:52:07 +0200	[thread overview]
Message-ID: <1444805527.3054.4.camel@sipsolutions.net> (raw)
In-Reply-To: <CABAco3CLCtFOofHMbJSz-Okcc4BM4nnVwO5By8DeZUYJrsCt6Q@mail.gmail.com> (sfid-20151014_004234_903313_530163BE)

Hi,

> May I ask if you are interested in patches that removes the compiler
> warnings on Android? I have cloned the iw git under the external
> folder in the android tree and everything compiles fine with "mm" but
> there are a lot of warnings. Most warnings are unused-parameter and
> sign-compare but also missing-field-initializers.

Hm. I think -Wunused-parameter I'd prefer not to fix, since that
usually ends up with something like

int my_callback_function(void *ignored)
{
	ignored = ignored;

	...
}

or something like that?

-Wsign-compare seems somewhat useful, I've just gone through that and
fixed it up.

I don't see anything with -Wmissing-field-initializers.


johannes

  reply	other threads:[~2015-10-14  6:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-12  7:35 [PATCH] ocb: use correct "MHz" instead of "MHZ" Ola Olsson
2015-10-13  9:14 ` Johannes Berg
2015-10-13 22:42   ` Ola Olsson
2015-10-14  6:52     ` Johannes Berg [this message]
2015-10-14  7:36       ` Ola Olsson
2015-10-14  8:00         ` Johannes Berg
2015-10-14  9:05           ` Ola Olsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1444805527.3054.4.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=ola.olsson@sonymobile.com \
    --cc=ola1olsson@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.