Re: [PATCH] ocb: use correct "MHz" instead of "MHZ"

[Johannes Berg <johannes@sipsolutions.net>]

On Wed, 2015-10-14 at 09:36 +0200, Ola Olsson wrote:

> Correct. I have done a macro to utilize the gcc "__attribute__
> ((unused))" and I fully understand that it is not an elegant 
> solution.
> I don't want to convince you about merging it since I wouldn't do it
> myself. :)

Yeah, ouch, I don't really want that. Perhaps you can add -Wno-unused
-parameters to your Android makefile.

> > I don't see anything with -Wmissing-field-initializers.
> 
> Hmm. I'll try to find out why I get these warnings. Mostly, it is
> about changing "{}" -> "{0}" on stack allocated objects.
> This is what I get when compiling at 
> 0ee571d57b8b631658d1a35ad9a906610d6145d3
> 
> $ mm -B -j8 2>&1 | grep -i missing-field
> external/iw/scan.c:1863:3: warning: missing initializer for field
> 'type' of 'struct nla_policy' [-Wmissing-field-initializers]
> 

Yeah, ok, so technically IIRC ={0} is the standard way of doing this in
C, but everything seems to accept ={} as a natural extension of ={.x=y}
I guess? Not sure I want to fix it - doesn't really seem worth much.

johannes