* [PATCH] xen/arm: domain_build: Removed unused variable in write_properties
@ 2015-10-14 9:34 Julien Grall
2015-10-14 10:48 ` Ian Campbell
0 siblings, 1 reply; 2+ messages in thread
From: Julien Grall @ 2015-10-14 9:34 UTC (permalink / raw)
To: xen-devel; +Cc: Julien Grall, ian.campbell, stefano.stabellini
The variable new_data is initialized to NULL and free but never
allocated neither used.
Signed-off-by: Julien Grall <julien.grall@citrix.com>
---
xen/arch/arm/domain_build.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index eb93a3a..0c3441a 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -415,7 +415,6 @@ static int write_properties(struct domain *d, struct kernel_info *kinfo,
dt_for_each_property_node (node, prop)
{
const void *prop_data = prop->value;
- void *new_data = NULL;
u32 prop_len = prop->length;
/*
@@ -471,8 +470,6 @@ static int write_properties(struct domain *d, struct kernel_info *kinfo,
res = fdt_property(kinfo->fdt, prop->name, prop_data, prop_len);
- xfree(new_data);
-
if ( res )
return res;
}
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xen/arm: domain_build: Removed unused variable in write_properties
2015-10-14 9:34 [PATCH] xen/arm: domain_build: Removed unused variable in write_properties Julien Grall
@ 2015-10-14 10:48 ` Ian Campbell
0 siblings, 0 replies; 2+ messages in thread
From: Ian Campbell @ 2015-10-14 10:48 UTC (permalink / raw)
To: Julien Grall, xen-devel; +Cc: stefano.stabellini
On Wed, 2015-10-14 at 10:34 +0100, Julien Grall wrote:
> The variable new_data is initialized to NULL and free but never
> allocated neither used.
>
> Signed-off-by: Julien Grall <julien.grall@citrix.com>
Acked + applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-14 10:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-14 9:34 [PATCH] xen/arm: domain_build: Removed unused variable in write_properties Julien Grall
2015-10-14 10:48 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.