From: Ed Bartosh <ed.bartosh@linux.intel.com>
To: toaster@lists.yoctoproject.org
Subject: [review-request][PATCH] toaster: fixed crash in store_started_task
Date: Wed, 14 Oct 2015 14:37:17 +0300 [thread overview]
Message-ID: <1444822637-11441-1-git-send-email-ed.bartosh@linux.intel.com> (raw)
get_update_recipe_object was called with a parameter 'must_exist' set
to True, which causes it to raise this exception:
NotExisting("Recipe object created when expected to exist"
Obviously recipe was expected to exist for some reason, but that
changed. Probably order of events from bitbake changed in a way
that when this event comes to toastergui there is no other events
came yet that would cause recipe to be created.
Removed must_exist parameter from the call solved the issue.
Now Toaster UI shows a lot more info about command line builds.
[YOCTO #8279]
Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
---
bitbake/lib/bb/ui/buildinfohelper.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bitbake/lib/bb/ui/buildinfohelper.py b/bitbake/lib/bb/ui/buildinfohelper.py
index a8c884d..1571065 100644
--- a/bitbake/lib/bb/ui/buildinfohelper.py
+++ b/bitbake/lib/bb/ui/buildinfohelper.py
@@ -1021,7 +1021,7 @@ class BuildInfoHelper(object):
identifier = event.taskfile + ":" + event.taskname
recipe_information = self._get_recipe_information_from_taskfile(event.taskfile)
- recipe = self.orm_wrapper.get_update_recipe_object(recipe_information, True)
+ recipe = self.orm_wrapper.get_update_recipe_object(recipe_information)
task_information = self._get_task_information(event, recipe)
task_information['outcome'] = Task.OUTCOME_NA
--
2.1.4
reply other threads:[~2015-10-14 11:37 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444822637-11441-1-git-send-email-ed.bartosh@linux.intel.com \
--to=ed.bartosh@linux.intel.com \
--cc=toaster@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.