All of lore.kernel.org
 help / color / mirror / Atom feed
* [review-request][PATCH] toaster: fixed crash in store_started_task
@ 2015-10-14 11:37 Ed Bartosh
  0 siblings, 0 replies; only message in thread
From: Ed Bartosh @ 2015-10-14 11:37 UTC (permalink / raw)
  To: toaster

get_update_recipe_object was called with a parameter 'must_exist' set
to True, which causes it to raise this exception:
 NotExisting("Recipe object created when expected to exist"

Obviously recipe was expected to exist for some reason, but that
changed. Probably order of events from bitbake changed in a way
that when this event comes to toastergui there is no other events
came yet that would cause recipe to be created.

Removed must_exist parameter from the call solved the issue.
Now Toaster UI shows a lot more info about command line builds.

[YOCTO #8279]

Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
---
 bitbake/lib/bb/ui/buildinfohelper.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bitbake/lib/bb/ui/buildinfohelper.py b/bitbake/lib/bb/ui/buildinfohelper.py
index a8c884d..1571065 100644
--- a/bitbake/lib/bb/ui/buildinfohelper.py
+++ b/bitbake/lib/bb/ui/buildinfohelper.py
@@ -1021,7 +1021,7 @@ class BuildInfoHelper(object):
         identifier = event.taskfile + ":" + event.taskname
 
         recipe_information = self._get_recipe_information_from_taskfile(event.taskfile)
-        recipe = self.orm_wrapper.get_update_recipe_object(recipe_information, True)
+        recipe = self.orm_wrapper.get_update_recipe_object(recipe_information)
 
         task_information = self._get_task_information(event, recipe)
         task_information['outcome'] = Task.OUTCOME_NA
-- 
2.1.4



^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2015-10-14 11:37 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-14 11:37 [review-request][PATCH] toaster: fixed crash in store_started_task Ed Bartosh

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.