* [PATCH] libxc: Initialize vcpu context for 64-bit PVH VCPUs
@ 2015-10-15 14:44 Boris Ostrovsky
2015-10-15 14:45 ` Roger Pau Monné
2015-10-15 14:46 ` Wei Liu
0 siblings, 2 replies; 5+ messages in thread
From: Boris Ostrovsky @ 2015-10-15 14:44 UTC (permalink / raw)
To: ian.jackson, stefano.stabellini, ian.campbell, wei.liu2
Cc: boris.ostrovsky, xen-devel, roger.pau
Commit 5b921b49f08 ("libxc: rework BSP initialization") forgot to call
xc_vcpu_setcontext() for 64-bit PVH VCPUs.
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
---
Once again, with correctly spelled list address.
tools/libxc/xc_dom_x86.c | 24 ++++++++++++------------
1 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/tools/libxc/xc_dom_x86.c b/tools/libxc/xc_dom_x86.c
index 034abe0..4c4182f 100644
--- a/tools/libxc/xc_dom_x86.c
+++ b/tools/libxc/xc_dom_x86.c
@@ -810,18 +810,18 @@ static int vcpu_x86_64(struct xc_dom_image *dom)
DOMPRINTF("%s: cr3: pfn 0x%" PRIpfn " mfn 0x%" PRIpfn "",
__FUNCTION__, dom->pgtables_seg.pfn, cr3_pfn);
- if ( dom->pvh_enabled )
- return 0;
-
- ctxt->user_regs.ds = FLAT_KERNEL_DS_X86_64;
- ctxt->user_regs.es = FLAT_KERNEL_DS_X86_64;
- ctxt->user_regs.fs = FLAT_KERNEL_DS_X86_64;
- ctxt->user_regs.gs = FLAT_KERNEL_DS_X86_64;
- ctxt->user_regs.ss = FLAT_KERNEL_SS_X86_64;
- ctxt->user_regs.cs = FLAT_KERNEL_CS_X86_64;
+ if ( !dom->pvh_enabled )
+ {
+ ctxt->user_regs.ds = FLAT_KERNEL_DS_X86_64;
+ ctxt->user_regs.es = FLAT_KERNEL_DS_X86_64;
+ ctxt->user_regs.fs = FLAT_KERNEL_DS_X86_64;
+ ctxt->user_regs.gs = FLAT_KERNEL_DS_X86_64;
+ ctxt->user_regs.ss = FLAT_KERNEL_SS_X86_64;
+ ctxt->user_regs.cs = FLAT_KERNEL_CS_X86_64;
- ctxt->kernel_ss = ctxt->user_regs.ss;
- ctxt->kernel_sp = ctxt->user_regs.esp;
+ ctxt->kernel_ss = ctxt->user_regs.ss;
+ ctxt->kernel_sp = ctxt->user_regs.esp;
+ }
rc = xc_vcpu_setcontext(dom->xch, dom->guest_domid, 0, &any_ctx);
if ( rc != 0 )
--
1.7.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] libxc: Initialize vcpu context for 64-bit PVH VCPUs
2015-10-15 14:44 [PATCH] libxc: Initialize vcpu context for 64-bit PVH VCPUs Boris Ostrovsky
@ 2015-10-15 14:45 ` Roger Pau Monné
2015-10-15 14:51 ` Boris Ostrovsky
2015-10-15 14:46 ` Wei Liu
1 sibling, 1 reply; 5+ messages in thread
From: Roger Pau Monné @ 2015-10-15 14:45 UTC (permalink / raw)
To: Boris Ostrovsky, ian.jackson, stefano.stabellini, ian.campbell,
wei.liu2
Cc: xen-devel
El 15/10/15 a les 16.44, Boris Ostrovsky ha escrit:
> Commit 5b921b49f08 ("libxc: rework BSP initialization") forgot to call
> xc_vcpu_setcontext() for 64-bit PVH VCPUs.
>
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Ouch, my bad:
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
32bit seem to be fine though.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] libxc: Initialize vcpu context for 64-bit PVH VCPUs
2015-10-15 14:45 ` Roger Pau Monné
@ 2015-10-15 14:51 ` Boris Ostrovsky
0 siblings, 0 replies; 5+ messages in thread
From: Boris Ostrovsky @ 2015-10-15 14:51 UTC (permalink / raw)
To: Roger Pau Monné, ian.jackson, stefano.stabellini,
ian.campbell, wei.liu2
Cc: xen-devel
On 10/15/2015 10:45 AM, Roger Pau Monné wrote:
> El 15/10/15 a les 16.44, Boris Ostrovsky ha escrit:
>> Commit 5b921b49f08 ("libxc: rework BSP initialization") forgot to call
>> xc_vcpu_setcontext() for 64-bit PVH VCPUs.
>>
>> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Ouch, my bad:
>
> Acked-by: Roger Pau Monné <roger.pau@citrix.com>
>
> 32bit seem to be fine though.
>
I haven't tested it but it does look OK.
-boris
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] libxc: Initialize vcpu context for 64-bit PVH VCPUs
2015-10-15 14:44 [PATCH] libxc: Initialize vcpu context for 64-bit PVH VCPUs Boris Ostrovsky
2015-10-15 14:45 ` Roger Pau Monné
@ 2015-10-15 14:46 ` Wei Liu
2015-10-15 15:29 ` Ian Campbell
1 sibling, 1 reply; 5+ messages in thread
From: Wei Liu @ 2015-10-15 14:46 UTC (permalink / raw)
To: Boris Ostrovsky
Cc: wei.liu2, ian.campbell, stefano.stabellini, ian.jackson,
xen-devel, roger.pau
On Thu, Oct 15, 2015 at 10:44:26AM -0400, Boris Ostrovsky wrote:
> Commit 5b921b49f08 ("libxc: rework BSP initialization") forgot to call
> xc_vcpu_setcontext() for 64-bit PVH VCPUs.
>
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] libxc: Initialize vcpu context for 64-bit PVH VCPUs
2015-10-15 14:46 ` Wei Liu
@ 2015-10-15 15:29 ` Ian Campbell
0 siblings, 0 replies; 5+ messages in thread
From: Ian Campbell @ 2015-10-15 15:29 UTC (permalink / raw)
To: Wei Liu, Boris Ostrovsky
Cc: xen-devel, roger.pau, ian.jackson, stefano.stabellini
On Thu, 2015-10-15 at 15:46 +0100, Wei Liu wrote:
> On Thu, Oct 15, 2015 at 10:44:26AM -0400, Boris Ostrovsky wrote:
> > Commit 5b921b49f08 ("libxc: rework BSP initialization") forgot to call
> > xc_vcpu_setcontext() for 64-bit PVH VCPUs.
> >
> > Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>
> Acked-by: Wei Liu <wei.liu2@citrix.com>
Applied w/ this + Roger's ack.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-10-15 15:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-15 14:44 [PATCH] libxc: Initialize vcpu context for 64-bit PVH VCPUs Boris Ostrovsky
2015-10-15 14:45 ` Roger Pau Monné
2015-10-15 14:51 ` Boris Ostrovsky
2015-10-15 14:46 ` Wei Liu
2015-10-15 15:29 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.