All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Low <jason.low@hpe.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Jason Low <jason.low2@hp.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org, Oleg Nesterov <oleg@redhat.com>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Davidlohr Bueso <dave@stgolabs.net>,
	Steven Rostedt <rostedt@goodmis.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	George Spelvin <linux@horizon.com>,
	hideaki.kimura@hpe.com, terry.rudd@hpe.com, scott.norton@hpe.com
Subject: Re: [PATCH v2 0/4] timer: Improve itimers scalability
Date: Fri, 16 Oct 2015 10:34:13 -0700	[thread overview]
Message-ID: <1445016853.2517.16.camel@j-VirtualBox> (raw)
In-Reply-To: <20151016071202.GA20129@gmail.com>

On Fri, 2015-10-16 at 09:12 +0200, Ingo Molnar wrote:
> * Jason Low <jason.low@hpe.com> wrote:
> 
> > > > With this patch set (along with commit 1018016c706f mentioned above),
> > > > the performance hit of itimers almost completely goes away on the
> > > > 16 socket system.
> > > > 
> > > > Jason Low (4):
> > > >   timer: Optimize fastpath_timer_check()
> > > >   timer: Check thread timers only when there are active thread timers
> > > >   timer: Convert cputimer->running to bool
> > > >   timer: Reduce unnecessary sighand lock contention
> > > > 
> > > >  include/linux/init_task.h      |    3 +-
> > > >  include/linux/sched.h          |    9 ++++--
> > > >  kernel/fork.c                  |    2 +-
> > > >  kernel/time/posix-cpu-timers.c |   63 ++++++++++++++++++++++++++++-----------
> > > >  4 files changed, 54 insertions(+), 23 deletions(-)
> > > 
> > > Is there some itimers benchmark that can be used to measure the effects of these 
> > > changes?
> > 
> > Yes, we also wrote a micro benchmark which generates cache misses and measures 
> > the average cost of each cache miss (with itimers enabled). We used this while 
> > writing and testing patches, since it takes a bit longer to set up and run the 
> > database.
> 
> Mind posting it, so that people can stick it into a new 'perf bench timer' 
> subcommand, and/or reproduce your results with it?

Yes, sure. At the moment, this micro benchmark is written in C++ and
integrated with the database code. We can look into rewriting it into a
more general program so that it can be included in perf.

Thanks,
Jason


  reply	other threads:[~2015-10-16 17:34 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-14 19:07 [PATCH v2 0/4] timer: Improve itimers scalability Jason Low
2015-10-14 19:07 ` [PATCH v2 1/4] timer: Optimize fastpath_timer_check() Jason Low
2015-10-15  9:27   ` [tip:timers/core] posix_cpu_timer: Optimize fastpath_timer_check( ) tip-bot for Jason Low
2015-10-14 19:07 ` [PATCH v2 2/4] timer: Check thread timers only when there are active thread timers Jason Low
2015-10-15  9:28   ` [tip:timers/core] posix_cpu_timer: " tip-bot for Jason Low
2015-10-14 19:07 ` [PATCH v2 3/4] timer: Convert cputimer->running to bool Jason Low
2015-10-15  9:28   ` [tip:timers/core] posix_cpu_timer: Convert cputimer-> running " tip-bot for Jason Low
2015-10-14 19:07 ` [PATCH v2 4/4] timer: Reduce unnecessary sighand lock contention Jason Low
2015-10-15  9:28   ` [tip:timers/core] posix_cpu_timer: " tip-bot for Jason Low
2015-10-14 21:18 ` [PATCH v2 0/4] timer: Improve itimers scalability George Spelvin
2015-10-15 12:30   ` Frederic Weisbecker
2015-10-15 19:00   ` Jason Low
2015-10-15  8:47 ` Ingo Molnar
2015-10-15 19:01   ` Jason Low
2015-10-16  7:12     ` Ingo Molnar
2015-10-16 17:34       ` Jason Low [this message]
2015-10-16 17:46         ` Hideaki Kimura

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1445016853.2517.16.camel@j-VirtualBox \
    --to=jason.low@hpe.com \
    --cc=akpm@linux-foundation.org \
    --cc=dave@stgolabs.net \
    --cc=fweisbec@gmail.com \
    --cc=hideaki.kimura@hpe.com \
    --cc=jason.low2@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@horizon.com \
    --cc=mingo@kernel.org \
    --cc=oleg@redhat.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=scott.norton@hpe.com \
    --cc=terry.rudd@hpe.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.