From: tip-bot for Jason Low <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: hpa@zytor.com, linux-kernel@vger.kernel.org, linux@horizon.com,
tglx@linutronix.de, jason.low2@hp.com, mingo@kernel.org,
peterz@infradead.org, dave@stgolabs.net, rostedt@goodmis.org,
oleg@redhat.com, paulmck@linux.vnet.ibm.com, fweisbec@gmail.com
Subject: [tip:timers/core] posix_cpu_timer: Optimize fastpath_timer_check( )
Date: Thu, 15 Oct 2015 02:27:39 -0700 [thread overview]
Message-ID: <tip-7c177d994eb9637302b79e80d331f48dfbe26368@git.kernel.org> (raw)
In-Reply-To: <1444849677-29330-2-git-send-email-jason.low2@hp.com>
Commit-ID: 7c177d994eb9637302b79e80d331f48dfbe26368
Gitweb: http://git.kernel.org/tip/7c177d994eb9637302b79e80d331f48dfbe26368
Author: Jason Low <jason.low2@hp.com>
AuthorDate: Wed, 14 Oct 2015 12:07:53 -0700
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Thu, 15 Oct 2015 11:23:41 +0200
posix_cpu_timer: Optimize fastpath_timer_check()
In fastpath_timer_check(), the task_cputime() function is always
called to compute the utime and stime values. However, this is not
necessary if there are no per-thread timers to check for. This patch
modifies the code such that we compute the task_cputime values only
when there are per-thread timers set.
Signed-off-by: Jason Low <jason.low2@hp.com>
Reviewed-by: Oleg Nesterov <oleg@redhat.com>
Reviewed-by: Frederic Weisbecker <fweisbec@gmail.com>
Reviewed-by: Davidlohr Bueso <dave@stgolabs.net>
Reviewed-by: George Spelvin <linux@horizon.com>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: hideaki.kimura@hpe.com
Cc: terry.rudd@hpe.com
Cc: scott.norton@hpe.com
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1444849677-29330-2-git-send-email-jason.low2@hp.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
kernel/time/posix-cpu-timers.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/kernel/time/posix-cpu-timers.c b/kernel/time/posix-cpu-timers.c
index 892e3da..aa4b6f4 100644
--- a/kernel/time/posix-cpu-timers.c
+++ b/kernel/time/posix-cpu-timers.c
@@ -1117,17 +1117,12 @@ static inline int task_cputime_expired(const struct task_cputime *sample,
static inline int fastpath_timer_check(struct task_struct *tsk)
{
struct signal_struct *sig;
- cputime_t utime, stime;
-
- task_cputime(tsk, &utime, &stime);
if (!task_cputime_zero(&tsk->cputime_expires)) {
- struct task_cputime task_sample = {
- .utime = utime,
- .stime = stime,
- .sum_exec_runtime = tsk->se.sum_exec_runtime
- };
+ struct task_cputime task_sample;
+ task_cputime(tsk, &task_sample.utime, &task_sample.stime);
+ task_sample.sum_exec_runtime = tsk->se.sum_exec_runtime;
if (task_cputime_expired(&task_sample, &tsk->cputime_expires))
return 1;
}
next prev parent reply other threads:[~2015-10-15 9:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-14 19:07 [PATCH v2 0/4] timer: Improve itimers scalability Jason Low
2015-10-14 19:07 ` [PATCH v2 1/4] timer: Optimize fastpath_timer_check() Jason Low
2015-10-15 9:27 ` tip-bot for Jason Low [this message]
2015-10-14 19:07 ` [PATCH v2 2/4] timer: Check thread timers only when there are active thread timers Jason Low
2015-10-15 9:28 ` [tip:timers/core] posix_cpu_timer: " tip-bot for Jason Low
2015-10-14 19:07 ` [PATCH v2 3/4] timer: Convert cputimer->running to bool Jason Low
2015-10-15 9:28 ` [tip:timers/core] posix_cpu_timer: Convert cputimer-> running " tip-bot for Jason Low
2015-10-14 19:07 ` [PATCH v2 4/4] timer: Reduce unnecessary sighand lock contention Jason Low
2015-10-15 9:28 ` [tip:timers/core] posix_cpu_timer: " tip-bot for Jason Low
2015-10-14 21:18 ` [PATCH v2 0/4] timer: Improve itimers scalability George Spelvin
2015-10-15 12:30 ` Frederic Weisbecker
2015-10-15 19:00 ` Jason Low
2015-10-15 8:47 ` Ingo Molnar
2015-10-15 19:01 ` Jason Low
2015-10-16 7:12 ` Ingo Molnar
2015-10-16 17:34 ` Jason Low
2015-10-16 17:46 ` Hideaki Kimura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-7c177d994eb9637302b79e80d331f48dfbe26368@git.kernel.org \
--to=tipbot@zytor.com \
--cc=dave@stgolabs.net \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=jason.low2@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=linux@horizon.com \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.