Patch "security: fix typo in security_task_prctl" has been added to the 4.2-stable tree

Patch "security: fix typo in security_task_prctl" has been added to the 4.2-stable tree

[gregkh]

This is a note to let you know that I've just added the patch titled

    security: fix typo in security_task_prctl

to the 4.2-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     security-fix-typo-in-security_task_prctl.patch
and it can be found in the queue-4.2 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From b7f76ea2ef6739ee484a165ffbac98deb855d3d3 Mon Sep 17 00:00:00 2001
From: Jann Horn <jann@thejh.net>
Date: Fri, 18 Sep 2015 23:41:23 +0200
Subject: security: fix typo in security_task_prctl

From: Jann Horn <jann@thejh.net>

commit b7f76ea2ef6739ee484a165ffbac98deb855d3d3 upstream.

Signed-off-by: Jann Horn <jann@thejh.net>
Reviewed-by: Andy Lutomirski <luto@kernel.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 include/linux/security.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/include/linux/security.h
+++ b/include/linux/security.h
@@ -946,7 +946,7 @@ static inline int security_task_prctl(in
 				      unsigned long arg4,
 				      unsigned long arg5)
 {
-	return cap_task_prctl(option, arg2, arg3, arg3, arg5);
+	return cap_task_prctl(option, arg2, arg3, arg4, arg5);
 }
 
 static inline void security_task_to_inode(struct task_struct *p, struct inode *inode)


Patches currently in stable-queue which might be from jann@thejh.net are

queue-4.2/security-fix-typo-in-security_task_prctl.patch

Re: Patch "security: fix typo in security_task_prctl" has been added to the 4.2-stable tree

[Andy Lutomirski]

On Oct 17, 2015 3:04 PM, <gregkh@linuxfoundation.org> wrote:
>
>
> This is a note to let you know that I've just added the patch titled
>
>     security: fix typo in security_task_prctl
>
> to the 4.2-stable tree which can be found at:
>     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

It should be safe, but I don't think the bug is observable in any
released kernel.  Jann noticed it because it interferes with ambient
capabilities, but those are new in 4.3.

--Andy

Re: Patch "security: fix typo in security_task_prctl" has been added to the 4.2-stable tree

[Greg KH]

On Sat, Oct 17, 2015 at 09:30:50PM -0700, Andy Lutomirski wrote:
> On Oct 17, 2015 3:04 PM, <gregkh@linuxfoundation.org> wrote:
> >
> >
> > This is a note to let you know that I've just added the patch titled
> >
> >     security: fix typo in security_task_prctl
> >
> > to the 4.2-stable tree which can be found at:
> >     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> 
> It should be safe, but I don't think the bug is observable in any
> released kernel.  Jann noticed it because it interferes with ambient
> capabilities, but those are new in 4.3.

Yeah, I figured it was just a good thing to get fixed no matter what :)

thanks for the review,

greg k-h