[OSSTEST PATCH] ts-host-ping-check: Properly append the ping output

[OSSTEST PATCH] ts-host-ping-check: Properly append the ping output

[Ian Jackson]

On Linux opening /dev/stderr produces a non-O_APPEND open-file, with
its own file position pointer, even if stderr was opened O_APPEND.

As a result the logfile from this step would be mangled.  So use
`tee -a'.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
 ts-host-ping-check |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ts-host-ping-check b/ts-host-ping-check
index ca8920c..f10e73c 100755
--- a/ts-host-ping-check
+++ b/ts-host-ping-check
@@ -28,7 +28,7 @@ our $ho= selecthost($whhost);
 
 exit 0 if $ho->{SharedReady};
 
-$_ = `ping -D -i 0.2 -c 100 $ho->{Ip} | tee /dev/stderr`;
+$_ = `ping -D -i 0.2 -c 100 $ho->{Ip} | tee -a /dev/stderr`;
 
 m/\b([0-9.]+)% packet loss\b/ or die "$_ ?";
 
-- 
1.7.10.4

Re: [OSSTEST PATCH] ts-host-ping-check: Properly append the ping output

[Ian Campbell]

On Mon, 2015-10-19 at 17:14 +0100, Ian Jackson wrote:
> On Linux opening /dev/stderr produces a non-O_APPEND open-file, with
> its own file position pointer, even if stderr was opened O_APPEND.
> 
> As a result the logfile from this step would be mangled.  So use
> `tee -a'.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>

Acked-by: Ian Campbell <ian.campbell@citrix.com>