BAT: why MAX_NUMBER_OF_CHANNELS and CHANNEL_MAX separate?

BAT: why MAX_NUMBER_OF_CHANNELS and CHANNEL_MAX separate?

[Caleb Crome]

Hi,
   I'm starting to bring up BAT on my board to see if it's going to work for me.

I'm starting from https://github.com/hanlui/bat, is that the correct
place to start from?

I'm bringing up a 16 channel board, so need BAT to support more
channels (currently it supports only 2).

bat/include/common.h has the following defines:

#define MAX_NUMBER_OF_CHANNELS          2
#define CHANNEL_MAX                     2
#define CHANNEL_MIN                     1

Is there any reason we need both MAX_NUMBER_OF_CHANNELS and
CHANNEL_MAX?  They sure seem like they can be merged to me.

Once I get the program up and running, I'll add the ramp test, and
start thinking about the other tests we talked about.

Thanks,
 -Caleb

Re: BAT: why MAX_NUMBER_OF_CHANNELS and CHANNEL_MAX separate?

[Liam Girdwood]

On Tue, 2015-10-20 at 08:36 -0700, Caleb Crome wrote:
> Hi,
>    I'm starting to bring up BAT on my board to see if it's going to work for me.
> 
> I'm starting from https://github.com/hanlui/bat, is that the correct
> place to start from?

I think that's Han's old git repo. He has a dev branch here :-

https://github.com/01org/bat

and bat support is now also in alsa-utils git too.

> 
> I'm bringing up a 16 channel board, so need BAT to support more
> channels (currently it supports only 2).
> 
> bat/include/common.h has the following defines:
> 
> #define MAX_NUMBER_OF_CHANNELS          2
> #define CHANNEL_MAX                     2
> #define CHANNEL_MIN                     1
> 
> Is there any reason we need both MAX_NUMBER_OF_CHANNELS and
> CHANNEL_MAX?  They sure seem like they can be merged to me.
> 

Yeah, this looks like it's duplicated to me. Han ?

> Once I get the program up and running, I'll add the ramp test, and
> start thinking about the other tests we talked about.
> 

Ok, thanks !

Liam

> Thanks,
>  -Caleb

Re: BAT: why MAX_NUMBER_OF_CHANNELS and CHANNEL_MAX separate?

[Takashi Iwai]

On Tue, 20 Oct 2015 17:41:13 +0200,
Liam Girdwood wrote:
> 
> On Tue, 2015-10-20 at 08:36 -0700, Caleb Crome wrote:
> > Hi,
> >    I'm starting to bring up BAT on my board to see if it's going to work for me.
> > 
> > I'm starting from https://github.com/hanlui/bat, is that the correct
> > place to start from?
> 
> I think that's Han's old git repo. He has a dev branch here :-
> 
> https://github.com/01org/bat
> 
> and bat support is now also in alsa-utils git too.

Right, please follow alsa-utils git repo for avoiding confusion.


Takashi

Re: BAT: why MAX_NUMBER_OF_CHANNELS and CHANNEL_MAX separate?

[Caleb Crome]

On Tue, Oct 20, 2015 at 8:48 AM, Takashi Iwai <tiwai@suse.de> wrote:
> On Tue, 20 Oct 2015 17:41:13 +0200,
> Liam Girdwood wrote:
>>
>> On Tue, 2015-10-20 at 08:36 -0700, Caleb Crome wrote:
>> > Hi,
>> >    I'm starting to bring up BAT on my board to see if it's going to work for me.
>> >
>> > I'm starting from https://github.com/hanlui/bat, is that the correct
>> > place to start from?
>>
>> I think that's Han's old git repo. He has a dev branch here :-
>>
>> https://github.com/01org/bat
>>
>> and bat support is now also in alsa-utils git too.
>
> Right, please follow alsa-utils git repo for avoiding confusion.
>
>
> Takashi
Wait, should I use
  https://github.com/01org/bat
or
 git://git.alsa-project.org/alsa-utils.git

I'm trying to compile git://git.alsa-project.org/alsa-utils.git, but
having a terrible time getting everything to compile.

After running the ./gitcompile script, I get a few warning/error
messages but it does finally generate a ./configure script.  However,
./configure fails with the following:

# ./configure
...
checking for pthread_create in -lpthread... yes
checking for librt... checking for clock_gettime in -lrt... yes
checking for xmlto... yes
./configure: line 7984: udev: command not found
checking for ANSI C header files... yes
./configure: line 8119: syntax error near unexpected token `NCURSESW,'
./configure: line 8119: `        PKG_CHECK_MODULES(NCURSESW, ncursesw,'


Both git repos have the same issue for me.

I'm running on an arm (Freescale i.MX6)
aclocal version 1.15, gettextize version 0.19.6, autoheader version
2.69, automake version 1.15, autoconf version 2.69,

BTW, on the OP, it appears that MAX_NUMBER_OF_CHANNELS has already been removed.

Thanks,
-Caleb

Re: BAT: why MAX_NUMBER_OF_CHANNELS and CHANNEL_MAX separate?

[Takashi Iwai]

On Tue, 20 Oct 2015 19:39:27 +0200,
Caleb Crome wrote:
> 
> On Tue, Oct 20, 2015 at 8:48 AM, Takashi Iwai <tiwai@suse.de> wrote:
> > On Tue, 20 Oct 2015 17:41:13 +0200,
> > Liam Girdwood wrote:
> >>
> >> On Tue, 2015-10-20 at 08:36 -0700, Caleb Crome wrote:
> >> > Hi,
> >> >    I'm starting to bring up BAT on my board to see if it's going to work for me.
> >> >
> >> > I'm starting from https://github.com/hanlui/bat, is that the correct
> >> > place to start from?
> >>
> >> I think that's Han's old git repo. He has a dev branch here :-
> >>
> >> https://github.com/01org/bat
> >>
> >> and bat support is now also in alsa-utils git too.
> >
> > Right, please follow alsa-utils git repo for avoiding confusion.
> >
> >
> > Takashi
> Wait, should I use
>   https://github.com/01org/bat
> or
>  git://git.alsa-project.org/alsa-utils.git
> 
> I'm trying to compile git://git.alsa-project.org/alsa-utils.git, but
> having a terrible time getting everything to compile.
> 
> After running the ./gitcompile script, I get a few warning/error
> messages but it does finally generate a ./configure script.  However,
> ./configure fails with the following:
> 
> # ./configure
> ...
> checking for pthread_create in -lpthread... yes
> checking for librt... checking for clock_gettime in -lrt... yes
> checking for xmlto... yes
> ./configure: line 7984: udev: command not found
> checking for ANSI C header files... yes
> ./configure: line 8119: syntax error near unexpected token `NCURSESW,'
> ./configure: line 8119: `        PKG_CHECK_MODULES(NCURSESW, ncursesw,'

Did you install pkgconfig (or pkg-config)?  It's almost a must for
building the stuff with GNU auto-tools nowadays.


Takashi

Re: BAT: why MAX_NUMBER_OF_CHANNELS and CHANNEL_MAX separate?

[Caleb Crome]

On Tue, Oct 20, 2015 at 11:01 AM, Takashi Iwai <tiwai@suse.de> wrote:
> On Tue, 20 Oct 2015 19:39:27 +0200,
> Caleb Crome wrote:
>>
>> On Tue, Oct 20, 2015 at 8:48 AM, Takashi Iwai <tiwai@suse.de> wrote:
>> > On Tue, 20 Oct 2015 17:41:13 +0200,
>> > Liam Girdwood wrote:
>> >>
>> >> On Tue, 2015-10-20 at 08:36 -0700, Caleb Crome wrote:
>> >> > Hi,
>> >> >    I'm starting to bring up BAT on my board to see if it's going to work for me.
>> >> >
>> >> > I'm starting from https://github.com/hanlui/bat, is that the correct
>> >> > place to start from?
>> >>
>> >> I think that's Han's old git repo. He has a dev branch here :-
>> >>
>> >> https://github.com/01org/bat
>> >>
>> >> and bat support is now also in alsa-utils git too.
>> >
>> > Right, please follow alsa-utils git repo for avoiding confusion.
>> >
>> >
>> > Takashi
>> Wait, should I use
>>   https://github.com/01org/bat
>> or
>>  git://git.alsa-project.org/alsa-utils.git
>>
>> I'm trying to compile git://git.alsa-project.org/alsa-utils.git, but
>> having a terrible time getting everything to compile.
>>
>> After running the ./gitcompile script, I get a few warning/error
>> messages but it does finally generate a ./configure script.  However,
>> ./configure fails with the following:
>>
>> # ./configure
>> ...
>> checking for pthread_create in -lpthread... yes
>> checking for librt... checking for clock_gettime in -lrt... yes
>> checking for xmlto... yes
>> ./configure: line 7984: udev: command not found
>> checking for ANSI C header files... yes
>> ./configure: line 8119: syntax error near unexpected token `NCURSESW,'
>> ./configure: line 8119: `        PKG_CHECK_MODULES(NCURSESW, ncursesw,'
>
> Did you install pkgconfig (or pkg-config)?  It's almost a must for
> building the stuff with GNU auto-tools nowadays.
>
>
> Takashi

Et Voila!  That works.  Thanks Takashi!

-Caleb