RFC: creating our own build logs

RFC: creating our own build logs

[Smith, Elliot]

[-- Attachment #1: Type: text/plain, Size: 1003 bytes --]

I've done some work on a branch which creates per-build logs for Toaster,
downloadable from the build dashboard:

poky-contrib, elliot/toaster/wrong_log-8373-v2

(to fix https://bugzilla.yoctoproject.org/show_bug.cgi?id=8373)

The basic approach is to create our own log files (called
"build_<timestamp>") in the same directory bitbake uses. Each log file is
opened on BuildStarted and closed on BuildCompleted (or build failure). I
include some config context by looking variables up from the bitbake
server. The output doesn't exactly match bitbake's but is close.

I've tested with command-line and Toaster-triggered builds, and it seems to
be working fine, but I'd like a few other people to test it, as well as
comment on the approach. The commit on the tip of the branch explains what
I've done in more detail.

I will send a formal review request if we're agreed on this approach.

Thanks.
Elliot

-- 
Elliot Smith
Software Engineer
Intel Open Source Technology Centre

[-- Attachment #2: Type: text/html, Size: 1377 bytes --]

Re: RFC: creating our own build logs

[Richard Purdie]

On Mon, 2015-10-19 at 18:52 +0100, Smith, Elliot wrote:
> I've done some work on a branch which creates per-build logs for
> Toaster, downloadable from the build dashboard:
>
> poky-contrib, elliot/toaster/wrong_log-8373-v2
>
> (to fix https://bugzilla.yoctoproject.org/show_bug.cgi?id=8373)

Seems reasonably, the only thing I wondered was whether we could somehow
capture the build header from the build rather than having to invent a
new function for toaster...

Cheers,

Richard

Re: RFC: creating our own build logs

[Smith, Elliot]

[-- Attachment #1: Type: text/plain, Size: 1044 bytes --]

On 20 October 2015 at 21:28, Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> On Mon, 2015-10-19 at 18:52 +0100, Smith, Elliot wrote:
> > I've done some work on a branch which creates per-build logs for
> > Toaster, downloadable from the build dashboard:
> >
> > poky-contrib, elliot/toaster/wrong_log-8373-v2
> >
> > (to fix https://bugzilla.yoctoproject.org/show_bug.cgi?id=8373)
>
> Seems reasonably, the only thing I wondered was whether we could somehow
> capture the build header from the build rather than having to invent a
> new function for toaster...
>

I'm not sure we can pick that up as it's written before the BuildStarted
event, which is the first thing toasterui knows about the build (unless
there's an earlier event we can capture).

I will investigate whether we can at least reuse the function which outputs
the header, which I think is in the .bbclass files.

Elliot


> Cheers,
>
> Richard
>
>
>


-- 
Elliot Smith
Software Engineer
Intel Open Source Technology Centre

[-- Attachment #2: Type: text/html, Size: 1830 bytes --]

Re: RFC: creating our own build logs

[Smith, Elliot]

[-- Attachment #1: Type: text/plain, Size: 1491 bytes --]

On 21 October 2015 at 10:53, Smith, Elliot <elliot.smith@intel.com> wrote:

> On 20 October 2015 at 21:28, Richard Purdie <
> richard.purdie@linuxfoundation.org> wrote:
>
>> On Mon, 2015-10-19 at 18:52 +0100, Smith, Elliot wrote:
>> > I've done some work on a branch which creates per-build logs for
>> > Toaster, downloadable from the build dashboard:
>> >
>> > poky-contrib, elliot/toaster/wrong_log-8373-v2
>> >
>> > (to fix https://bugzilla.yoctoproject.org/show_bug.cgi?id=8373)
>>
>> Seems reasonably, the only thing I wondered was whether we could somehow
>> capture the build header from the build rather than having to invent a
>> new function for toaster...
>>
>
> I'm not sure we can pick that up as it's written before the BuildStarted
> event, which is the first thing toasterui knows about the build (unless
> there's an earlier event we can capture).
>
> I will investigate whether we can at least reuse the function which
> outputs the header, which I think is in the .bbclass files.
>

In the end, Brian came up with a solution, which was to use the
ParseStarted event rather than the BuildStarted event. This means our log
files are gathering bitbake's output by the time the "Build Configuration"
is output, which means I can remove my code which duplicated that.

I posted a new version to the toaster mailing list for review.

Thanks for your feedback.
Elliot
-- 
Elliot Smith
Software Engineer
Intel Open Source Technology Centre

[-- Attachment #2: Type: text/html, Size: 2434 bytes --]

Re: RFC: creating our own build logs

[Brian Avery]

yay!
-b

On Thu, Oct 22, 2015 at 2:55 AM, Smith, Elliot <elliot.smith@intel.com> wrote:
> On 21 October 2015 at 10:53, Smith, Elliot <elliot.smith@intel.com> wrote:
>>
>> On 20 October 2015 at 21:28, Richard Purdie
>> <richard.purdie@linuxfoundation.org> wrote:
>>>
>>> On Mon, 2015-10-19 at 18:52 +0100, Smith, Elliot wrote:
>>> > I've done some work on a branch which creates per-build logs for
>>> > Toaster, downloadable from the build dashboard:
>>> >
>>> > poky-contrib, elliot/toaster/wrong_log-8373-v2
>>> >
>>> > (to fix https://bugzilla.yoctoproject.org/show_bug.cgi?id=8373)
>>>
>>> Seems reasonably, the only thing I wondered was whether we could somehow
>>> capture the build header from the build rather than having to invent a
>>> new function for toaster...
>>
>>
>> I'm not sure we can pick that up as it's written before the BuildStarted
>> event, which is the first thing toasterui knows about the build (unless
>> there's an earlier event we can capture).
>>
>> I will investigate whether we can at least reuse the function which
>> outputs the header, which I think is in the .bbclass files.
>
>
> In the end, Brian came up with a solution, which was to use the ParseStarted
> event rather than the BuildStarted event. This means our log files are
> gathering bitbake's output by the time the "Build Configuration" is output,
> which means I can remove my code which duplicated that.
>
> I posted a new version to the toaster mailing list for review.
>
> Thanks for your feedback.
> Elliot
> --
> Elliot Smith
> Software Engineer
> Intel Open Source Technology Centre
>
> --
> _______________________________________________
> toaster mailing list
> toaster@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster
>