* [PATCH] iw: Print help text to "set bitrates" in case of no args
@ 2015-10-21 12:11 Ola Olsson
2015-10-21 12:27 ` Johannes Berg
0 siblings, 1 reply; 3+ messages in thread
From: Ola Olsson @ 2015-10-21 12:11 UTC (permalink / raw)
To: johannes; +Cc: linux-wireless, Ola Olsson, Ola Olsson
Signed-off-by: Ola Olsson <ola.olsson@sonymobile.com>
---
bitrate.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/bitrate.c b/bitrate.c
index 4a026a4..974b49c 100644
--- a/bitrate.c
+++ b/bitrate.c
@@ -110,6 +110,9 @@ static int handle_bitrates(struct nl80211_state *state,
S_GI,
} parser_state = S_NONE;
+ if (argc == 0)
+ return 1;
+
for (i = 0; i < argc; i++) {
char *end;
double tmpd;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iw: Print help text to "set bitrates" in case of no args
2015-10-21 12:11 [PATCH] iw: Print help text to "set bitrates" in case of no args Ola Olsson
@ 2015-10-21 12:27 ` Johannes Berg
2015-10-21 12:32 ` Ola Olsson
0 siblings, 1 reply; 3+ messages in thread
From: Johannes Berg @ 2015-10-21 12:27 UTC (permalink / raw)
To: Ola Olsson; +Cc: linux-wireless, Ola Olsson
This is incorrect - the help states:
"Not passing any arguments would clear the existing mask (if any)."
johannes
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iw: Print help text to "set bitrates" in case of no args
2015-10-21 12:27 ` Johannes Berg
@ 2015-10-21 12:32 ` Ola Olsson
0 siblings, 0 replies; 3+ messages in thread
From: Ola Olsson @ 2015-10-21 12:32 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless, Ola Olsson
I totally missed that. You are right!
/Ola
On Wed, Oct 21, 2015 at 2:27 PM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> This is incorrect - the help states:
>
> "Not passing any arguments would clear the existing mask (if any)."
>
> johannes
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-21 12:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-21 12:11 [PATCH] iw: Print help text to "set bitrates" in case of no args Ola Olsson
2015-10-21 12:27 ` Johannes Berg
2015-10-21 12:32 ` Ola Olsson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.