* [OSSTEST PATCH] ap-push: Never push an empty revision
@ 2015-10-21 12:52 Ian Jackson
2015-10-21 13:20 ` Ian Campbell
0 siblings, 1 reply; 2+ messages in thread
From: Ian Jackson @ 2015-10-21 12:52 UTC (permalink / raw)
To: xen-devel; +Cc: Ian Jackson, Ian Campbell
ap-push should not be used to delete the target branch.
This safety catch will prevent accidentaly deletion of branches if
there is an undetected failure of whatever is generating the revision
to push.
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
ap-push | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/ap-push b/ap-push
index d2195f2..3011561 100755
--- a/ap-push
+++ b/ap-push
@@ -25,6 +25,10 @@ revision=$2
. ./cri-common
select_xenbranch
+if [ "x$revision" = x ]; then
+ echo >&2 "NOT pushing empty revision!"; exit 1
+fi
+
: ${TAG_LINUX2639:=tested/2.6.39.x}
. ./ap-common
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [OSSTEST PATCH] ap-push: Never push an empty revision
2015-10-21 12:52 [OSSTEST PATCH] ap-push: Never push an empty revision Ian Jackson
@ 2015-10-21 13:20 ` Ian Campbell
0 siblings, 0 replies; 2+ messages in thread
From: Ian Campbell @ 2015-10-21 13:20 UTC (permalink / raw)
To: Ian Jackson, xen-devel
On Wed, 2015-10-21 at 13:52 +0100, Ian Jackson wrote:
> ap-push should not be used to delete the target branch.
>
> This safety catch will prevent accidentaly deletion of branches if
"accidentally".
> there is an undetected failure of whatever is generating the revision
> to push.
>
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-21 13:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-21 12:52 [OSSTEST PATCH] ap-push: Never push an empty revision Ian Jackson
2015-10-21 13:20 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.