* [PATCH bluetooth-next] bluetooth: 6lowpan: fix NOHZ: local_softirq_pending
@ 2015-10-27 7:35 Alexander Aring
2015-10-27 8:15 ` Jukka Rissanen
2015-10-27 8:56 ` Marcel Holtmann
0 siblings, 2 replies; 3+ messages in thread
From: Alexander Aring @ 2015-10-27 7:35 UTC (permalink / raw)
To: linux-bluetooth; +Cc: kernel, Alexander Aring, Jukka Rissanen
Jukka reported about the following warning:
"NOHZ: local_softirq_pending 08"
I remember this warning and we had a similar issue when using workqueues
and calling netif_rx. See commit 5ff3fec ("mac802154: fix NOHZ
local_softirq_pending 08 warning").
This warning occurs when calling "netif_rx" inside the wrong context
(non softirq context). The net core api offers "netif_rx_ni" to call
netif_rx inside the correct softirq context.
Reported-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
Cc: Jukka Rissanen <jukka.rissanen@linux.intel.com>
Signed-off-by: Alexander Aring <alex.aring@gmail.com>
---
net/bluetooth/6lowpan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c
index d85af23..9e9cca3 100644
--- a/net/bluetooth/6lowpan.c
+++ b/net/bluetooth/6lowpan.c
@@ -263,7 +263,7 @@ static int give_skb_to_upper(struct sk_buff *skb, struct net_device *dev)
if (!skb_cp)
return NET_RX_DROP;
- return netif_rx(skb_cp);
+ return netif_rx_ni(skb_cp);
}
static int iphc_decompress(struct sk_buff *skb, struct net_device *netdev,
--
2.6.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH bluetooth-next] bluetooth: 6lowpan: fix NOHZ: local_softirq_pending
2015-10-27 7:35 [PATCH bluetooth-next] bluetooth: 6lowpan: fix NOHZ: local_softirq_pending Alexander Aring
@ 2015-10-27 8:15 ` Jukka Rissanen
2015-10-27 8:56 ` Marcel Holtmann
1 sibling, 0 replies; 3+ messages in thread
From: Jukka Rissanen @ 2015-10-27 8:15 UTC (permalink / raw)
To: Alexander Aring; +Cc: linux-bluetooth, kernel
I have verified that this works.
Acked-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
Cheers,
Jukka
On ti, 2015-10-27 at 08:35 +0100, Alexander Aring wrote:
> Jukka reported about the following warning:
>
> "NOHZ: local_softirq_pending 08"
>
> I remember this warning and we had a similar issue when using workqueues
> and calling netif_rx. See commit 5ff3fec ("mac802154: fix NOHZ
> local_softirq_pending 08 warning").
>
> This warning occurs when calling "netif_rx" inside the wrong context
> (non softirq context). The net core api offers "netif_rx_ni" to call
> netif_rx inside the correct softirq context.
>
> Reported-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
> Cc: Jukka Rissanen <jukka.rissanen@linux.intel.com>
> Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> ---
> net/bluetooth/6lowpan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c
> index d85af23..9e9cca3 100644
> --- a/net/bluetooth/6lowpan.c
> +++ b/net/bluetooth/6lowpan.c
> @@ -263,7 +263,7 @@ static int give_skb_to_upper(struct sk_buff *skb, struct net_device *dev)
> if (!skb_cp)
> return NET_RX_DROP;
>
> - return netif_rx(skb_cp);
> + return netif_rx_ni(skb_cp);
> }
>
> static int iphc_decompress(struct sk_buff *skb, struct net_device *netdev,
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH bluetooth-next] bluetooth: 6lowpan: fix NOHZ: local_softirq_pending
2015-10-27 7:35 [PATCH bluetooth-next] bluetooth: 6lowpan: fix NOHZ: local_softirq_pending Alexander Aring
2015-10-27 8:15 ` Jukka Rissanen
@ 2015-10-27 8:56 ` Marcel Holtmann
1 sibling, 0 replies; 3+ messages in thread
From: Marcel Holtmann @ 2015-10-27 8:56 UTC (permalink / raw)
To: Alexander Aring; +Cc: linux-bluetooth, kernel, Jukka Rissanen
Hi Alex,
> Jukka reported about the following warning:
>
> "NOHZ: local_softirq_pending 08"
>
> I remember this warning and we had a similar issue when using workqueues
> and calling netif_rx. See commit 5ff3fec ("mac802154: fix NOHZ
> local_softirq_pending 08 warning").
>
> This warning occurs when calling "netif_rx" inside the wrong context
> (non softirq context). The net core api offers "netif_rx_ni" to call
> netif_rx inside the correct softirq context.
>
> Reported-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
> Cc: Jukka Rissanen <jukka.rissanen@linux.intel.com>
> Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> ---
> net/bluetooth/6lowpan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-27 8:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-27 7:35 [PATCH bluetooth-next] bluetooth: 6lowpan: fix NOHZ: local_softirq_pending Alexander Aring
2015-10-27 8:15 ` Jukka Rissanen
2015-10-27 8:56 ` Marcel Holtmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.