From: Lu Baolu <baolu.lu@linux.intel.com>
To: Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Lu Baolu <baolu.lu@linux.intel.com>
Subject: [PATCH 04/12] usb: xhci: dbc: add support for Intel xHCI dbc quirk
Date: Wed, 28 Oct 2015 16:00:35 +0800 [thread overview]
Message-ID: <1446019243-5565-5-git-send-email-baolu.lu@linux.intel.com> (raw)
In-Reply-To: <1446019243-5565-1-git-send-email-baolu.lu@linux.intel.com>
On Intel platform, if the debug target is connected with debug
host, enabling DCE bit in command register leads to a hung bus
state. In the hung state, the host system will not see a port
connected status bit set. Hence debug target fails to be probed.
The state could be resolved by performing a port reset to the
debug port from the host xHCI. This patch introduces this work
around.
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
---
drivers/usb/early/xhci-dbc.c | 52 ++++++++++++++++++++++++++++++++++++++++++++
include/linux/usb/xhci-dbc.h | 2 ++
2 files changed, 54 insertions(+)
diff --git a/drivers/usb/early/xhci-dbc.c b/drivers/usb/early/xhci-dbc.c
index 22a1de9..6b23f09 100644
--- a/drivers/usb/early/xhci-dbc.c
+++ b/drivers/usb/early/xhci-dbc.c
@@ -255,6 +255,8 @@ static void __iomem *xdbc_map_pci_mmio(u32 bus,
xdbcp->bar = bar;
xdbcp->xhci_base = base;
xdbcp->xhci_length = sz64;
+ xdbcp->vendor = read_pci_config_16(bus, dev, func, PCI_VENDOR_ID);
+ xdbcp->device = read_pci_config_16(bus, dev, func, PCI_DEVICE_ID);
if (length)
*length = sz64;
@@ -651,6 +653,52 @@ static int xdbc_mem_init(void)
return 0;
}
+static void xdbc_reset_debug_port_callback(int cap_offset, void *data)
+{
+ u8 major;
+ u32 val, port_offset, port_count;
+ u32 cap_length;
+ void __iomem *ops_reg;
+ void __iomem *portsc;
+ int i;
+
+ val = readl(xdbcp->xhci_base + cap_offset);
+ major = (u8) XHCI_EXT_PORT_MAJOR(val);
+
+ /* only reset super-speed port */
+ if (major != 0x3)
+ return;
+
+ val = readl(xdbcp->xhci_base + cap_offset + 8);
+ port_offset = XHCI_EXT_PORT_OFF(val);
+ port_count = XHCI_EXT_PORT_COUNT(val);
+ xdbc_trace("Extcap Port offset %d count %d\n",
+ port_offset, port_count);
+
+ cap_length = readl(xdbcp->xhci_base) & 0xff;
+ ops_reg = xdbcp->xhci_base + cap_length;
+
+ port_offset--;
+ for (i = port_offset; i < (port_offset + port_count); i++) {
+ portsc = ops_reg + 0x400 + i * 0x10;
+ val = readl(portsc);
+ /* reset the port if CCS bit is cleared */
+ if (!(val & 0x1))
+ writel(val | (1 << 4), portsc);
+ }
+}
+
+static void xdbc_reset_debug_port(void)
+{
+ xdbc_walk_excap(xdbcp->bus,
+ xdbcp->dev,
+ xdbcp->func,
+ XHCI_EXT_CAPS_PROTOCOL,
+ false,
+ xdbc_reset_debug_port_callback,
+ NULL);
+}
+
/*
* xdbc_start: start DbC
*
@@ -669,6 +717,10 @@ static int xdbc_start(void)
return -ENODEV;
}
+ /* reset port to avoid bus hang */
+ if (xdbcp->vendor == PCI_VENDOR_ID_INTEL)
+ xdbc_reset_debug_port();
+
/* wait for port connection */
if (handshake(&xdbcp->xdbc_reg->portsc, PORTSC_CCS,
PORTSC_CCS, 5000000, 100) < 0) {
diff --git a/include/linux/usb/xhci-dbc.h b/include/linux/usb/xhci-dbc.h
index 153fb87..fc0ef9a 100644
--- a/include/linux/usb/xhci-dbc.h
+++ b/include/linux/usb/xhci-dbc.h
@@ -128,6 +128,8 @@ struct xdbc_state {
u32 dev;
u32 func;
u8 bar;
+ u16 vendor;
+ u16 device;
void __iomem *xhci_base;
size_t xhci_length;
#define XDBC_PCI_MAX_BUSES 256
--
2.1.4
next prev parent reply other threads:[~2015-10-28 8:01 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 8:00 [PATCH 00/12] usb: early: add support for early printk through USB3 debug port Lu Baolu
2015-10-28 8:00 ` [PATCH 01/12] usb: xhci: expose xhci extended capabilities via debugfs Lu Baolu
2015-10-28 9:27 ` Oliver Neukum
2015-10-29 1:18 ` Lu, Baolu
2015-10-28 12:40 ` Greg Kroah-Hartman
2015-10-29 1:22 ` Lu, Baolu
2015-10-30 12:09 ` Lu, Baolu
2015-10-30 14:45 ` Greg Kroah-Hartman
2015-11-02 13:07 ` Lu, Baolu
2015-10-28 8:00 ` [PATCH 02/12] x86: fixmap: add permanent fixmap for xhci debug port Lu Baolu
2015-10-28 8:00 ` [PATCH 03/12] usb: xhci: dbc: probe and setup xhci debug capability Lu Baolu
2015-10-28 8:00 ` Lu Baolu [this message]
2015-10-28 8:00 ` [PATCH 05/12] usb: xhci: dbc: add debug buffer Lu Baolu
2015-10-28 8:00 ` [PATCH 06/12] usb: xhci: dbc: add bulk out and bulk in interfaces Lu Baolu
2015-10-28 8:00 ` [PATCH 07/12] usb: xhci: dbc: handle dbc-configured exit Lu Baolu
2015-10-28 8:00 ` [PATCH 08/12] usb: xhci: dbc: handle endpoint stall Lu Baolu
2015-10-28 8:00 ` [PATCH 09/12] x86: early_printk: add USB3 debug port earlyprintk support Lu Baolu
2015-10-28 8:00 ` [PATCH 10/12] usb: xhci: dbc: add handshake between debug target and host Lu Baolu
2015-10-28 8:00 ` [PATCH 11/12] usb: serial: usb_debug: add support for dbc debug device Lu Baolu
2015-10-28 9:10 ` Johan Hovold
2015-10-29 1:24 ` Lu, Baolu
2015-10-28 12:33 ` Greg Kroah-Hartman
2015-10-29 1:43 ` Lu, Baolu
2015-10-30 11:46 ` Lu, Baolu
2015-10-30 14:41 ` Greg Kroah-Hartman
2015-10-31 5:37 ` Lu, Baolu
2015-10-28 8:00 ` [PATCH 12/12] usb: doc: add document for xHCI DbC driver Lu Baolu
2015-11-03 9:42 ` [PATCH 00/12] usb: early: add support for early printk through USB3 debug port Dave Young
2015-11-04 0:40 ` Lu, Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446019243-5565-5-git-send-email-baolu.lu@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.