From: Gerd Hoffmann <kraxel@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-trivial@nongnu.org, "Léo Grange" <grangeleo@gmail.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-trivial] [PATCH][TRIVIAL] spice: fix checking for surface bpp match
Date: Thu, 29 Oct 2015 10:27:22 +0100 [thread overview]
Message-ID: <1446110842.5722.19.camel@redhat.com> (raw)
In-Reply-To: <5631D48D.90007@msgid.tls.msk.ru>
On Do, 2015-10-29 at 11:10 +0300, Michael Tokarev wrote:
> 22.09.2015 10:41, Michael Tokarev wrote:
> > 17.09.2015 19:18, Léo Grange wrote:
> >> Ping, as I had no feedback about this small patch.
> >> Please tell me if I need to do anything else.
> >
> > Hello!
> >
> > I've seen initial version of your patch, thought it isn't exactly trivial ;),
> > and hoped someone will comment. Only now I realized you sent it to -trivial
> > but not to -devel, so there's no one to comment on it. Please don't do this,
> > always include qemu-devel when sending patches, so a patch will have a
> > chance to be reviewed. I've added qemu-devel to Cc now.
> >
> > Here, I _think_ the patch is okay, but it'd be better for it to have some
> > review still.
>
> Gerd, Cc'ing you this time, can you please take a look at this patch?
Obsolete, commit b2af43cc379e1d4c30d92af257bedebf0e3f618a fixes this
(and a few more cases).
cheers,
Gerd
WARNING: multiple messages have this Message-ID (diff)
From: Gerd Hoffmann <kraxel@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-trivial@nongnu.org, "Léo Grange" <grangeleo@gmail.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH][TRIVIAL] spice: fix checking for surface bpp match
Date: Thu, 29 Oct 2015 10:27:22 +0100 [thread overview]
Message-ID: <1446110842.5722.19.camel@redhat.com> (raw)
In-Reply-To: <5631D48D.90007@msgid.tls.msk.ru>
On Do, 2015-10-29 at 11:10 +0300, Michael Tokarev wrote:
> 22.09.2015 10:41, Michael Tokarev wrote:
> > 17.09.2015 19:18, Léo Grange wrote:
> >> Ping, as I had no feedback about this small patch.
> >> Please tell me if I need to do anything else.
> >
> > Hello!
> >
> > I've seen initial version of your patch, thought it isn't exactly trivial ;),
> > and hoped someone will comment. Only now I realized you sent it to -trivial
> > but not to -devel, so there's no one to comment on it. Please don't do this,
> > always include qemu-devel when sending patches, so a patch will have a
> > chance to be reviewed. I've added qemu-devel to Cc now.
> >
> > Here, I _think_ the patch is okay, but it'd be better for it to have some
> > review still.
>
> Gerd, Cc'ing you this time, can you please take a look at this patch?
Obsolete, commit b2af43cc379e1d4c30d92af257bedebf0e3f618a fixes this
(and a few more cases).
cheers,
Gerd
next prev parent reply other threads:[~2015-10-29 9:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-06 15:36 [Qemu-trivial] [PATCH][TRIVIAL] spice: fix checking for surface bpp match Leo Grange
2015-09-17 16:18 ` Léo Grange
2015-09-22 7:41 ` Michael Tokarev
2015-09-22 7:41 ` [Qemu-devel] " Michael Tokarev
2015-10-29 8:10 ` [Qemu-trivial] " Michael Tokarev
2015-10-29 8:10 ` [Qemu-devel] " Michael Tokarev
2015-10-29 9:27 ` Gerd Hoffmann [this message]
2015-10-29 9:27 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446110842.5722.19.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=grangeleo@gmail.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.