From: Johannes Berg <johannes@sipsolutions.net>
To: Krishna Chaitanya <chaitanya.mgit@gmail.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: Undocumented Sleep Requirements for ieee80211_ops
Date: Fri, 30 Oct 2015 10:37:24 +0100 [thread overview]
Message-ID: <1446197844.3261.18.camel@sipsolutions.net> (raw)
In-Reply-To: <CABPxzYJNCFzCWgbRYxGbkrf1x6BPupC8+O5R7167FDL1rK+4mA@mail.gmail.com> (sfid-20151029_074633_916410_0CB28043)
On Thu, 2015-10-29 at 12:16 +0530, Krishna Chaitanya wrote:
> Hi,
>
> From the documentation:(mac80211.h) For the ieee80211_ops
> (un)assign_vif_chanctx, there is no mention of explicit sleep
> requirements (allowed/disallwoed) for the callback.
Same goes for drv_switch_vif_chanctx().
> From a quick glance at the code calling the OP, looks like we can
> sleep (mutexes are used). So how should we handle such OPS? is it ok
> to sleep in the callback?
>
You can sleep, and I'd appreciate if you sent a patch to add
might_sleep() to the code and the appropriate documentation.
johannes
next prev parent reply other threads:[~2015-10-30 9:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-29 6:46 Undocumented Sleep Requirements for ieee80211_ops Krishna Chaitanya
2015-10-30 9:37 ` Johannes Berg [this message]
2015-10-30 10:11 ` Krishna Chaitanya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446197844.3261.18.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=chaitanya.mgit@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.